All of lore.kernel.org
 help / color / mirror / Atom feed
From: Dmitry Torokhov <dmitry.torokhov@gmail.com>
To: Chris Verges <chrisv@cyberswitching.com>
Cc: Mike Frysinger <vapier@gentoo.org>,
	"linux-input@vger.kernel.org" <linux-input@vger.kernel.org>,
	"uclinux-dist-devel@blackfin.uclinux.org"
	<uclinux-dist-devel@blackfin.uclinux.org>,
	Michael Hennerich <michael.hennerich@analog.com>,
	Luotao Fu <l.fu@pengutronix.de>,
	Barry Song <barry.song@analog.com>
Subject: Re: [PATCH v3] input/misc: new ADXL345/346 driver
Date: Tue, 20 Oct 2009 20:14:23 -0700	[thread overview]
Message-ID: <332DEBB9-8211-471F-9525-109E43B9C1CC@gmail.com> (raw)

Hi Chris,

On Tue, Oct 20, 2009 at 11:46:08AM -0700, Chris Verges wrote:
> Hi Mike and Michael,
>
>> +config INPUT_ADXL34X
>> +config INPUT_ADXL34X_I2C
>> +config INPUT_ADXL34X_SPI
>
> Should the INPUT_ADXL34X option be auto-selected when the _I2C or _SPI
> counterparts are selected?  Something like:
>
> config HAVE_INPUT_ADXL34X
>
> config INPUT_ADXL34X
>    depends on HAVE_INPUT_ADXL34X
>
> config INPUT_ADXL34X_I2C
>    bool "..."
>    depends on I2C
>    select HAVE_INPUT_ADXL34X
>
> config INPUT_ADXL34X_SPI
>    bool "..."
>    depends on SPI_MASTER
>    select HAVE_INPUT_ADXL34X
>
> The end user would only see the INPUT_ADXL34X_SPI and  
> INPUT_ADXL34X_I2C
> options, with the common INPUT_ADXL34X option being automagically
> selected due to the reverse dependencies.
>

I don't see any problem with the original patch when user selects chip
support and then presented with choice of buses.

-- 
Dmitry

             reply	other threads:[~2009-10-21  3:14 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-10-21  3:14 Dmitry Torokhov [this message]
2009-12-10 15:21 ` [Uclinux-dist-devel] [PATCH v3] input/misc: new ADXL345/346driver Robin Getz
  -- strict thread matches above, loose matches on Subject: below --
2009-10-14 10:54 [PATCH v2] input/misc: new ADXL345/346 driver Mike Frysinger
2009-10-20  8:40 ` [PATCH v3] " Mike Frysinger
2009-10-20 18:46   ` Chris Verges
2010-06-25  7:14   ` Dmitry Torokhov
     [not found]     ` <20100625071425.GA631-WlK9ik9hQGAhIp7JRqBPierSzoNAToWh@public.gmane.org>
2010-06-25 13:59       ` Hennerich, Michael
2010-07-01  7:53         ` Dmitry Torokhov
2010-07-01  9:15           ` Hennerich, Michael
2010-07-01 16:08             ` Dmitry Torokhov
2010-08-05 12:30           ` Hennerich, Michael
2010-08-06  5:37             ` Dmitry Torokhov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=332DEBB9-8211-471F-9525-109E43B9C1CC@gmail.com \
    --to=dmitry.torokhov@gmail.com \
    --cc=barry.song@analog.com \
    --cc=chrisv@cyberswitching.com \
    --cc=l.fu@pengutronix.de \
    --cc=linux-input@vger.kernel.org \
    --cc=michael.hennerich@analog.com \
    --cc=uclinux-dist-devel@blackfin.uclinux.org \
    --cc=vapier@gentoo.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.