From mboxrd@z Thu Jan  1 00:00:00 1970
From: Thomas Monjalon <thomas@monjalon.net>
Subject: Re: [PATCH v8 05/13] telemetry: add client feature and
	sockets
Date: Thu, 25 Oct 2018 22:41:53 +0200
Message-ID: <3330387.zQnsHCFWfj@xps>
References: <20181024132725.5142-1-kevin.laatz@intel.com>
 <20181024160311.85457-6-kevin.laatz@intel.com> <1665076.LlyA82DdBn@xps>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7Bit
Cc: dev@dpdk.org, harry.van.haaren@intel.com, stephen@networkplumber.org,
 gaetan.rivet@6wind.com, shreyansh.jain@nxp.com, mattias.ronnblom@ericsson.com,
 bruce.richardson@intel.com, Ciara Power <ciara.power@intel.com>,
 Brian Archbold <brian.archbold@intel.com>
To: Kevin Laatz <kevin.laatz@intel.com>
Return-path: <dev-bounces@dpdk.org>
Received: from out3-smtp.messagingengine.com (out3-smtp.messagingengine.com
 [66.111.4.27]) by dpdk.org (Postfix) with ESMTP id 20ACE7D4A
 for <dev@dpdk.org>; Thu, 25 Oct 2018 22:41:53 +0200 (CEST)
In-Reply-To: <1665076.LlyA82DdBn@xps>
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

25/10/2018 22:29, Thomas Monjalon:
> 24/10/2018 18:03, Kevin Laatz:
> > --- a/lib/librte_telemetry/meson.build
> > +++ b/lib/librte_telemetry/meson.build
> > @@ -5,3 +5,5 @@ sources = files('rte_telemetry.c')
> >  headers = files('rte_telemetry.h', 'rte_telemetry_internal.h')
> >  deps += ['metrics', 'ethdev']
> >  cflags += '-DALLOW_EXPERIMENTAL_API'
> > +jansson = cc.find_library('jansson', required: true)
> > +ext_deps += jansson
> 
> I just discovered an issue when trying to compile for arm64
> (with devtools/test-meson-builds.sh):
> 
> /usr/lib/gcc/aarch64-linux-gnu/8.2.0/../../../../aarch64-linux-gnu/bin/ld:
> 	cannot find -ljansson
> 
> I am worried because it is a real blocker.

The dependency must be optional.
Should we disable the library if jansson is not found?