All of lore.kernel.org
 help / color / mirror / Atom feed
From: Thomas Monjalon <thomas@monjalon.net>
To: Stephen Hemminger <stephen@networkplumber.org>,
	Ferruh Yigit <ferruh.yigit@intel.com>,
	Ajit Khaparde <ajit.khaparde@broadcom.com>
Cc: Lance Richardson <lance.richardson@broadcom.com>,
	dpdk-dev <dev@dpdk.org>,
	Bruce Richardson <bruce.richardson@intel.com>,
	Andrew Rybchenko <arybchenko@solarflare.com>
Subject: Re: [dpdk-dev] [dpdk-stable] [PATCH] net/bnxt: allow configuring vector mode
Date: Tue, 31 Mar 2020 19:13:50 +0200	[thread overview]
Message-ID: <3333271.ZzFAyJQhcr@xps> (raw)
In-Reply-To: <20200331085830.343dc7e6@hermes.lan>

31/03/2020 17:58, Stephen Hemminger:
> On Tue, 31 Mar 2020 17:43:55 +0200
> Thomas Monjalon <thomas@monjalon.net> wrote:
> > 31/03/2020 16:31, Ajit Khaparde:
> > > On Tue, Mar 31, 2020 at 4:36 AM Ferruh Yigit <ferruh.yigit@intel.com> wrote:
> > > > I saw Ajit merged this patch to brcm tree, but I am not sure about it. We
> > > > have
> > > > already removed this compile time option from some PMDs, and driver tries
> > > > to
> > > > detect to use or not to use vectorization transparently.
> > > >
> > > > This config is also a problem for the meson, which always sets the flag in
> > > > a
> > > > hardcoded way.
> > > >
> > > > But also I am not sure about to need to enable/disable vectorization
> > > > explicitly,
> > > > this patch seems because of this need. As far as I remember in the past
> > > > this
> > > > type of runtime configuration rejected to not make driver configuration
> > > > more
> > > > complex.  
> > > 
> > > Since we need a way to disable or enable vector mode.  
> > 
> > Why do you need to disable vector optimization?
> > Is it for debugging?
> 
> The rte_flow mark operation does not work with the vector optimization.
> 
> The choice to use vector mode is done by the driver earlier in
> the initialization process, and then when application programs rte_flow
> it has a problem; the flow create would fail.

Could we imagine switching the Rx implementation dynamically between 2 bursts?



  reply	other threads:[~2020-03-31 17:13 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-03-05  6:45 [dpdk-dev] [PATCH] net/bnxt: allow configuring vector mode Stephen Hemminger
2020-03-05 20:10 ` Lance Richardson
2020-03-05 22:18   ` Stephen Hemminger
2020-03-31 11:36     ` [dpdk-dev] [dpdk-stable] " Ferruh Yigit
2020-03-31 14:31       ` Ajit Khaparde
2020-03-31 15:43         ` Thomas Monjalon
2020-03-31 15:58           ` Stephen Hemminger
2020-03-31 17:13             ` Thomas Monjalon [this message]
2020-03-24  4:02 ` [dpdk-dev] " Ajit Khaparde
2020-04-24 17:32 ` [dpdk-dev] [PATCH] net/bnxt: disable vector mode if flow mark is used Stephen Hemminger

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=3333271.ZzFAyJQhcr@xps \
    --to=thomas@monjalon.net \
    --cc=ajit.khaparde@broadcom.com \
    --cc=arybchenko@solarflare.com \
    --cc=bruce.richardson@intel.com \
    --cc=dev@dpdk.org \
    --cc=ferruh.yigit@intel.com \
    --cc=lance.richardson@broadcom.com \
    --cc=stephen@networkplumber.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.