From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752935AbeDSNPV (ORCPT ); Thu, 19 Apr 2018 09:15:21 -0400 Received: from mail.micronovasrl.com ([212.103.203.10]:58918 "EHLO mail.micronovasrl.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752854AbeDSNPT (ORCPT ); Thu, 19 Apr 2018 09:15:19 -0400 Authentication-Results: mail.micronovasrl.com (amavisd-new); dkim=pass reason="pass (just generated, assumed good)" header.d=micronovasrl.com X-Spam-Flag: NO X-Spam-Score: -2.899 Subject: Re: [PATCH 4/6] drm/panel: simple: Add support for Banana Pi 7" S070WV20-CT16 panel To: Chen-Yu Tsai Cc: Maxime Ripard , David Airlie , Thierry Reding , Rob Herring , Mark Rutland , dri-devel , linux-arm-kernel , linux-kernel , devicetree , Jonathan Liu References: <20180419093225.614-1-wens@csie.org> <20180419093225.614-5-wens@csie.org> <58ce9e3b-00ee-87d2-f05b-b9f1414d1cfa@micronovasrl.com> From: Giulio Benetti Message-ID: <3341fcae-2146-b3b4-be41-b7e5167c2147@micronovasrl.com> Date: Thu, 19 Apr 2018 15:15:13 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.7.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: it Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi, Il 19/04/2018 14:45, Chen-Yu Tsai ha scritto: > On Thu, Apr 19, 2018 at 8:31 PM, Giulio Benetti > wrote: >> Hi, >> >> Il 19/04/2018 11:32, Chen-Yu Tsai ha scritto: >>> >>> This panel is marketed as Banana Pi 7" LCD display. On the back is >>> a sticker denoting the model name S070WV20-CT16. >> >> >> Judging from the code, the real vendor should be CDTech. >> Take a look at their website: >> http://www.cdtech-lcd.com/en/standardscreen.html >> >> I point you my patch for inserting another similar panel: >> https://patchwork.freedesktop.org/patch/211914/ >> >> Maybe it would make sense to use CDTech as the vendor, >> because maybe Bananapi resells only it. >> Or maybe it is a custom panel done for them, >> but the same is for other panels I've submitted patches. >> Micronova srl custom, but vendor is CDTech. >> >> What do you think? > > That might be true. But for people without access to the vendors, > this is horribly hard to figure out. People are only going to look > at whatever marking there is on the LCD panel, and whatever the > seller says. This panel has the model number stickered on, but the > PCB attached to it only has the Banana Pi logo. Ah ok, my fault, I didn't see it has a PCB attached with Banana Pi logo. Also it makes a lot of sense what you say about people looking for display. > > And given it's a custom piece, probably OEM or ODM, the real > manufacturer matters less. You don't mention "Foxconn" as the > vendor of the iPhone, do you? :) that's right. Best regards -- Giulio Benetti CTO MICRONOVA SRL Sede: Via A. Niedda 3 - 35010 Vigonza (PD) Tel. 049/8931563 - Fax 049/8931346 Cod.Fiscale - P.IVA 02663420285 Capitale Sociale € 26.000 i.v. Iscritta al Reg. Imprese di Padova N. 02663420285 Numero R.E.A. 258642 > > ChenYu > >> >> -- >> Giulio Benetti >> CTO >> >> MICRONOVA SRL >> Sede: Via A. Niedda 3 - 35010 Vigonza (PD) >> Tel. 049/8931563 - Fax 049/8931346 >> Cod.Fiscale - P.IVA 02663420285 >> Capitale Sociale € 26.000 i.v. >> Iscritta al Reg. Imprese di Padova N. 02663420285 >> Numero R.E.A. 258642 >> >> >>> >>> This is a 7" 800x480 panel connected through a 24-bit RGB interface. >>> However the panel only does 262k colors. >>> >>> Signed-off-by: Chen-Yu Tsai >>> --- >>> .../display/panel/bananapi,s070wv20-ct16.txt | 7 ++++++ >>> drivers/gpu/drm/panel/panel-simple.c | 25 +++++++++++++++++++ >>> 2 files changed, 32 insertions(+) >>> create mode 100644 >>> Documentation/devicetree/bindings/display/panel/bananapi,s070wv20-ct16.txt >>> >>> diff --git >>> a/Documentation/devicetree/bindings/display/panel/bananapi,s070wv20-ct16.txt >>> b/Documentation/devicetree/bindings/display/panel/bananapi,s070wv20-ct16.txt >>> new file mode 100644 >>> index 000000000000..2ec35ce36e9a >>> --- /dev/null >>> +++ >>> b/Documentation/devicetree/bindings/display/panel/bananapi,s070wv20-ct16.txt >>> @@ -0,0 +1,7 @@ >>> +Banana Pi 7" (S070WV20-CT16) TFT LCD Panel >>> + >>> +Required properties: >>> +- compatible: should be "bananapi,s070wv20-ct16" >>> + >>> +This binding is compatible with the simple-panel binding, which is >>> specified >>> +in simple-panel.txt in this directory. >>> diff --git a/drivers/gpu/drm/panel/panel-simple.c >>> b/drivers/gpu/drm/panel/panel-simple.c >>> index cbf1ab404ee7..9bc037f74d6c 100644 >>> --- a/drivers/gpu/drm/panel/panel-simple.c >>> +++ b/drivers/gpu/drm/panel/panel-simple.c >>> @@ -745,6 +745,28 @@ static const struct panel_desc avic_tm070ddh03 = { >>> }, >>> }; >>> +static const struct drm_display_mode bananapi_s070wv20_ct16_mode = { >>> + .clock = 30000, >>> + .hdisplay = 800, >>> + .hsync_start = 800 + 40, >>> + .hsync_end = 800 + 40 + 48, >>> + .htotal = 800 + 40 + 48 + 40, >>> + .vdisplay = 480, >>> + .vsync_start = 480 + 13, >>> + .vsync_end = 480 + 13 + 3, >>> + .vtotal = 480 + 13 + 3 + 29, >>> +}; >>> + >>> +static const struct panel_desc bananapi_s070wv20_ct16 = { >>> + .modes = &bananapi_s070wv20_ct16_mode, >>> + .num_modes = 1, >>> + .bpc = 6, >>> + .size = { >>> + .width = 154, >>> + .height = 86, >>> + }, >>> +}; >>> + >>> static const struct drm_display_mode boe_nv101wxmn51_modes[] = { >>> { >>> .clock = 71900, >>> @@ -2112,6 +2134,9 @@ static const struct of_device_id platform_of_match[] >>> = { >>> }, { >>> .compatible = "avic,tm070ddh03", >>> .data = &avic_tm070ddh03, >>> + }, { >>> + .compatible = "bananapi,s070wv20-ct16", >>> + .data = &bananapi_s070wv20_ct16, >>> }, { >>> .compatible = "boe,nv101wxmn51", >>> .data = &boe_nv101wxmn51, >>> >> >> >> > -- > To unsubscribe from this list: send the line "unsubscribe devicetree" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html > From mboxrd@z Thu Jan 1 00:00:00 1970 From: Giulio Benetti Subject: Re: [PATCH 4/6] drm/panel: simple: Add support for Banana Pi 7" S070WV20-CT16 panel Date: Thu, 19 Apr 2018 15:15:13 +0200 Message-ID: <3341fcae-2146-b3b4-be41-b7e5167c2147@micronovasrl.com> References: <20180419093225.614-1-wens@csie.org> <20180419093225.614-5-wens@csie.org> <58ce9e3b-00ee-87d2-f05b-b9f1414d1cfa@micronovasrl.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8"; Format="flowed" Content-Transfer-Encoding: base64 Return-path: In-Reply-To: Content-Language: it List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Chen-Yu Tsai Cc: Mark Rutland , devicetree , Jonathan Liu , Rob Herring , Maxime Ripard , linux-kernel , dri-devel , David Airlie , Thierry Reding , linux-arm-kernel List-Id: devicetree@vger.kernel.org SGksCgpJbCAxOS8wNC8yMDE4IDE0OjQ1LCBDaGVuLVl1IFRzYWkgaGEgc2NyaXR0bzoKPiBPbiBU aHUsIEFwciAxOSwgMjAxOCBhdCA4OjMxIFBNLCBHaXVsaW8gQmVuZXR0aQo+IDxnaXVsaW8uYmVu ZXR0aUBtaWNyb25vdmFzcmwuY29tPiB3cm90ZToKPj4gSGksCj4+Cj4+IElsIDE5LzA0LzIwMTgg MTE6MzIsIENoZW4tWXUgVHNhaSBoYSBzY3JpdHRvOgo+Pj4KPj4+IFRoaXMgcGFuZWwgaXMgbWFy a2V0ZWQgYXMgQmFuYW5hIFBpIDciIExDRCBkaXNwbGF5LiBPbiB0aGUgYmFjayBpcwo+Pj4gYSBz dGlja2VyIGRlbm90aW5nIHRoZSBtb2RlbCBuYW1lIFMwNzBXVjIwLUNUMTYuCj4+Cj4+Cj4+IEp1 ZGdpbmcgZnJvbSB0aGUgY29kZSwgdGhlIHJlYWwgdmVuZG9yIHNob3VsZCBiZSBDRFRlY2guCj4+ IFRha2UgYSBsb29rIGF0IHRoZWlyIHdlYnNpdGU6Cj4+IGh0dHA6Ly93d3cuY2R0ZWNoLWxjZC5j b20vZW4vc3RhbmRhcmRzY3JlZW4uaHRtbAo+Pgo+PiBJIHBvaW50IHlvdSBteSBwYXRjaCBmb3Ig aW5zZXJ0aW5nIGFub3RoZXIgc2ltaWxhciBwYW5lbDoKPj4gaHR0cHM6Ly9wYXRjaHdvcmsuZnJl ZWRlc2t0b3Aub3JnL3BhdGNoLzIxMTkxNC8KPj4KPj4gTWF5YmUgaXQgd291bGQgbWFrZSBzZW5z ZSB0byB1c2UgQ0RUZWNoIGFzIHRoZSB2ZW5kb3IsCj4+IGJlY2F1c2UgbWF5YmUgQmFuYW5hcGkg cmVzZWxscyBvbmx5IGl0Lgo+PiBPciBtYXliZSBpdCBpcyBhIGN1c3RvbSBwYW5lbCBkb25lIGZv ciB0aGVtLAo+PiBidXQgdGhlIHNhbWUgaXMgZm9yIG90aGVyIHBhbmVscyBJJ3ZlIHN1Ym1pdHRl ZCBwYXRjaGVzLgo+PiBNaWNyb25vdmEgc3JsIGN1c3RvbSwgYnV0IHZlbmRvciBpcyBDRFRlY2gu Cj4+Cj4+IFdoYXQgZG8geW91IHRoaW5rPwo+IAo+IFRoYXQgbWlnaHQgYmUgdHJ1ZS4gQnV0IGZv ciBwZW9wbGUgd2l0aG91dCBhY2Nlc3MgdG8gdGhlIHZlbmRvcnMsCj4gdGhpcyBpcyBob3JyaWJs eSBoYXJkIHRvIGZpZ3VyZSBvdXQuIFBlb3BsZSBhcmUgb25seSBnb2luZyB0byBsb29rCj4gYXQg d2hhdGV2ZXIgbWFya2luZyB0aGVyZSBpcyBvbiB0aGUgTENEIHBhbmVsLCBhbmQgd2hhdGV2ZXIg dGhlCj4gc2VsbGVyIHNheXMuIFRoaXMgcGFuZWwgaGFzIHRoZSBtb2RlbCBudW1iZXIgc3RpY2tl cmVkIG9uLCBidXQgdGhlCj4gUENCIGF0dGFjaGVkIHRvIGl0IG9ubHkgaGFzIHRoZSBCYW5hbmEg UGkgbG9nby4KCkFoIG9rLCBteSBmYXVsdCwgSSBkaWRuJ3Qgc2VlIGl0IGhhcyBhIFBDQiBhdHRh Y2hlZCB3aXRoIEJhbmFuYSBQaSBsb2dvLgpBbHNvIGl0IG1ha2VzIGEgbG90IG9mIHNlbnNlIHdo YXQgeW91IHNheSBhYm91dCBwZW9wbGUgbG9va2luZyBmb3IgZGlzcGxheS4KCj4gCj4gQW5kIGdp dmVuIGl0J3MgYSBjdXN0b20gcGllY2UsIHByb2JhYmx5IE9FTSBvciBPRE0sIHRoZSByZWFsCj4g bWFudWZhY3R1cmVyIG1hdHRlcnMgbGVzcy4gWW91IGRvbid0IG1lbnRpb24gIkZveGNvbm4iIGFz IHRoZQo+IHZlbmRvciBvZiB0aGUgaVBob25lLCBkbyB5b3U/Cgo6KSB0aGF0J3MgcmlnaHQuCgpC ZXN0IHJlZ2FyZHMKCi0tIApHaXVsaW8gQmVuZXR0aQpDVE8KCk1JQ1JPTk9WQSBTUkwKU2VkZTog VmlhIEEuIE5pZWRkYSAzIC0gMzUwMTAgVmlnb256YSAoUEQpClRlbC4gMDQ5Lzg5MzE1NjMgLSBG YXggMDQ5Lzg5MzEzNDYKQ29kLkZpc2NhbGUgLSBQLklWQSAwMjY2MzQyMDI4NQpDYXBpdGFsZSBT b2NpYWxlIOKCrCAyNi4wMDAgaS52LgpJc2NyaXR0YSBhbCBSZWcuIEltcHJlc2UgZGkgUGFkb3Zh IE4uIDAyNjYzNDIwMjg1Ck51bWVybyBSLkUuQS4gMjU4NjQyCgo+IAo+IENoZW5ZdQo+IAo+Pgo+ PiAtLQo+PiBHaXVsaW8gQmVuZXR0aQo+PiBDVE8KPj4KPj4gTUlDUk9OT1ZBIFNSTAo+PiBTZWRl OiBWaWEgQS4gTmllZGRhIDMgLSAzNTAxMCBWaWdvbnphIChQRCkKPj4gVGVsLiAwNDkvODkzMTU2 MyAtIEZheCAwNDkvODkzMTM0Ngo+PiBDb2QuRmlzY2FsZSAtIFAuSVZBIDAyNjYzNDIwMjg1Cj4+ IENhcGl0YWxlIFNvY2lhbGUg4oKsIDI2LjAwMCBpLnYuCj4+IElzY3JpdHRhIGFsIFJlZy4gSW1w cmVzZSBkaSBQYWRvdmEgTi4gMDI2NjM0MjAyODUKPj4gTnVtZXJvIFIuRS5BLiAyNTg2NDIKPj4K Pj4KPj4+Cj4+PiBUaGlzIGlzIGEgNyIgODAweDQ4MCBwYW5lbCBjb25uZWN0ZWQgdGhyb3VnaCBh IDI0LWJpdCBSR0IgaW50ZXJmYWNlLgo+Pj4gSG93ZXZlciB0aGUgcGFuZWwgb25seSBkb2VzIDI2 MmsgY29sb3JzLgo+Pj4KPj4+IFNpZ25lZC1vZmYtYnk6IENoZW4tWXUgVHNhaSA8d2Vuc0Bjc2ll Lm9yZz4KPj4+IC0tLQo+Pj4gICAgLi4uL2Rpc3BsYXkvcGFuZWwvYmFuYW5hcGksczA3MHd2MjAt Y3QxNi50eHQgIHwgIDcgKysrKysrCj4+PiAgICBkcml2ZXJzL2dwdS9kcm0vcGFuZWwvcGFuZWwt c2ltcGxlLmMgICAgICAgICAgfCAyNSArKysrKysrKysrKysrKysrKysrCj4+PiAgICAyIGZpbGVz IGNoYW5nZWQsIDMyIGluc2VydGlvbnMoKykKPj4+ICAgIGNyZWF0ZSBtb2RlIDEwMDY0NAo+Pj4g RG9jdW1lbnRhdGlvbi9kZXZpY2V0cmVlL2JpbmRpbmdzL2Rpc3BsYXkvcGFuZWwvYmFuYW5hcGks czA3MHd2MjAtY3QxNi50eHQKPj4+Cj4+PiBkaWZmIC0tZ2l0Cj4+PiBhL0RvY3VtZW50YXRpb24v ZGV2aWNldHJlZS9iaW5kaW5ncy9kaXNwbGF5L3BhbmVsL2JhbmFuYXBpLHMwNzB3djIwLWN0MTYu dHh0Cj4+PiBiL0RvY3VtZW50YXRpb24vZGV2aWNldHJlZS9iaW5kaW5ncy9kaXNwbGF5L3BhbmVs L2JhbmFuYXBpLHMwNzB3djIwLWN0MTYudHh0Cj4+PiBuZXcgZmlsZSBtb2RlIDEwMDY0NAo+Pj4g aW5kZXggMDAwMDAwMDAwMDAwLi4yZWMzNWNlMzZlOWEKPj4+IC0tLSAvZGV2L251bGwKPj4+ICsr Kwo+Pj4gYi9Eb2N1bWVudGF0aW9uL2RldmljZXRyZWUvYmluZGluZ3MvZGlzcGxheS9wYW5lbC9i YW5hbmFwaSxzMDcwd3YyMC1jdDE2LnR4dAo+Pj4gQEAgLTAsMCArMSw3IEBACj4+PiArQmFuYW5h IFBpIDciIChTMDcwV1YyMC1DVDE2KSBURlQgTENEIFBhbmVsCj4+PiArCj4+PiArUmVxdWlyZWQg cHJvcGVydGllczoKPj4+ICstIGNvbXBhdGlibGU6IHNob3VsZCBiZSAiYmFuYW5hcGksczA3MHd2 MjAtY3QxNiIKPj4+ICsKPj4+ICtUaGlzIGJpbmRpbmcgaXMgY29tcGF0aWJsZSB3aXRoIHRoZSBz aW1wbGUtcGFuZWwgYmluZGluZywgd2hpY2ggaXMKPj4+IHNwZWNpZmllZAo+Pj4gK2luIHNpbXBs ZS1wYW5lbC50eHQgaW4gdGhpcyBkaXJlY3RvcnkuCj4+PiBkaWZmIC0tZ2l0IGEvZHJpdmVycy9n cHUvZHJtL3BhbmVsL3BhbmVsLXNpbXBsZS5jCj4+PiBiL2RyaXZlcnMvZ3B1L2RybS9wYW5lbC9w YW5lbC1zaW1wbGUuYwo+Pj4gaW5kZXggY2JmMWFiNDA0ZWU3Li45YmMwMzdmNzRkNmMgMTAwNjQ0 Cj4+PiAtLS0gYS9kcml2ZXJzL2dwdS9kcm0vcGFuZWwvcGFuZWwtc2ltcGxlLmMKPj4+ICsrKyBi L2RyaXZlcnMvZ3B1L2RybS9wYW5lbC9wYW5lbC1zaW1wbGUuYwo+Pj4gQEAgLTc0NSw2ICs3NDUs MjggQEAgc3RhdGljIGNvbnN0IHN0cnVjdCBwYW5lbF9kZXNjIGF2aWNfdG0wNzBkZGgwMyA9IHsK Pj4+ICAgICAgICAgIH0sCj4+PiAgICB9Owo+Pj4gICAgK3N0YXRpYyBjb25zdCBzdHJ1Y3QgZHJt X2Rpc3BsYXlfbW9kZSBiYW5hbmFwaV9zMDcwd3YyMF9jdDE2X21vZGUgPSB7Cj4+PiArICAgICAg IC5jbG9jayA9IDMwMDAwLAo+Pj4gKyAgICAgICAuaGRpc3BsYXkgPSA4MDAsCj4+PiArICAgICAg IC5oc3luY19zdGFydCA9IDgwMCArIDQwLAo+Pj4gKyAgICAgICAuaHN5bmNfZW5kID0gODAwICsg NDAgKyA0OCwKPj4+ICsgICAgICAgLmh0b3RhbCA9IDgwMCArIDQwICsgNDggKyA0MCwKPj4+ICsg ICAgICAgLnZkaXNwbGF5ID0gNDgwLAo+Pj4gKyAgICAgICAudnN5bmNfc3RhcnQgPSA0ODAgKyAx MywKPj4+ICsgICAgICAgLnZzeW5jX2VuZCA9IDQ4MCArIDEzICsgMywKPj4+ICsgICAgICAgLnZ0 b3RhbCA9IDQ4MCArIDEzICsgMyArIDI5LAo+Pj4gK307Cj4+PiArCj4+PiArc3RhdGljIGNvbnN0 IHN0cnVjdCBwYW5lbF9kZXNjIGJhbmFuYXBpX3MwNzB3djIwX2N0MTYgPSB7Cj4+PiArICAgICAg IC5tb2RlcyA9ICZiYW5hbmFwaV9zMDcwd3YyMF9jdDE2X21vZGUsCj4+PiArICAgICAgIC5udW1f bW9kZXMgPSAxLAo+Pj4gKyAgICAgICAuYnBjID0gNiwKPj4+ICsgICAgICAgLnNpemUgPSB7Cj4+ PiArICAgICAgICAgICAgICAgLndpZHRoID0gMTU0LAo+Pj4gKyAgICAgICAgICAgICAgIC5oZWln aHQgPSA4NiwKPj4+ICsgICAgICAgfSwKPj4+ICt9Owo+Pj4gKwo+Pj4gICAgc3RhdGljIGNvbnN0 IHN0cnVjdCBkcm1fZGlzcGxheV9tb2RlIGJvZV9udjEwMXd4bW41MV9tb2Rlc1tdID0gewo+Pj4g ICAgICAgICAgewo+Pj4gICAgICAgICAgICAgICAgICAuY2xvY2sgPSA3MTkwMCwKPj4+IEBAIC0y MTEyLDYgKzIxMzQsOSBAQCBzdGF0aWMgY29uc3Qgc3RydWN0IG9mX2RldmljZV9pZCBwbGF0Zm9y bV9vZl9tYXRjaFtdCj4+PiA9IHsKPj4+ICAgICAgICAgIH0sIHsKPj4+ICAgICAgICAgICAgICAg ICAgLmNvbXBhdGlibGUgPSAiYXZpYyx0bTA3MGRkaDAzIiwKPj4+ICAgICAgICAgICAgICAgICAg LmRhdGEgPSAmYXZpY190bTA3MGRkaDAzLAo+Pj4gKyAgICAgICB9LCB7Cj4+PiArICAgICAgICAg ICAgICAgLmNvbXBhdGlibGUgPSAiYmFuYW5hcGksczA3MHd2MjAtY3QxNiIsCj4+PiArICAgICAg ICAgICAgICAgLmRhdGEgPSAmYmFuYW5hcGlfczA3MHd2MjBfY3QxNiwKPj4+ICAgICAgICAgIH0s IHsKPj4+ICAgICAgICAgICAgICAgICAgLmNvbXBhdGlibGUgPSAiYm9lLG52MTAxd3htbjUxIiwK Pj4+ICAgICAgICAgICAgICAgICAgLmRhdGEgPSAmYm9lX252MTAxd3htbjUxLAo+Pj4KPj4KPj4K Pj4KPiAtLQo+IFRvIHVuc3Vic2NyaWJlIGZyb20gdGhpcyBsaXN0OiBzZW5kIHRoZSBsaW5lICJ1 bnN1YnNjcmliZSBkZXZpY2V0cmVlIiBpbgo+IHRoZSBib2R5IG9mIGEgbWVzc2FnZSB0byBtYWpv cmRvbW9Admdlci5rZXJuZWwub3JnCj4gTW9yZSBtYWpvcmRvbW8gaW5mbyBhdCAgaHR0cDovL3Zn ZXIua2VybmVsLm9yZy9tYWpvcmRvbW8taW5mby5odG1sCj4gCgoKX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX18KZHJpLWRldmVsIG1haWxpbmcgbGlzdApkcmkt ZGV2ZWxAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHBzOi8vbGlzdHMuZnJlZWRlc2t0b3Aub3Jn L21haWxtYW4vbGlzdGluZm8vZHJpLWRldmVsCg== From mboxrd@z Thu Jan 1 00:00:00 1970 From: giulio.benetti@micronovasrl.com (Giulio Benetti) Date: Thu, 19 Apr 2018 15:15:13 +0200 Subject: [PATCH 4/6] drm/panel: simple: Add support for Banana Pi 7" S070WV20-CT16 panel In-Reply-To: References: <20180419093225.614-1-wens@csie.org> <20180419093225.614-5-wens@csie.org> <58ce9e3b-00ee-87d2-f05b-b9f1414d1cfa@micronovasrl.com> Message-ID: <3341fcae-2146-b3b4-be41-b7e5167c2147@micronovasrl.com> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org Hi, Il 19/04/2018 14:45, Chen-Yu Tsai ha scritto: > On Thu, Apr 19, 2018 at 8:31 PM, Giulio Benetti > wrote: >> Hi, >> >> Il 19/04/2018 11:32, Chen-Yu Tsai ha scritto: >>> >>> This panel is marketed as Banana Pi 7" LCD display. On the back is >>> a sticker denoting the model name S070WV20-CT16. >> >> >> Judging from the code, the real vendor should be CDTech. >> Take a look at their website: >> http://www.cdtech-lcd.com/en/standardscreen.html >> >> I point you my patch for inserting another similar panel: >> https://patchwork.freedesktop.org/patch/211914/ >> >> Maybe it would make sense to use CDTech as the vendor, >> because maybe Bananapi resells only it. >> Or maybe it is a custom panel done for them, >> but the same is for other panels I've submitted patches. >> Micronova srl custom, but vendor is CDTech. >> >> What do you think? > > That might be true. But for people without access to the vendors, > this is horribly hard to figure out. People are only going to look > at whatever marking there is on the LCD panel, and whatever the > seller says. This panel has the model number stickered on, but the > PCB attached to it only has the Banana Pi logo. Ah ok, my fault, I didn't see it has a PCB attached with Banana Pi logo. Also it makes a lot of sense what you say about people looking for display. > > And given it's a custom piece, probably OEM or ODM, the real > manufacturer matters less. You don't mention "Foxconn" as the > vendor of the iPhone, do you? :) that's right. Best regards -- Giulio Benetti CTO MICRONOVA SRL Sede: Via A. Niedda 3 - 35010 Vigonza (PD) Tel. 049/8931563 - Fax 049/8931346 Cod.Fiscale - P.IVA 02663420285 Capitale Sociale ? 26.000 i.v. Iscritta al Reg. Imprese di Padova N. 02663420285 Numero R.E.A. 258642 > > ChenYu > >> >> -- >> Giulio Benetti >> CTO >> >> MICRONOVA SRL >> Sede: Via A. Niedda 3 - 35010 Vigonza (PD) >> Tel. 049/8931563 - Fax 049/8931346 >> Cod.Fiscale - P.IVA 02663420285 >> Capitale Sociale ? 26.000 i.v. >> Iscritta al Reg. Imprese di Padova N. 02663420285 >> Numero R.E.A. 258642 >> >> >>> >>> This is a 7" 800x480 panel connected through a 24-bit RGB interface. >>> However the panel only does 262k colors. >>> >>> Signed-off-by: Chen-Yu Tsai >>> --- >>> .../display/panel/bananapi,s070wv20-ct16.txt | 7 ++++++ >>> drivers/gpu/drm/panel/panel-simple.c | 25 +++++++++++++++++++ >>> 2 files changed, 32 insertions(+) >>> create mode 100644 >>> Documentation/devicetree/bindings/display/panel/bananapi,s070wv20-ct16.txt >>> >>> diff --git >>> a/Documentation/devicetree/bindings/display/panel/bananapi,s070wv20-ct16.txt >>> b/Documentation/devicetree/bindings/display/panel/bananapi,s070wv20-ct16.txt >>> new file mode 100644 >>> index 000000000000..2ec35ce36e9a >>> --- /dev/null >>> +++ >>> b/Documentation/devicetree/bindings/display/panel/bananapi,s070wv20-ct16.txt >>> @@ -0,0 +1,7 @@ >>> +Banana Pi 7" (S070WV20-CT16) TFT LCD Panel >>> + >>> +Required properties: >>> +- compatible: should be "bananapi,s070wv20-ct16" >>> + >>> +This binding is compatible with the simple-panel binding, which is >>> specified >>> +in simple-panel.txt in this directory. >>> diff --git a/drivers/gpu/drm/panel/panel-simple.c >>> b/drivers/gpu/drm/panel/panel-simple.c >>> index cbf1ab404ee7..9bc037f74d6c 100644 >>> --- a/drivers/gpu/drm/panel/panel-simple.c >>> +++ b/drivers/gpu/drm/panel/panel-simple.c >>> @@ -745,6 +745,28 @@ static const struct panel_desc avic_tm070ddh03 = { >>> }, >>> }; >>> +static const struct drm_display_mode bananapi_s070wv20_ct16_mode = { >>> + .clock = 30000, >>> + .hdisplay = 800, >>> + .hsync_start = 800 + 40, >>> + .hsync_end = 800 + 40 + 48, >>> + .htotal = 800 + 40 + 48 + 40, >>> + .vdisplay = 480, >>> + .vsync_start = 480 + 13, >>> + .vsync_end = 480 + 13 + 3, >>> + .vtotal = 480 + 13 + 3 + 29, >>> +}; >>> + >>> +static const struct panel_desc bananapi_s070wv20_ct16 = { >>> + .modes = &bananapi_s070wv20_ct16_mode, >>> + .num_modes = 1, >>> + .bpc = 6, >>> + .size = { >>> + .width = 154, >>> + .height = 86, >>> + }, >>> +}; >>> + >>> static const struct drm_display_mode boe_nv101wxmn51_modes[] = { >>> { >>> .clock = 71900, >>> @@ -2112,6 +2134,9 @@ static const struct of_device_id platform_of_match[] >>> = { >>> }, { >>> .compatible = "avic,tm070ddh03", >>> .data = &avic_tm070ddh03, >>> + }, { >>> + .compatible = "bananapi,s070wv20-ct16", >>> + .data = &bananapi_s070wv20_ct16, >>> }, { >>> .compatible = "boe,nv101wxmn51", >>> .data = &boe_nv101wxmn51, >>> >> >> >> > -- > To unsubscribe from this list: send the line "unsubscribe devicetree" in > the body of a message to majordomo at vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html >