From mboxrd@z Thu Jan  1 00:00:00 1970
From: Thomas Monjalon <thomas@monjalon.net>
Subject: Re: [PATCH v2] eal: enable vfio independent of no PCI
	flag
Date: Sat, 07 Oct 2017 13:37:21 +0200
Message-ID: <3342808.snfueRI35B@xps>
References: <1499946530-29581-1-git-send-email-hemant.agrawal@nxp.com>
 <1507375221-16271-1-git-send-email-hemant.agrawal@nxp.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7Bit
Cc: anatoly.burakov@intel.com, dev@dpdk.org
To: Hemant Agrawal <hemant.agrawal@nxp.com>
Return-path: <dev-bounces@dpdk.org>
Received: from out1-smtp.messagingengine.com (out1-smtp.messagingengine.com
 [66.111.4.25]) by dpdk.org (Postfix) with ESMTP id 6D2D52B9A
 for <dev@dpdk.org>; Sat,  7 Oct 2017 13:37:24 +0200 (CEST)
In-Reply-To: <1507375221-16271-1-git-send-email-hemant.agrawal@nxp.com>
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

07/10/2017 13:20, Hemant Agrawal:
> In case no_pci is configured, other buses e.g. fslmc bus will
> still need the the vfio to be enabled.
> 
> Signed-off-by: Hemant Agrawal <hemant.agrawal@nxp.com>
> ---
> v2: enabled VFIO, independent of no-pci flag as suggested by Thomas
[...]
> --- a/lib/librte_eal/linuxapp/eal/eal.c
> +++ b/lib/librte_eal/linuxapp/eal/eal.c
> @@ -733,10 +733,8 @@ static int rte_eal_vfio_setup(void)
>  {
>  	int vfio_enabled = 0;
>  
> -	if (!internal_config.no_pci) {
> -		pci_vfio_enable();
> -		vfio_enabled |= pci_vfio_is_enabled();
> -	}
> +	pci_vfio_enable();
> +	vfio_enabled |= pci_vfio_is_enabled();

You are enabling vfio_pci.
This part could stay conditionned by no_pci.

I was thinking you need vfio without vfio_pci. Am I right?
If yes, I suggest to enable only vfio root module.