From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([209.51.188.92]:38147) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gjLGT-0005sT-6s for qemu-devel@nongnu.org; Tue, 15 Jan 2019 04:44:11 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1gjLGS-000285-Bi for qemu-devel@nongnu.org; Tue, 15 Jan 2019 04:44:09 -0500 From: Vladimir Sementsov-Ogievskiy Date: Tue, 15 Jan 2019 09:44:01 +0000 Message-ID: <3342cf43-21ba-60aa-4ca2-ed0e5b0ea4ae@virtuozzo.com> References: <20190112175812.27068-1-eblake@redhat.com> <20190112175812.27068-5-eblake@redhat.com> In-Reply-To: <20190112175812.27068-5-eblake@redhat.com> Content-Language: en-US Content-Type: text/plain; charset="utf-8" Content-ID: Content-Transfer-Encoding: base64 MIME-Version: 1.0 Subject: Re: [Qemu-devel] [PATCH v3 04/19] nbd/server: Hoist length check to qemp_nbd_server_add List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Eric Blake , "qemu-devel@nongnu.org" Cc: "nsoffer@redhat.com" , "rjones@redhat.com" , "jsnow@redhat.com" , "qemu-block@nongnu.org" , Kevin Wolf , Max Reitz MTIuMDEuMjAxOSAyMDo1NywgRXJpYyBCbGFrZSB3cm90ZToNCj4gV2Ugb25seSBoYWQgdHdvIGNh bGxlcnMgdG8gbmJkX2V4cG9ydF9uZXc7IHFlbXUtbmJkLmMgYWx3YXlzDQo+IHBhc3NlZCBhIHZh bGlkIG9mZnNldC9sZW5ndGggcGFpciAoYmVjYXVzZSBpdCBhbHJlYWR5IGNoZWNrZWQNCj4gdGhl IGZpbGUgbGVuZ3RoLCB0byBlbnN1cmUgdGhhdCBvZmZzZXQgd2FzIGluIGJvdW5kcyksIHdoaWxl DQo+IGJsb2NrZGV2LW5iZCBhbHdheXMgcGFzc2VkIDAvLTEuICBUaGVuIG5iZF9leHBvcnRfbmV3 IHJlZHVjZXMNCj4gdGhlIHNpemUgdG8gYSBtdWx0aXBsZSBvZiBCRFJWX1NFQ1RPUl9TSVpFIChj YW4gb25seSBoYXBwZW4NCj4gd2hlbiBvZmZzZXQgaXMgbm90IHNlY3Rvci1hbGlnbmVkLCBzaW5j ZSBiZHJ2X2dldGxlbmd0aCgpDQo+IGN1cnJlbnRseSByb3VuZHMgdXApLCB3aGljaCBjYW4gcmVz dWx0IGluIG9mZnNldCBiZWluZyBncmVhdGVyDQo+IHRoYW4gdGhlIGVuZm9yY2VkIGxlbmd0aCwg YnV0IHRoYXQncyBub3QgZmF0YWwgKHRoZSBzZXJ2ZXINCj4gcmVqZWN0cyBjbGllbnQgcmVxdWVz dHMgdGhhdCBleGNlZWQgdGhlIGFkdmVydGlzZWQgbGVuZ3RoKS4NCj4gDQo+IEhvd2V2ZXIsIEkn bSBmaW5kaW5nIGl0IGVhc2llciB0byB3b3JrIHdpdGggdGhlIGNvZGUgaWYgd2UgYXJlDQo+IGNv bnNpc3RlbnQgb24gaGF2aW5nIGJvdGggY2FsbGVycyBwYXNzIGluIGEgdmFsaWQgbGVuZ3RoLCBh bmQNCj4ganVzdCBhc3NlcnQgdGhhdCB0aGluZ3MgYXJlIHNhbmUgaW4gbmJkX2V4cG9ydF9uZXcu DQo+IA0KPiBTaWduZWQtb2ZmLWJ5OiBFcmljIEJsYWtlIDxlYmxha2VAcmVkaGF0LmNvbT4NCj4g DQo+IC0tLQ0KPiB2MzogbmV3IHBhdGNoDQo+IC0tLQ0KPiAgIGJsb2NrZGV2LW5iZC5jIHwgMTAg KysrKysrKysrLQ0KPiAgIG5iZC9zZXJ2ZXIuYyAgIHwgIDkgKystLS0tLS0tDQo+ICAgMiBmaWxl cyBjaGFuZ2VkLCAxMSBpbnNlcnRpb25zKCspLCA4IGRlbGV0aW9ucygtKQ0KPiANCj4gZGlmZiAt LWdpdCBhL2Jsb2NrZGV2LW5iZC5jIGIvYmxvY2tkZXYtbmJkLmMNCj4gaW5kZXggYzc2ZDU0MTZi OTAuLmQ3M2FjMWIwMjZhIDEwMDY0NA0KPiAtLS0gYS9ibG9ja2Rldi1uYmQuYw0KPiArKysgYi9i bG9ja2Rldi1uYmQuYw0KPiBAQCAtMTQ2LDYgKzE0Niw3IEBAIHZvaWQgcW1wX25iZF9zZXJ2ZXJf YWRkKGNvbnN0IGNoYXIgKmRldmljZSwgYm9vbCBoYXNfbmFtZSwgY29uc3QgY2hhciAqbmFtZSwN Cj4gICAgICAgQmxvY2tEcml2ZXJTdGF0ZSAqYnMgPSBOVUxMOw0KPiAgICAgICBCbG9ja0JhY2tl bmQgKm9uX2VqZWN0X2JsazsNCj4gICAgICAgTkJERXhwb3J0ICpleHA7DQo+ICsgICAgaW50NjRf dCBsZW47DQo+IA0KPiAgICAgICBpZiAoIW5iZF9zZXJ2ZXIpIHsNCj4gICAgICAgICAgIGVycm9y X3NldGcoZXJycCwgIk5CRCBzZXJ2ZXIgbm90IHJ1bm5pbmciKTsNCj4gQEAgLTE2OCw2ICsxNjks MTMgQEAgdm9pZCBxbXBfbmJkX3NlcnZlcl9hZGQoY29uc3QgY2hhciAqZGV2aWNlLCBib29sIGhh c19uYW1lLCBjb25zdCBjaGFyICpuYW1lLA0KPiAgICAgICAgICAgcmV0dXJuOw0KPiAgICAgICB9 DQo+IA0KPiArICAgIGxlbiA9IGJkcnZfZ2V0bGVuZ3RoKGJzKTsNCj4gKyAgICBpZiAobGVuIDwg MCkgew0KPiArICAgICAgICBlcnJvcl9zZXRnX2Vycm5vKGVycnAsIC1sZW4sDQo+ICsgICAgICAg ICAgICAgICAgICAgICAgICAgIkZhaWxlZCB0byBkZXRlcm1pbmUgdGhlIE5CRCBleHBvcnQncyBs ZW5ndGgiKTsNCj4gKyAgICAgICAgcmV0dXJuOw0KPiArICAgIH0NCj4gKw0KPiAgICAgICBpZiAo IWhhc193cml0YWJsZSkgew0KPiAgICAgICAgICAgd3JpdGFibGUgPSBmYWxzZTsNCj4gICAgICAg fQ0KPiBAQCAtMTc1LDcgKzE4Myw3IEBAIHZvaWQgcW1wX25iZF9zZXJ2ZXJfYWRkKGNvbnN0IGNo YXIgKmRldmljZSwgYm9vbCBoYXNfbmFtZSwgY29uc3QgY2hhciAqbmFtZSwNCj4gICAgICAgICAg IHdyaXRhYmxlID0gZmFsc2U7DQo+ICAgICAgIH0NCj4gDQo+IC0gICAgZXhwID0gbmJkX2V4cG9y dF9uZXcoYnMsIDAsIC0xLCBuYW1lLCBOVUxMLCBiaXRtYXAsDQo+ICsgICAgZXhwID0gbmJkX2V4 cG9ydF9uZXcoYnMsIDAsIGxlbiwgbmFtZSwgTlVMTCwgYml0bWFwLA0KPiAgICAgICAgICAgICAg ICAgICAgICAgICAgICB3cml0YWJsZSA/IDAgOiBOQkRfRkxBR19SRUFEX09OTFksDQo+ICAgICAg ICAgICAgICAgICAgICAgICAgICAgIE5VTEwsIGZhbHNlLCBvbl9lamVjdF9ibGssIGVycnApOw0K PiAgICAgICBpZiAoIWV4cCkgew0KPiBkaWZmIC0tZ2l0IGEvbmJkL3NlcnZlci5jIGIvbmJkL3Nl cnZlci5jDQo+IGluZGV4IGU4YzU2NjA3ZWZmLi5jOTkzN2NjZGMyYSAxMDA2NDQNCj4gLS0tIGEv bmJkL3NlcnZlci5jDQo+ICsrKyBiL25iZC9zZXJ2ZXIuYw0KPiBAQCAtMTQ5OSwxMyArMTQ5OSw4 IEBAIE5CREV4cG9ydCAqbmJkX2V4cG9ydF9uZXcoQmxvY2tEcml2ZXJTdGF0ZSAqYnMsIG9mZl90 IGRldl9vZmZzZXQsIG9mZl90IHNpemUsDQo+ICAgICAgIGV4cC0+bmFtZSA9IGdfc3RyZHVwKG5h bWUpOw0KPiAgICAgICBleHAtPmRlc2NyaXB0aW9uID0gZ19zdHJkdXAoZGVzY3JpcHRpb24pOw0K PiAgICAgICBleHAtPm5iZGZsYWdzID0gbmJkZmxhZ3M7DQo+IC0gICAgZXhwLT5zaXplID0gc2l6 ZSA8IDAgPyBibGtfZ2V0bGVuZ3RoKGJsaykgOiBzaXplOw0KPiAtICAgIGlmIChleHAtPnNpemUg PCAwKSB7DQo+IC0gICAgICAgIGVycm9yX3NldGdfZXJybm8oZXJycCwgLWV4cC0+c2l6ZSwNCj4g LSAgICAgICAgICAgICAgICAgICAgICAgICAiRmFpbGVkIHRvIGRldGVybWluZSB0aGUgTkJEIGV4 cG9ydCdzIGxlbmd0aCIpOw0KPiAtICAgICAgICBnb3RvIGZhaWw7DQo+IC0gICAgfQ0KPiAtICAg IGV4cC0+c2l6ZSAtPSBleHAtPnNpemUgJSBCRFJWX1NFQ1RPUl9TSVpFOw0KPiArICAgIGFzc2Vy dChkZXZfb2Zmc2V0IDw9IHNpemUpOw0KDQpAc2l6ZSBpcyBub3Qgc2l6ZSBvZiB0aGUgaW1hZ2Us IGJ1dCBzaXplIG9mIHRoZSBleHBvcnQsIHNvIGl0IG1heSBiZSBsZXNzIHRoYW4gZGV2X29mZnNl dA0KKHFlbXUtbmJkLmMgZG8gImZkX3NpemUgLT0gZGV2X29mZnNldCIgYmVmb3JlICJuYmRfZXhw b3J0X25ldyhicywgZGV2X29mZnNldCwgZmRfc2l6ZSwgIg0KDQo+ICsgICAgZXhwLT5zaXplID0g UUVNVV9BTElHTl9ET1dOKHNpemUsIEJEUlZfU0VDVE9SX1NJWkUpOw0KPiANCj4gICAgICAgaWYg KGJpdG1hcCkgew0KPiAgICAgICAgICAgQmRydkRpcnR5Qml0bWFwICpibSA9IE5VTEw7DQo+IA0K DQoNCi0tIA0KQmVzdCByZWdhcmRzLA0KVmxhZGltaXINCg==