From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 57A72C433F5 for ; Fri, 15 Oct 2021 14:45:59 +0000 (UTC) Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 7206C611C1 for ; Fri, 15 Oct 2021 14:45:58 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 7206C611C1 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=denx.de Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=lists.denx.de Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 77F0C82EA5; Fri, 15 Oct 2021 16:45:56 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=none (p=none dis=none) header.from=denx.de Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=denx.de; s=phobos-20191101; t=1634309156; bh=ujkUUGKgV+MKc5pbVegxCYhnRtQzFhvnWx8ZGMf3Bf0=; h=To:cc:From:Subject:In-reply-to:References:Date:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=oXtAs5Syg4MLinMs2j1RoaBbre+EET8tWOizMNepuzK5V1zRwwnVW/NoVJFHnb4QY /2hRdSTlbhpVz6uLWYLBNqVmAtSM5juhfyqlz+yKMbXYt2sCK8AUd7blJ7MGr/y9Y2 PAOQ01qavM6uoGOiJsmBuqkb9nodEUDC+6AwJFQbMJ7lRGbUJBuQkrODaLa7VRK2zj JKYi419sHiAfetRn1RYFGlRyoW68MP5BUxxENxkpYzbISxnEbBoBCXOXUXtM2bArO7 kQh5Ut7V19AREC7+xwnNZKPiaUzCyoZ/ZA+51oo17rARYcLTX83lHx/DWl7rJ0STiK s8unK4UOaQ6dg== Received: from janitor.denx.de (unknown [62.91.23.180]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) (No client certificate requested) (Authenticated sender: noc@denx.de) by phobos.denx.de (Postfix) with ESMTPSA id 7BACF82EA5 for ; Fri, 15 Oct 2021 16:45:54 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=denx.de; s=phobos-20191101; t=1634309154; bh=ujkUUGKgV+MKc5pbVegxCYhnRtQzFhvnWx8ZGMf3Bf0=; h=To:cc:From:Subject:In-reply-to:References:Date:From; b=tvggMfSn+NLbNwm9aBVWVLkmmDQGnSqZ9b8dQH29y/JOhCawpki4Br7aE/HDcAjxu SgS4HYgNblfBXqtKOf1qlzUDfbBva6doBKSBt2dxb2FBt6QcMsFMp4WS6uDB6h2cdd ZVT8+mOrqQZxlVb3J3DIQ6xfdsLXYC4/Cn+focuZ2k/psKTC3UNbZC+jR6SByLt3r5 73MaC7Lyi8YRFsT+zIT3nHUjyfWyLhvfw6M9f3IcfA6oJyqs+9AMDSEAimOaITfMxz CgXq92MTSNrohsBF/I6dUo13GaLEPtesMrDNdNSjLEoqh+1e7yau59vtNyzdYg+Qg0 /pN0kxGKDGiHg== Received: by janitor.denx.de (Postfix, from userid 108) id 00624A01F7; Fri, 15 Oct 2021 16:45:53 +0200 (CEST) Received: from gemini.denx.de (gemini.denx.de [10.4.0.2]) by janitor.denx.de (Postfix) with ESMTPS id ED5ECA014E; Fri, 15 Oct 2021 16:45:44 +0200 (CEST) Received: from gemini.denx.de (localhost [IPv6:::1]) by gemini.denx.de (Postfix) with ESMTP id 94B161E0F1B; Fri, 15 Oct 2021 16:45:44 +0200 (CEST) To: Simon Glass cc: U-Boot Mailing List , Heinrich Schuchardt , Tom Rini From: Wolfgang Denk Subject: Re: [PATCH v6 7/7] bootm: Tidy up use of autostart env var MIME-Version: 1.0 Content-type: text/plain; charset=UTF-8 Content-transfer-encoding: 8bit In-reply-to: <20211014182257.468649-6-sjg@chromium.org> References: <20211014182257.468649-1-sjg@chromium.org> <20211014182257.468649-6-sjg@chromium.org> Comments: In-reply-to Simon Glass message dated "Thu, 14 Oct 2021 12:22:57 -0600." Date: Fri, 15 Oct 2021 16:45:44 +0200 Message-ID: <3343692.1634309144@gemini.denx.de> X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.34 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.2 at phobos.denx.de X-Virus-Status: Clean Dear Simon Glass, In message <20211014182257.468649-6-sjg@chromium.org> you wrote: > This has different semantics in different places. Go with the bootm method > and put it in a common function so that the behaviour is consistent in > U-Boot. Update the docs. > > Signed-off-by: Simon Glass > Suggested-by: Wolfgang Denk It should be noted that this commit changes the behaviour of U-Boot for "autostart" users, thus it has the potential of breaking existent systems. The problematic cases are in do_bootelf() [cmd/elf.c] and do_bootm_standalone() [common/bootm_os.c]; the 3rd place where this is used - bootm_maybe_autostart() [cmd/bootm.c] - does not change. Or am I missing something? Best regards, Wolfgang Denk -- DENX Software Engineering GmbH, Managing Director: Wolfgang Denk HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd@denx.de I express preference for a chronological sequence of events which precludes a violence. - Terry Pratchett, _The Dark Side of the Sun_