From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.1 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 94707C43219 for ; Thu, 2 May 2019 12:38:57 +0000 (UTC) Received: from dpdk.org (dpdk.org [92.243.14.124]) by mail.kernel.org (Postfix) with ESMTP id 1B9172075E for ; Thu, 2 May 2019 12:38:57 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=monjalon.net header.i=@monjalon.net header.b="RI2KjFmQ"; dkim=pass (2048-bit key) header.d=messagingengine.com header.i=@messagingengine.com header.b="mSL58MM9" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 1B9172075E Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=monjalon.net Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=dev-bounces@dpdk.org Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 4FE7D5B26; Thu, 2 May 2019 14:38:56 +0200 (CEST) Received: from out2-smtp.messagingengine.com (out2-smtp.messagingengine.com [66.111.4.26]) by dpdk.org (Postfix) with ESMTP id AF543A49 for ; Thu, 2 May 2019 14:38:54 +0200 (CEST) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id 593E724ADA; Thu, 2 May 2019 08:38:54 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute1.internal (MEProxy); Thu, 02 May 2019 08:38:54 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=mesmtp; bh=CwPICug2CP/P1Y/gyNibrwFxi9X10V3CTFxSHA3azYU=; b=RI2KjFmQrGVw 1WPar55zI6OhpMMdSBdrCyCz7RZc3G/p5EjPbgoJLP5PzWJ4vEYNxnfuyXzbOIut aFpUmmhluUrnq0z3sy0AZfcWLwsonhDAMN0T6N5exL2lzCoNfaNg6MrNENUPdf4Q S0J/PBHwkOYa3/YFdb6wVoPCFJboa2E= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm2; bh=CwPICug2CP/P1Y/gyNibrwFxi9X10V3CTFxSHA3az YU=; b=mSL58MM9kuNwkWmCyIP07bPRmq89VidjpR2oY9ytAo1nDz26GTarnhTuC on9b1mb+YhuJyJDW2He9dz8wWDWP4LwJ1V5cwjDEIEK7r/mOqr40nYgAI7U6d8Q1 o42hL/NADtsEqlYX1LAkwBduC82uYT68jNz4L9P0NyQgjwdhrcbCLjws6qoEcTAc n3YkeEr/6cACv+UKbLi0l9VomGJw7IA38kgQFrHwIa/cuB6EXSr5ytnjryztMl4D 232o8y2c72UkIkZuQG1Pixs2/NEZk2WgbkfrGmtYqrlhlqNQReq9D21BIIdOIkN7 0eTfxkORTgq2R3cMyx++s3N2nvJJA== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduuddrieelgdehiecutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenuc fjughrpefhvffufffkjghfggfgtgesthfuredttddtvdenucfhrhhomhepvfhhohhmrghs ucfoohhnjhgrlhhonhcuoehthhhomhgrshesmhhonhhjrghlohhnrdhnvghtqeenucfkph epjeejrddufeegrddvtdefrddukeegnecurfgrrhgrmhepmhgrihhlfhhrohhmpehthhho mhgrshesmhhonhhjrghlohhnrdhnvghtnecuvehluhhsthgvrhfuihiivgeptd X-ME-Proxy: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id E8442E412B; Thu, 2 May 2019 08:38:52 -0400 (EDT) From: Thomas Monjalon To: Bruce Richardson Cc: dev@dpdk.org, bluca@debian.org Date: Thu, 02 May 2019 14:38:49 +0200 Message-ID: <3343772.7GDin1kDO3@xps> In-Reply-To: <20190426165043.17268-5-bruce.richardson@intel.com> References: <20190423220644.54589-1-bruce.richardson@intel.com> <20190426165043.17268-1-bruce.richardson@intel.com> <20190426165043.17268-5-bruce.richardson@intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH v2 4/6] devtools/test-meson-builds: add testing of pkg-config file X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Hi, I will probably have a ton of comments about adding a new compilation tests, and I think it is a bit late for such an addition. However, all the fixes should go in 19.05. 26/04/2019 18:50, Bruce Richardson: > The pkg-config file generated as part of the build of DPDK should allow > applications to be built with an installed DPDK. We can test this as > part of the build by doing an install of DPDK to a temporary directory > within the build folder, and by then compiling up a few sample apps > using make working off that directory. > > Signed-off-by: Bruce Richardson > Acked-by: Luca Boccassi > --- > --- a/devtools/test-meson-builds.sh > +++ b/devtools/test-meson-builds.sh > +############## > +# Test installation of the x86-default target, to be used for checking > +# the sample apps build using the pkg-config file for cflags and libs > +############### I would prefer simpler comment formatting. It makes this test very special. > +build_path=build-x86-default > +DESTDIR=`pwd`/$build_path/install-root ; export DESTDIR export DESTDIR=... is not supported everywhere? I prefer new shell substitution syntax $() instead of backquotes. > +$ninja_cmd -C $build_path install > + > +pc_file=$(find $DESTDIR -name libdpdk.pc) > +PKG_CONFIG_PATH=$(dirname $pc_file) ; export PKG_CONFIG_PATH > + > +# rather than hacking our environment, just edit the .pc file prefix value > +sed -i -e "s|prefix=|prefix=$DESTDIR|" $pc_file What is the alternative? Cannot we configure meson with the right prefix? > +for example in helloworld l2fwd l3fwd skeleton timer; do > + echo "## Building $example" > + $MAKE -C $DESTDIR/usr/local/share/dpdk/examples/$example > +done > + > +echo "" > +echo "## $0: Completed OK" This last log is uncommon.