From: Damien Le Moal <damien.lemoal@opensource.wdc.com>
To: Mike Snitzer <snitzer@kernel.org>,
Shinichiro Kawasaki <shinichiro.kawasaki@wdc.com>
Cc: "dm-devel@redhat.com" <dm-devel@redhat.com>,
Damien Le Moal <Damien.LeMoal@wdc.com>
Subject: Re: [dm-devel] [bug report] BUG for REQ_OP_WRITE_ZEROES to dm-zoned
Date: Fri, 15 Apr 2022 08:57:42 +0900 [thread overview]
Message-ID: <335390c8-8ea5-1e77-f5c3-a5d19b274eba@opensource.wdc.com> (raw)
In-Reply-To: <YlhQKj0iLM8mT+WK@redhat.com>
On 4/15/22 01:47, Mike Snitzer wrote:
> On Thu, Apr 14 2022 at 12:29P -0400,
> Mike Snitzer <snitzer@kernel.org> wrote:
>
>> Thanks for the report, I've staged a fix here (btw, your change above
>> needs to be paired with the 2nd hunk of my fix otherwise you won't get
>> the bio split you desire):
>>
>> https://git.kernel.org/pub/scm/linux/kernel/git/device-mapper/linux-dm.git/commit/?h=dm-5.18&id=3dfb6f5e95f26215ca08d348ca2ddb5ea6ea2349
>>
>> I'll be sending this to Linus later today or tomorrow.
>
> FYI, I revised that commit with further cleanup to not pass
> 'unsigned *len' to alloc_multiple_bios(), this commit is what will be
> sent upstream soon:
>
> https://git.kernel.org/pub/scm/linux/kernel/git/device-mapper/linux-dm.git/commit/?h=dm-5.18&id=c2228f993c7592783b0a2bf7d169b17dfa4cbe2a
Looks good to me.
Nit: there is a typo in the commit message:
dm_accept_paertial_bio() -> dm_accept_partial_bio()
Feel free to add:
Reviewed-by: Damien Le Moal <damien.lemoal@opensource.wdc.com>
>
> --
> dm-devel mailing list
> dm-devel@redhat.com
> https://listman.redhat.com/mailman/listinfo/dm-devel
>
--
Damien Le Moal
Western Digital Research
--
dm-devel mailing list
dm-devel@redhat.com
https://listman.redhat.com/mailman/listinfo/dm-devel
next prev parent reply other threads:[~2022-04-14 23:57 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-04-14 8:34 [dm-devel] [bug report] BUG for REQ_OP_WRITE_ZEROES to dm-zoned Shinichiro Kawasaki
2022-04-14 16:29 ` Mike Snitzer
2022-04-14 16:47 ` Mike Snitzer
2022-04-14 23:57 ` Damien Le Moal [this message]
2022-04-15 3:43 ` Shinichiro Kawasaki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=335390c8-8ea5-1e77-f5c3-a5d19b274eba@opensource.wdc.com \
--to=damien.lemoal@opensource.wdc.com \
--cc=Damien.LeMoal@wdc.com \
--cc=dm-devel@redhat.com \
--cc=shinichiro.kawasaki@wdc.com \
--cc=snitzer@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.