From mboxrd@z Thu Jan 1 00:00:00 1970 From: Thomas Monjalon Subject: Re: [PATCH] ethdev: support PCI domains Date: Tue, 04 Oct 2016 10:15:56 +0200 Message-ID: <3354300.QnNDgIpU56@xps13> References: <1469201650-32447-1-git-send-email-okaya@codeaurora.org> <20160722141259.35ea0a7e@xeon-e3> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7Bit Cc: dev@dpdk.org, Stephen Hemminger To: Sinan Kaya Return-path: Received: from mail-wm0-f50.google.com (mail-wm0-f50.google.com [74.125.82.50]) by dpdk.org (Postfix) with ESMTP id F38556A73 for ; Tue, 4 Oct 2016 10:16:00 +0200 (CEST) Received: by mail-wm0-f50.google.com with SMTP id f193so22735208wmg.0 for ; Tue, 04 Oct 2016 01:16:00 -0700 (PDT) In-Reply-To: List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 2016-07-22 18:56, Sinan Kaya: > On 7/22/2016 5:12 PM, Stephen Hemminger wrote: > > On Fri, 22 Jul 2016 11:34:10 -0400 > > Sinan Kaya wrote: > > > >> The current code is enumerating devices based on bus, device and function > >> pairs. This does not work well for architectures with multiple PCI > >> segments/domains. Multiple PCI devices will have the same BDF value but > >> different segment numbers (01:01:01.0 and 02:01:01.0) for instance. > >> > >> Adding segment numbers to device naming so that we can uniquely identify > >> devices. > >> > >> Signed-off-by: Sinan Kaya > > > > I ran into this yes. There is a small risk of breaking some application that > > assumed something about names though. > > > > Acked-by: Stephen Hemminger > > > > Thanks, hopefully the change is minor and can be contained until next release. It is part of the EAL rework. The function has been moved in EAL and includes the PCI domain: http://dpdk.org/commit/affe1cdc