From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 84164C433EF for ; Wed, 2 Mar 2022 10:11:23 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S240900AbiCBKME (ORCPT ); Wed, 2 Mar 2022 05:12:04 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:58806 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235285AbiCBKMD (ORCPT ); Wed, 2 Mar 2022 05:12:03 -0500 Received: from frasgout.his.huawei.com (frasgout.his.huawei.com [185.176.79.56]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 4D16A26AEA for ; Wed, 2 Mar 2022 02:11:20 -0800 (PST) Received: from fraeml744-chm.china.huawei.com (unknown [172.18.147.200]) by frasgout.his.huawei.com (SkyGuard) with ESMTP id 4K7qdV278kz67N1R; Wed, 2 Mar 2022 18:11:10 +0800 (CST) Received: from lhreml724-chm.china.huawei.com (10.201.108.75) by fraeml744-chm.china.huawei.com (10.206.15.225) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.21; Wed, 2 Mar 2022 11:11:17 +0100 Received: from [10.47.84.129] (10.47.84.129) by lhreml724-chm.china.huawei.com (10.201.108.75) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.21; Wed, 2 Mar 2022 10:11:17 +0000 Message-ID: <335c3bfe-961d-d3e5-3825-78a1d528e152@huawei.com> Date: Wed, 2 Mar 2022 10:11:16 +0000 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.5.1 Subject: Re: [PATCH 1/6] blk-mq: figure out correct numa node for hw queue To: Ming Lei CC: Jens Axboe , , Yu Kuai References: <20220228090430.1064267-1-ming.lei@redhat.com> <20220228090430.1064267-2-ming.lei@redhat.com> <45adf246-176a-b4a5-d973-4c885c37d821@huawei.com> <7d112d9f-6ab1-4f8e-6005-b940074f1071@huawei.com> From: John Garry In-Reply-To: Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 7bit X-Originating-IP: [10.47.84.129] X-ClientProxiedBy: lhreml739-chm.china.huawei.com (10.201.108.189) To lhreml724-chm.china.huawei.com (10.201.108.75) X-CFilter-Loop: Reflected Precedence: bulk List-ID: X-Mailing-List: linux-block@vger.kernel.org On 02/03/2022 09:22, Ming Lei wrote: >>> What is reverse firtree ordering here? I don't know what is wrong >>> with the above one line change from patch style viewpoint, and >>> checkpatch complains nothing here. >> checkpath would not complain about this. I'm talking about: >> https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/maintainer-tip.rst#n587 >> >> The original code had: >> >> struct blk_mq_tags *tags; >> int node; >> >> as opposed to: >> >> int node; >> struct blk_mq_tags *tags; >> >> That's all. The block code seems to mostly follow this style when possible. >> It's just a style issue. > But my patch doesn't change the order,:-) Right, and I am just saying that if you were to maintain this coding style then it should. But, as I alluded before, for only 2 declarations is not so important. Thanks, John