From mboxrd@z Thu Jan 1 00:00:00 1970 From: Stefan Bruens Date: Thu, 17 Dec 2015 04:16:28 +0100 Subject: [U-Boot] [PATCH 3/6] usb: dwc2: determine TT hub address and port for split transactions In-Reply-To: <5670D7CC.1060308@wwwdotorg.org> References: <1449980278-19881-1-git-send-email-stefan.bruens@rwth-aachen.de> <1449980278-19881-4-git-send-email-stefan.bruens@rwth-aachen.de> <5670D7CC.1060308@wwwdotorg.org> Message-ID: <3364487.y0b5h7sQeW@pebbles.site> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de On Tuesday 15 December 2015 20:17:32 Stephen Warren wrote: > On 12/12/2015 09:17 PM, Stefan Br?ns wrote: > > Start split and complete split tokens need the hub address and the > > downstream port of the first HS hub (device view). > > Code copied from host/ehci_hcd.c > > Rather than cut/paste this, shouldn't you create a common function that > can be shared between all users? Good idea, as the code is also duplicated in musb-new. Any suggestions where to put the new function? For CONFIG_DM_USB there is usb_uclass.c. Move it into usb_uclass.c and leave the non DM variants in place (same name, but declared static)? Kind regards, Stefan -- Stefan Br?ns / Bergstra?e 21 / 52062 Aachen home: +49 241 53809034 mobile: +49 151 50412019 work: +49 2405 49936-424