From mboxrd@z Thu Jan  1 00:00:00 1970
From: Thomas Monjalon <thomas@monjalon.net>
Subject: Re: [PATCH v10 08/27] devargs: add function to parse
	device layers
Date: Wed, 11 Jul 2018 11:30:32 +0200
Message-ID: <3367029.O4eSh4CbOy@xps>
References: <cover.1530791217.git.gaetan.rivet@6wind.com>
 <2914659.2M3dPKUJVY@xps>
 <20180711084116.dbbou4vbbp2y5tcn@bidouze.vm.6wind.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="iso-8859-1"
Content-Transfer-Encoding: quoted-printable
Cc: dev@dpdk.org
To: =?ISO-8859-1?Q?Ga=EBtan?= Rivet <gaetan.rivet@6wind.com>
Return-path: <dev-bounces@dpdk.org>
Received: from wout2-smtp.messagingengine.com (wout2-smtp.messagingengine.com
 [64.147.123.25]) by dpdk.org (Postfix) with ESMTP id 5FD421B1C3
 for <dev@dpdk.org>; Wed, 11 Jul 2018 11:30:37 +0200 (CEST)
In-Reply-To: <20180711084116.dbbou4vbbp2y5tcn@bidouze.vm.6wind.com>
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

11/07/2018 10:41, Ga=EBtan Rivet:
> > > +	struct rte_bus *bus; /**< bus handle. */
> > > +	struct rte_class *cls; /**< class handle. */
> >=20
> > "class" is more readable than "cls"
> >=20
>=20
> I was thinking that maybe this could be a problem when trying to build
> with C++. The EAL headers in DPDK are meant to be included in C++ apps,
> I think ``class`` would be an issue then.

Yes, right.

So only options are "cls" or "devclass".
Up to you.

> If I'm mistaken, then sure, class is a better name.