From mboxrd@z Thu Jan  1 00:00:00 1970
From: Thomas Monjalon <thomas@monjalon.net>
Subject: Re: [dpdk-stable]  [PATCH v2 2/2] eal: fix build issue
Date: Mon, 12 Nov 2018 13:28:44 +0100
Message-ID: <3369863.oabFoVrSzJ@xps>
References: <20181106114435.14770-1-jerin.jacob@caviumnetworks.com>
 <20181107065833.16756-1-jerin.jacob@caviumnetworks.com>
 <20181107065833.16756-2-jerin.jacob@caviumnetworks.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Cc: stable@dpdk.org, "dev@dpdk.org" <dev@dpdk.org>,
 Qi Zhang <qi.z.zhang@intel.com>, Xiao Wang <xiao.w.wang@intel.com>,
 "sthemmin@microsoft.com" <sthemmin@microsoft.com>,
 "shaopeng.he@intel.com" <shaopeng.he@intel.com>, "Jacob,
 Jerin" <Jerin.JacobKollanukkaran@cavium.com>
To: Jerin Jacob <jerin.jacob@caviumnetworks.com>
Return-path: <dev-bounces@dpdk.org>
In-Reply-To: <20181107065833.16756-2-jerin.jacob@caviumnetworks.com>
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

07/11/2018 07:59, Jerin Jacob:
> Some toolchain has fls() definition in string.h as argument type int,
> which is conflicting uint32_t argument type.
>=20
> /export/dpdk.org/lib/librte_eal/common/rte_reciprocal.c:47:19:
> error: conflicting types for =E2=80=98fls=E2=80=99
>  static inline int fls(uint32_t x)
>                   ^~~
>=20
> /opt/marvell-tools-201/aarch64-marvell-elf/include/strings.h:59:6:
> note: previous declaration of =E2=80=98fls=E2=80=99 was here
>  int  fls(int) __pure2;
>=20
> FreeBSD string.h also has fls() with argument as int type.
> https://www.freebsd.org/cgi/man.cgi?query=3Dfls&sektion=3D3
>=20
> Fixing the conflict by using rte version of fls.
>=20
> Fixes: ffe3ec811ef5 ("sched: introduce reciprocal divide")
> Fixes: faf2b25c9f80 ("fm10k: support VMDQ in multi-queue configuration")
> Cc: stable@dpdk.org
>=20
> Suggested-by: Thomas Monjalon <thomas@monjalon.net>
> Signed-off-by: Jerin Jacob <jerin.jacob@caviumnetworks.com>

Series applied, thanks