From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-17.2 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0C1E2C433B4 for ; Fri, 23 Apr 2021 12:12:18 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id C07786145A for ; Fri, 23 Apr 2021 12:12:15 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S242330AbhDWMMu (ORCPT ); Fri, 23 Apr 2021 08:12:50 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:40016 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230225AbhDWMMt (ORCPT ); Fri, 23 Apr 2021 08:12:49 -0400 Received: from perceval.ideasonboard.com (perceval.ideasonboard.com [IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 76FE4C061574 for ; Fri, 23 Apr 2021 05:12:13 -0700 (PDT) Received: from [192.168.1.111] (91-157-208-71.elisa-laajakaista.fi [91.157.208.71]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id A3BD5332; Fri, 23 Apr 2021 14:12:09 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1619179930; bh=ztHZDpJmzKliKSCR4Gs3CUFc3lpmrS2nHqGxB96U5X4=; h=Subject:To:Cc:References:From:Date:In-Reply-To:From; b=HCh/1cFwFsA9JJkCBA0NUM+FS7SYTb7uYKJy1QkG8MQK+tuOaj/mq95QTaWjnylJl 8U5uXdLKlzhHz4o6SoiU83XwoDQEfxmMvCnMFmHSevCqkRH98ISgwvU1HuEeW5lVgj fHJmjy9rFavo5WtPFk76nMb8ZYxaHFmkkhBK4hTU= Subject: Re: [PATCH 18/40] drm/omapdrm/omap_irq: Fix a couple of incorrectly documented functions To: Lee Jones Cc: linux-kernel@vger.kernel.org, David Airlie , Daniel Vetter , Rob Clark , dri-devel@lists.freedesktop.org References: <20210416143725.2769053-1-lee.jones@linaro.org> <20210416143725.2769053-19-lee.jones@linaro.org> From: Tomi Valkeinen Message-ID: <3371e3d9-752c-b301-a28e-f043c869ecdf@ideasonboard.com> Date: Fri, 23 Apr 2021 15:12:08 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.7.1 MIME-Version: 1.0 In-Reply-To: <20210416143725.2769053-19-lee.jones@linaro.org> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 16/04/2021 17:37, Lee Jones wrote: > Fixes the following W=1 kernel build warning(s): > > drivers/gpu/drm/omapdrm/omap_irq.c:114: warning: expecting prototype for enable_vblank(). Prototype was for omap_irq_enable_vblank() instead > drivers/gpu/drm/omapdrm/omap_irq.c:140: warning: expecting prototype for disable_vblank(). Prototype was for omap_irq_disable_vblank() instead > > Cc: Tomi Valkeinen > Cc: David Airlie > Cc: Daniel Vetter > Cc: Rob Clark > Cc: dri-devel@lists.freedesktop.org > Signed-off-by: Lee Jones > --- > drivers/gpu/drm/omapdrm/omap_irq.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/gpu/drm/omapdrm/omap_irq.c b/drivers/gpu/drm/omapdrm/omap_irq.c > index 15148d4b35b57..dff095c864909 100644 > --- a/drivers/gpu/drm/omapdrm/omap_irq.c > +++ b/drivers/gpu/drm/omapdrm/omap_irq.c > @@ -99,7 +99,7 @@ int omap_irq_enable_framedone(struct drm_crtc *crtc, bool enable) > } > > /** > - * enable_vblank - enable vblank interrupt events > + * omap_irq_enable_vblank - enable vblank interrupt events > * @crtc: DRM CRTC > * > * Enable vblank interrupts for @crtc. If the device doesn't have > @@ -129,7 +129,7 @@ int omap_irq_enable_vblank(struct drm_crtc *crtc) > } > > /** > - * disable_vblank - disable vblank interrupt events > + * omap_irq_disable_vblank - disable vblank interrupt events > * @crtc: DRM CRTC > * > * Disable vblank interrupts for @crtc. If the device doesn't have > Reviewed-by: Tomi Valkeinen Tomi From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.1 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 089D7C433ED for ; Fri, 23 Apr 2021 12:12:15 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 568806145A for ; Fri, 23 Apr 2021 12:12:14 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 568806145A Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=ideasonboard.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 726196EB85; Fri, 23 Apr 2021 12:12:13 +0000 (UTC) Received: from perceval.ideasonboard.com (perceval.ideasonboard.com [213.167.242.64]) by gabe.freedesktop.org (Postfix) with ESMTPS id 052F96EB87 for ; Fri, 23 Apr 2021 12:12:11 +0000 (UTC) Received: from [192.168.1.111] (91-157-208-71.elisa-laajakaista.fi [91.157.208.71]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id A3BD5332; Fri, 23 Apr 2021 14:12:09 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1619179930; bh=ztHZDpJmzKliKSCR4Gs3CUFc3lpmrS2nHqGxB96U5X4=; h=Subject:To:Cc:References:From:Date:In-Reply-To:From; b=HCh/1cFwFsA9JJkCBA0NUM+FS7SYTb7uYKJy1QkG8MQK+tuOaj/mq95QTaWjnylJl 8U5uXdLKlzhHz4o6SoiU83XwoDQEfxmMvCnMFmHSevCqkRH98ISgwvU1HuEeW5lVgj fHJmjy9rFavo5WtPFk76nMb8ZYxaHFmkkhBK4hTU= Subject: Re: [PATCH 18/40] drm/omapdrm/omap_irq: Fix a couple of incorrectly documented functions To: Lee Jones References: <20210416143725.2769053-1-lee.jones@linaro.org> <20210416143725.2769053-19-lee.jones@linaro.org> From: Tomi Valkeinen Message-ID: <3371e3d9-752c-b301-a28e-f043c869ecdf@ideasonboard.com> Date: Fri, 23 Apr 2021 15:12:08 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.7.1 MIME-Version: 1.0 In-Reply-To: <20210416143725.2769053-19-lee.jones@linaro.org> Content-Language: en-US X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: David Airlie , dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, Rob Clark Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" On 16/04/2021 17:37, Lee Jones wrote: > Fixes the following W=1 kernel build warning(s): > > drivers/gpu/drm/omapdrm/omap_irq.c:114: warning: expecting prototype for enable_vblank(). Prototype was for omap_irq_enable_vblank() instead > drivers/gpu/drm/omapdrm/omap_irq.c:140: warning: expecting prototype for disable_vblank(). Prototype was for omap_irq_disable_vblank() instead > > Cc: Tomi Valkeinen > Cc: David Airlie > Cc: Daniel Vetter > Cc: Rob Clark > Cc: dri-devel@lists.freedesktop.org > Signed-off-by: Lee Jones > --- > drivers/gpu/drm/omapdrm/omap_irq.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/gpu/drm/omapdrm/omap_irq.c b/drivers/gpu/drm/omapdrm/omap_irq.c > index 15148d4b35b57..dff095c864909 100644 > --- a/drivers/gpu/drm/omapdrm/omap_irq.c > +++ b/drivers/gpu/drm/omapdrm/omap_irq.c > @@ -99,7 +99,7 @@ int omap_irq_enable_framedone(struct drm_crtc *crtc, bool enable) > } > > /** > - * enable_vblank - enable vblank interrupt events > + * omap_irq_enable_vblank - enable vblank interrupt events > * @crtc: DRM CRTC > * > * Enable vblank interrupts for @crtc. If the device doesn't have > @@ -129,7 +129,7 @@ int omap_irq_enable_vblank(struct drm_crtc *crtc) > } > > /** > - * disable_vblank - disable vblank interrupt events > + * omap_irq_disable_vblank - disable vblank interrupt events > * @crtc: DRM CRTC > * > * Disable vblank interrupts for @crtc. If the device doesn't have > Reviewed-by: Tomi Valkeinen Tomi _______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel