From mboxrd@z Thu Jan 1 00:00:00 1970 From: Stephan Mueller Subject: Re: [PATCH v12 1/2] crypto: AF_ALG: add AEAD support Date: Fri, 27 Feb 2015 19:54:23 +0100 Message-ID: <3379989.bRI419NncO@tachyon.chronox.de> References: <1681008.mocmysOoQU@tachyon.chronox.de> <2021530.t7zNty0mPn@tauon> <54F0B8BD.30600@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7Bit Cc: Herbert Xu , 'Quentin Gouchet' , Daniel Borkmann , 'LKML' , linux-crypto-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, 'Linux API' To: Tadeusz Struk Return-path: In-Reply-To: <54F0B8BD.30600-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org> Sender: linux-api-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org List-Id: linux-crypto.vger.kernel.org Am Freitag, 27. Februar 2015, 10:34:37 schrieb Tadeusz Struk: Hi Tadeusz, > On 02/27/2015 02:26 AM, Stephan Mueller wrote: > >>>> This patch adds the AEAD support for AF_ALG. > >>>> > >>>> >> > The implementation is based on algif_skcipher, but contains heavy > >>>> >> > modifications to streamline the interface for AEAD uses. > >>>> >> > > >>>> >> > To use AEAD, the user space consumer has to use the salg_type > >>>> >> > named > >>>> >> > "aead". > >>> >> > >>> >> I just saw Al Viro's patch to use the iov_iter API in > >>> >> algif_skcipher.c. I looked at it but lacked documentation for using > >>> >> it properly. Now I have a template that I will incorporate into > >>> >> algif_aead.c > >> > > >> >Please resubmit once you have done this. > > > > I have done that, but as indicated with an email to Al, I cannot get his > > patch for skcipher and hash to work. Similarly, my modification for the > > AEAD does not work either. So, I do not see that Al's patch can be > > merged as is. > > > > Therefore, I have not submitted my patch as Al mentioned he wanted to > > look into his patchset. > > Hi Stephan, > There was a problem with the iov_iter changes, but it has been fixed on > netdev during merging window. The algif_skcipher works fine for me on the > latest (4.0.0-rc1+) cryptodev. Great, thanks for the hint. I will check my implementation and release it shortly. > > Regards, > Tadeusz -- Ciao Stephan From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754830AbbB0S4v (ORCPT ); Fri, 27 Feb 2015 13:56:51 -0500 Received: from mail.eperm.de ([89.247.134.16]:45532 "EHLO mail.eperm.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751776AbbB0S4u (ORCPT ); Fri, 27 Feb 2015 13:56:50 -0500 From: Stephan Mueller To: Tadeusz Struk Cc: Herbert Xu , "'Quentin Gouchet'" , Daniel Borkmann , "'LKML'" , linux-crypto@vger.kernel.org, "'Linux API'" Subject: Re: [PATCH v12 1/2] crypto: AF_ALG: add AEAD support Date: Fri, 27 Feb 2015 19:54:23 +0100 Message-ID: <3379989.bRI419NncO@tachyon.chronox.de> User-Agent: KMail/4.14.4 (Linux/3.18.7-200.fc21.x86_64; KDE/4.14.4; x86_64; ; ) In-Reply-To: <54F0B8BD.30600@intel.com> References: <1681008.mocmysOoQU@tachyon.chronox.de> <2021530.t7zNty0mPn@tauon> <54F0B8BD.30600@intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Am Freitag, 27. Februar 2015, 10:34:37 schrieb Tadeusz Struk: Hi Tadeusz, > On 02/27/2015 02:26 AM, Stephan Mueller wrote: > >>>> This patch adds the AEAD support for AF_ALG. > >>>> > >>>> >> > The implementation is based on algif_skcipher, but contains heavy > >>>> >> > modifications to streamline the interface for AEAD uses. > >>>> >> > > >>>> >> > To use AEAD, the user space consumer has to use the salg_type > >>>> >> > named > >>>> >> > "aead". > >>> >> > >>> >> I just saw Al Viro's patch to use the iov_iter API in > >>> >> algif_skcipher.c. I looked at it but lacked documentation for using > >>> >> it properly. Now I have a template that I will incorporate into > >>> >> algif_aead.c > >> > > >> >Please resubmit once you have done this. > > > > I have done that, but as indicated with an email to Al, I cannot get his > > patch for skcipher and hash to work. Similarly, my modification for the > > AEAD does not work either. So, I do not see that Al's patch can be > > merged as is. > > > > Therefore, I have not submitted my patch as Al mentioned he wanted to > > look into his patchset. > > Hi Stephan, > There was a problem with the iov_iter changes, but it has been fixed on > netdev during merging window. The algif_skcipher works fine for me on the > latest (4.0.0-rc1+) cryptodev. Great, thanks for the hint. I will check my implementation and release it shortly. > > Regards, > Tadeusz -- Ciao Stephan