From mboxrd@z Thu Jan 1 00:00:00 1970 From: Tvrtko Ursulin Subject: Re: [PATCH] drm/i915: Cleanup error paths through eb_lookup_vma() Date: Tue, 12 Sep 2017 16:21:06 +0100 Message-ID: <337c3384-c152-0e99-3cf2-5637b6f945ba@linux.intel.com> References: <20170912150752.20411-1-chris@chris-wilson.co.uk> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8"; Format="flowed" Content-Transfer-Encoding: base64 Return-path: Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by gabe.freedesktop.org (Postfix) with ESMTPS id 20D706E03F for ; Tue, 12 Sep 2017 15:21:08 +0000 (UTC) In-Reply-To: <20170912150752.20411-1-chris@chris-wilson.co.uk> Content-Language: en-GB List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Chris Wilson , intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org Ck9uIDEyLzA5LzIwMTcgMTY6MDcsIENocmlzIFdpbHNvbiB3cm90ZToKPiBGb2xsb3dpbmcgdGhl IHNpbXBsaWZpY2F0aW9uIHRvIGEgc2luZ2xlIGxvb2t1cCBsb29wIGluIGNvbW1pdAo+IDE3MGZh MjliMTRmYSAoImRybS9pOTE1OiBTaW1wbGlmeSBlYl9sb29rdXBfdm1hcygpIikgYW5kIGNvbW1p dAo+IGQxYjQ4YzFlNzE4NCAoImRybS9pOTE1OiBSZXBsYWNlIGV4ZWNidWYgdm1hIGh0IHdpdGgg YW4gaWRyIiksIHdlIGNhbiBnbwo+IG9uZSBzZXR1cCBmdXJ0aGVyIGFuZCByZW9yZGVyIHRoZSBl cnJvciBwYXRocyBzbyB0aGF0IHRoZSBzdGF0ZSBvZiB0aGUKPiBsb2NhbCB2YXJpYWJsZSBvYmog aXMgYWx3YXlzIGtub3duIHRvIHRoZSBjb21waWxlciBhbmQgZG9lc24ndCBuZWVkIHRoZQo+IHVu aW5pdGlhbGl6ZWRfdmFyIG1hcmt1cCB0byBzcXVlbGNoIGEgY29tcGlsZXIgd2FybmluZy4KPiAK PiBTaWduZWQtb2ZmLWJ5OiBDaHJpcyBXaWxzb24gPGNocmlzQGNocmlzLXdpbHNvbi5jby51az4K PiBDYzogVHZydGtvIFVyc3VsaW4gPHR2cnRrby51cnN1bGluQGludGVsLmNvbT4KPiAtLS0KPiAg IGRyaXZlcnMvZ3B1L2RybS9pOTE1L2k5MTVfZ2VtX2V4ZWNidWZmZXIuYyB8IDExICsrKystLS0t LS0tCj4gICAxIGZpbGUgY2hhbmdlZCwgNCBpbnNlcnRpb25zKCspLCA3IGRlbGV0aW9ucygtKQo+ IAo+IGRpZmYgLS1naXQgYS9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pOTE1X2dlbV9leGVjYnVmZmVy LmMgYi9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pOTE1X2dlbV9leGVjYnVmZmVyLmMKPiBpbmRleCA3 Njg3NDgzZmYyMTguLjIxNGE4NTBiNGIzYyAxMDA2NDQKPiAtLS0gYS9kcml2ZXJzL2dwdS9kcm0v aTkxNS9pOTE1X2dlbV9leGVjYnVmZmVyLmMKPiArKysgYi9kcml2ZXJzL2dwdS9kcm0vaTkxNS9p OTE1X2dlbV9leGVjYnVmZmVyLmMKPiBAQCAtNjc5LDcgKzY3OSw3IEBAIHN0YXRpYyBpbnQgZWJf c2VsZWN0X2NvbnRleHQoc3RydWN0IGk5MTVfZXhlY2J1ZmZlciAqZWIpCj4gICBzdGF0aWMgaW50 IGViX2xvb2t1cF92bWFzKHN0cnVjdCBpOTE1X2V4ZWNidWZmZXIgKmViKQo+ICAgewo+ICAgCXN0 cnVjdCByYWRpeF90cmVlX3Jvb3QgKmhhbmRsZXNfdm1hID0gJmViLT5jdHgtPmhhbmRsZXNfdm1h Owo+IC0Jc3RydWN0IGRybV9pOTE1X2dlbV9vYmplY3QgKnVuaW5pdGlhbGl6ZWRfdmFyKG9iaik7 Cj4gKwlzdHJ1Y3QgZHJtX2k5MTVfZ2VtX29iamVjdCAqb2JqOwo+ICAgCXVuc2lnbmVkIGludCBp Owo+ICAgCWludCBlcnI7Cj4gICAKPiBAQCAtNzI1LDE5ICs3MjUsMTcgQEAgc3RhdGljIGludCBl Yl9sb29rdXBfdm1hcyhzdHJ1Y3QgaTkxNV9leGVjYnVmZmVyICplYikKPiAgIAkJCWdvdG8gZXJy X29iajsKPiAgIAkJfQo+ICAgCj4gKwkJLyogdHJhbnNmZXIgcmVmIHRvIGN0eCAqLwo+ICAgCQl2 bWEtPm9wZW5fY291bnQrKzsKPiAgIAkJbGlzdF9hZGQoJmx1dC0+b2JqX2xpbmssICZvYmotPmx1 dF9saXN0KTsKPiAgIAkJbGlzdF9hZGQoJmx1dC0+Y3R4X2xpbmssICZlYi0+Y3R4LT5oYW5kbGVz X2xpc3QpOwo+ICAgCQlsdXQtPmN0eCA9IGViLT5jdHg7Cj4gICAJCWx1dC0+aGFuZGxlID0gaGFu ZGxlOwo+ICAgCj4gLQkJLyogdHJhbnNmZXIgcmVmIHRvIGN0eCAqLwo+IC0JCW9iaiA9IE5VTEw7 Cj4gLQo+ICAgYWRkX3ZtYToKPiAgIAkJZXJyID0gZWJfYWRkX3ZtYShlYiwgaSwgdm1hKTsKPiAg IAkJaWYgKHVubGlrZWx5KGVycikpCj4gLQkJCWdvdG8gZXJyX29iajsKPiArCQkJZ290byBlcnJf dm1hOwo+ICAgCj4gICAJCUdFTV9CVUdfT04odm1hICE9IGViLT52bWFbaV0pOwo+ICAgCQlHRU1f QlVHX09OKHZtYS0+ZXhlY19mbGFncyAhPSAmZWItPmZsYWdzW2ldKTsKPiBAQCAtNzY2LDggKzc2 NCw3IEBAIHN0YXRpYyBpbnQgZWJfbG9va3VwX3ZtYXMoc3RydWN0IGk5MTVfZXhlY2J1ZmZlciAq ZWIpCj4gICAJcmV0dXJuIGViX3Jlc2VydmUoZWIpOwo+ICAgCj4gICBlcnJfb2JqOgo+IC0JaWYg KG9iaikKPiAtCQlpOTE1X2dlbV9vYmplY3RfcHV0KG9iaik7Cj4gKwlpOTE1X2dlbV9vYmplY3Rf cHV0KG9iaik7Cj4gICBlcnJfdm1hOgo+ICAgCWViLT52bWFbaV0gPSBOVUxMOwo+ICAgCXJldHVy biBlcnI7Cj4gCgpMb29rcyBnb29kIHRvIG1lLgoKUmV2aWV3ZWQtYnk6IFR2cnRrbyBVcnN1bGlu IDx0dnJ0a28udXJzdWxpbkBpbnRlbC5jb20+CgpSZWdhcmRzLAoKVHZydGtvCl9fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCkludGVsLWdmeCBtYWlsaW5nIGxp c3QKSW50ZWwtZ2Z4QGxpc3RzLmZyZWVkZXNrdG9wLm9yZwpodHRwczovL2xpc3RzLmZyZWVkZXNr dG9wLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2ludGVsLWdmeAo=