Re: [Qemu-devel] [PATCH v9 04/13] dirty-bitmap: add locked state

[Vladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com>]

20.12.2017 18:49, Vladimir Sementsov-Ogievskiy wrote:
> Add special state, when qmp operations on the bitmap are disabled.
> It is needed during bitmap migration. "Frozen" state is not
> appropriate here, because it looks like bitmap is unchanged.
>
> Signed-off-by: Vladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com>
> ---

[...]

> +void bdrv_dirty_bitmap_set_qmp_locked(BdrvDirtyBitmap *bitmap, bool qmp_locked)
> +{
> +    qemu_mutex_lock(bitmap->mutex);
> +    bitmap->qmp_locked = qmp_locked;
> +    qemu_mutex_unlock(bitmap->mutex);
> +}
> +
> +bool bdrv_dirty_bitmap_qmp_locked(BdrvDirtyBitmap *bitmap)
> +{
> +    return bitmap->qmp_locked;
> +}
> +
>   /* Called with BQL taken.  */
>   bool bdrv_dirty_bitmap_enabled(BdrvDirtyBitmap *bitmap)
>   {
> @@ -197,6 +211,8 @@ DirtyBitmapStatus bdrv_dirty_bitmap_status(BdrvDirtyBitmap *bitmap)
>   {
>       if (bdrv_dirty_bitmap_frozen(bitmap)) {
>           return DIRTY_BITMAP_STATUS_FROZEN;
> +    } else if (!bdrv_dirty_bitmap_qmp_locked(bitmap)) {

should be without "!", it breaks 124 iotest.

> +        return DIRTY_BITMAP_STATUS_LOCKED;
>       } else if (!bdrv_dirty_bitmap_enabled(bitmap)) {
>           return DIRTY_BITMAP_STATUS_DISABLED;
>       } else {
> diff --git a/blockdev.c b/blockdev.c
> index 56a6b24a0b..82b2956c5c 100644
> --- a/blockdev.c



-- 
Best regards,
Vladimir