From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1753599AbdKXRO7 (ORCPT <rfc822;w@1wt.eu>);
        Fri, 24 Nov 2017 12:14:59 -0500
Received: from mail-pg0-f54.google.com ([74.125.83.54]:38733 "EHLO
        mail-pg0-f54.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1750731AbdKXRO5 (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Fri, 24 Nov 2017 12:14:57 -0500
X-Google-Smtp-Source: AGs4zMb1viPB2rSomOP50UsTBT/57UV8g8FZQyDW727lN9d2fsejDu/fugouXFzPVxokhHZ4NwRRZQ==
Subject: Re: [PATCH] net-sysfs: export gso_max_size attribute
To: Solio Sarabia <solio.sarabia@intel.com>, netdev@vger.kernel.org,
        davem@daveloft.net, stephen@networkplumber.org
Cc: kys@microsoft.com, shiny.sebastian@intel.com,
        linux-kernel@vger.kernel.org
References: <1511397041-27994-1-git-send-email-solio.sarabia@intel.com>
From: David Ahern <dsahern@gmail.com>
Message-ID: <338121b9-5e71-be85-7faf-02dbba070df3@gmail.com>
Date: Fri, 24 Nov 2017 10:14:51 -0700
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.12; rv:52.0)
 Gecko/20100101 Thunderbird/52.4.0
MIME-Version: 1.0
In-Reply-To: <1511397041-27994-1-git-send-email-solio.sarabia@intel.com>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 11/22/17 5:30 PM, Solio Sarabia wrote:
> The netdevice gso_max_size is exposed to allow users fine-control on
> systems with multiple NICs with different GSO buffer sizes, and where
> the virtual devices like bridge and veth, need to be aware of the GSO
> size of the underlying devices.
> 
> In a virtualized environment, setting the right GSO sizes for physical
> and virtual devices makes all TSO work to be on physical NIC, improving
> throughput and reducing CPU util. If virtual devices send buffers
> greater than what NIC supports, it forces host to do TSO for buffers
> exceeding the limit, increasing CPU utilization in host.
> 
> Suggested-by: Shiny Sebastian <shiny.sebastian@intel.com>
> Signed-off-by: Solio Sarabia <solio.sarabia@intel.com>
> ---

This should be added to rtnetlink rather than sysfs.