From: Arnd Bergmann <arnd@arndb.de> To: Kukjin Kim <kgene.kim@samsung.com> Cc: 'Naveen Krishna Chatradhi' <ch.naveen@samsung.com>, linux-arm-kernel@lists.infradead.org, naveenkrishna.ch@gmail.com, linux-samsung-soc@vger.kernel.org, catalin.marinas@arm.com, robh@kernel.org, devicetree@vger.kernel.org, t.figa@samsung.com Subject: Re: [PATCH v2 5/7] arm64: dts: Add initial device tree support for EXYNOS7 Date: Wed, 03 Sep 2014 18:22:28 +0200 [thread overview] Message-ID: <3382034.5ADO0F7naY@wuerfel> (raw) In-Reply-To: <036a01cfc792$422271e0$c66755a0$@samsung.com> On Thursday 04 September 2014 01:15:20 Kukjin Kim wrote: > Naveen Krishna Chatradhi wrote: > > > diff --git a/arch/arm64/boot/dts/exynos/exynos7-espresso.dts b/arch/arm64/boot/dts/exynos/exynos7- > > espresso.dts > > new file mode 100644 > > index 0000000..f6a8879 > > --- /dev/null > > +++ b/arch/arm64/boot/dts/exynos/exynos7-espresso.dts > > @@ -0,0 +1,31 @@ > > +/* > > + * SAMSUNG Exynos7 Espresso board device tree source > > + * > > + * Copyright (c) 2014 Samsung Electronics Co., Ltd. > > + * http://www.samsung.com > > + * > > + * This program is free software; you can redistribute it and/or modify > > + * it under the terms of the GNU General Public License version 2 as > > + * published by the Free Software Foundation. > > +*/ > > + > > +/dts-v1/; > > +#include "exynos7.dtsi" > > + > > +/ { > > + model = "Samsung Exynos7 Espresso board based on EXYNOS7"; > > + compatible = "samsung,exynos7-espresso", "samsung,exynos7"; > > + > > + chosen { > > + linux,stdout-path = &serial_2; > > Well... > > > + }; > > + > > + memory@40000000 { > > + device_type = "memory"; > > + reg = <0x0 0x40000000 0x0 0xC0000000>; > > The base address of system memory is depending on each board, actually some of > them are 0x20000000. This is the board specific file, so it seems ok. > > +#include <dt-bindings/clock/exynos7-clk.h> > > + > > +/ { > > + compatible = "samsung,exynos7"; > > + interrupt-parent = <&gic>; > > + #address-cells = <2>; > > + #size-cells = <2>; > > + > > + aliases { > > + serial0 = &serial_0; > > + serial1 = &serial_1; > > + serial2 = &serial_2; > > + serial3 = &serial_3; > > There are exynos7 SoC is having 3 serial IPs... These aliases should just go into the board file as well, and since it seems to have only one uart, the best way is to list that as serial0: serial0 = &serial_2; > > + > > + psci { > > + compatible = "arm,psci-0.2"; > > + method = "smc"; > > + }; > > + > > + soc: soc { > > + compatible = "simple-bus"; > > + #address-cells = <1>; > > + #size-cells = <1>; > > + ranges = <0 0 0 0x18000000>; > > + > > + chipid@10000000 { > > + compatible = "samsung,exynos4210-chipid"; > > + reg = <0x10000000 0x100>; > > + }; > > + > > + fin_pll: xxti { > > + compatible = "fixed-clock"; > > + clock-frequency = <24000000>; > > It's wrong on some exynos7 SoCs... > Is this an external clock input? If so, the frequency should also go into the board file, otherwise into the soc-specific one. Arnd
WARNING: multiple messages have this Message-ID (diff)
From: arnd@arndb.de (Arnd Bergmann) To: linux-arm-kernel@lists.infradead.org Subject: [PATCH v2 5/7] arm64: dts: Add initial device tree support for EXYNOS7 Date: Wed, 03 Sep 2014 18:22:28 +0200 [thread overview] Message-ID: <3382034.5ADO0F7naY@wuerfel> (raw) In-Reply-To: <036a01cfc792$422271e0$c66755a0$@samsung.com> On Thursday 04 September 2014 01:15:20 Kukjin Kim wrote: > Naveen Krishna Chatradhi wrote: > > > diff --git a/arch/arm64/boot/dts/exynos/exynos7-espresso.dts b/arch/arm64/boot/dts/exynos/exynos7- > > espresso.dts > > new file mode 100644 > > index 0000000..f6a8879 > > --- /dev/null > > +++ b/arch/arm64/boot/dts/exynos/exynos7-espresso.dts > > @@ -0,0 +1,31 @@ > > +/* > > + * SAMSUNG Exynos7 Espresso board device tree source > > + * > > + * Copyright (c) 2014 Samsung Electronics Co., Ltd. > > + * http://www.samsung.com > > + * > > + * This program is free software; you can redistribute it and/or modify > > + * it under the terms of the GNU General Public License version 2 as > > + * published by the Free Software Foundation. > > +*/ > > + > > +/dts-v1/; > > +#include "exynos7.dtsi" > > + > > +/ { > > + model = "Samsung Exynos7 Espresso board based on EXYNOS7"; > > + compatible = "samsung,exynos7-espresso", "samsung,exynos7"; > > + > > + chosen { > > + linux,stdout-path = &serial_2; > > Well... > > > + }; > > + > > + memory at 40000000 { > > + device_type = "memory"; > > + reg = <0x0 0x40000000 0x0 0xC0000000>; > > The base address of system memory is depending on each board, actually some of > them are 0x20000000. This is the board specific file, so it seems ok. > > +#include <dt-bindings/clock/exynos7-clk.h> > > + > > +/ { > > + compatible = "samsung,exynos7"; > > + interrupt-parent = <&gic>; > > + #address-cells = <2>; > > + #size-cells = <2>; > > + > > + aliases { > > + serial0 = &serial_0; > > + serial1 = &serial_1; > > + serial2 = &serial_2; > > + serial3 = &serial_3; > > There are exynos7 SoC is having 3 serial IPs... These aliases should just go into the board file as well, and since it seems to have only one uart, the best way is to list that as serial0: serial0 = &serial_2; > > + > > + psci { > > + compatible = "arm,psci-0.2"; > > + method = "smc"; > > + }; > > + > > + soc: soc { > > + compatible = "simple-bus"; > > + #address-cells = <1>; > > + #size-cells = <1>; > > + ranges = <0 0 0 0x18000000>; > > + > > + chipid at 10000000 { > > + compatible = "samsung,exynos4210-chipid"; > > + reg = <0x10000000 0x100>; > > + }; > > + > > + fin_pll: xxti { > > + compatible = "fixed-clock"; > > + clock-frequency = <24000000>; > > It's wrong on some exynos7 SoCs... > Is this an external clock input? If so, the frequency should also go into the board file, otherwise into the soc-specific one. Arnd
next prev parent reply other threads:[~2014-09-03 16:22 UTC|newest] Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top 2014-09-02 15:35 [PATCH v2 0/7] arch: arm64: enable support for Samsung Exynos7 SoC Naveen Krishna Chatradhi 2014-09-02 15:35 ` Naveen Krishna Chatradhi 2014-09-02 15:35 ` [PATCH v2 1/7] clk: samsung: add support for 145xx and 1460x PLLs Naveen Krishna Chatradhi 2014-09-02 15:35 ` Naveen Krishna Chatradhi 2014-09-02 15:35 ` [PATCH v2 2/7] clk: samsung: Factor out the common code to clk.c Naveen Krishna Chatradhi 2014-09-02 15:35 ` Naveen Krishna Chatradhi 2014-09-02 15:35 ` [PATCH v2 3/7] clk: samsung: Add fixed_factor_clocks field to struct exynos_cmu_info Naveen Krishna Chatradhi 2014-09-02 15:35 ` Naveen Krishna Chatradhi 2014-09-02 15:35 ` [PATCH v2 4/7] clk: samsung: add initial clock support for Exynos7 SoC Naveen Krishna Chatradhi 2014-09-02 15:35 ` Naveen Krishna Chatradhi 2014-09-02 15:35 ` [PATCH v2 5/7] arm64: dts: Add initial device tree support for EXYNOS7 Naveen Krishna Chatradhi 2014-09-02 15:35 ` Naveen Krishna Chatradhi 2014-09-03 16:15 ` Kukjin Kim 2014-09-03 16:15 ` Kukjin Kim 2014-09-03 16:22 ` Arnd Bergmann [this message] 2014-09-03 16:22 ` Arnd Bergmann 2014-09-03 16:31 ` Kukjin Kim 2014-09-03 16:31 ` Kukjin Kim 2014-09-03 18:28 ` Arnd Bergmann 2014-09-03 18:28 ` Arnd Bergmann 2014-09-09 3:06 ` kgene 2014-09-09 3:06 ` kgene at kernel.org 2014-09-09 3:28 ` kgene 2014-09-09 3:28 ` kgene at kernel.org 2014-09-11 8:42 ` Naveen Krishna Ch 2014-09-11 8:42 ` Naveen Krishna Ch 2014-09-02 15:35 ` [PATCH v2 6/7] tty/serial: samsung: enable usage for 64-bit Exynos platforms Naveen Krishna Chatradhi 2014-09-02 15:35 ` Naveen Krishna Chatradhi 2014-09-02 15:35 ` [PATCH v2 7/7] arm64: exynos7: Enable ARMv8 based Exynos7 (SoC) support Naveen Krishna Chatradhi 2014-09-02 15:35 ` Naveen Krishna Chatradhi 2014-09-02 16:37 ` [PATCH v2 0/7] arch: arm64: enable support for Samsung Exynos7 SoC Tomasz Figa 2014-09-02 16:37 ` Tomasz Figa
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=3382034.5ADO0F7naY@wuerfel \ --to=arnd@arndb.de \ --cc=catalin.marinas@arm.com \ --cc=ch.naveen@samsung.com \ --cc=devicetree@vger.kernel.org \ --cc=kgene.kim@samsung.com \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-samsung-soc@vger.kernel.org \ --cc=naveenkrishna.ch@gmail.com \ --cc=robh@kernel.org \ --cc=t.figa@samsung.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.