From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 14DE1C636CC for ; Tue, 7 Feb 2023 09:11:17 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 36B5D85CDE; Tue, 7 Feb 2023 10:11:15 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=canonical.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (2048-bit key; unprotected) header.d=canonical.com header.i=@canonical.com header.b="YXIrTzKA"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id C3F4085CE2; Tue, 7 Feb 2023 10:11:13 +0100 (CET) Received: from smtp-relay-internal-0.canonical.com (smtp-relay-internal-0.canonical.com [185.125.188.122]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 6CD3985742 for ; Tue, 7 Feb 2023 10:11:10 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=canonical.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=heinrich.schuchardt@canonical.com Received: from mail-wr1-f70.google.com (mail-wr1-f70.google.com [209.85.221.70]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by smtp-relay-internal-0.canonical.com (Postfix) with ESMTPS id B968E3FDAA for ; Tue, 7 Feb 2023 09:11:09 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=canonical.com; s=20210705; t=1675761069; bh=DMJlBgLRSJDQ5mvPkUg6kevmQSAbs80LIyWVU8L0RY4=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=YXIrTzKAV9o4lPgsJSlzdJsmVR14jPmhR/7C/nkWGim2x/kSEgRSoOqaBUKX/fJc8 uH9RjcrOhByg2dmSfe+LBy7etRGZYDsPq3jbLpauypKpO2CgSKsAM+4gX57jUqbBYi 0hfjwdXKjR2hpdOm1EWj2RUOl/2SGT1s8JggBwt3nBBSh+ZgY5Tfe1u7acAMGCf7QV kDkqAlGX5WNCyx5Dg18JvmWUB6hwn8sph3Y7+bPwclvRiLY+SdAa7J8ssGW6oETZ0v 1kx2tffB+RSm1+jWLqr5PqM5cPcqFUWkoOO9RfMInIi55VomoCoWcesyswTKqrQKqf 92Oxjx6ET+wQQ== Received: by mail-wr1-f70.google.com with SMTP id w10-20020a5d544a000000b002c3de7a10b0so969958wrv.5 for ; Tue, 07 Feb 2023 01:11:09 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=DMJlBgLRSJDQ5mvPkUg6kevmQSAbs80LIyWVU8L0RY4=; b=BmiykVr88B2TY2IdvE3NTONuZwykWNOvhi6WnOkoIBZvF08lWRb+Kpx3eWRJ5nUxDJ zoXUJr2TeK53YE+pRQqRFbuQhc7sNmgKx9DYxUNlGRnM5/PZn66MmP1RsnVt+BCiS7eY pEwqrHc9588DoaeaepsFmdOrehF4mENXo1oovxmzhifgVzxU0AlABfjF/YhqG/o6uK3j V9YiNmi7Fb5sGhGylJZMIa6jIV9SkJqdN5zmLCyanrqBNo0uLY+kCA42r/wRGzspML10 DsXhBhRoj0izwZlXYx0eouovhlXu6LSWMc824P6mUJylwPoqJXr3YlhpjRXTpRQQU/JX 5GwQ== X-Gm-Message-State: AO0yUKUTuNJK3mXwDxGp70bgafQ+dDBPQcDdSgE3fyzGPXEHDMl0l+be 5dwXcxS7Ds3qeWDHMyDE3JR6g0lY75ggnOopZKmvzq3rgJmFMOq3GCi8cAxxgm8lpMrRVNlbEfJ VqSPxT89U7srb1Gd4KW+BwMtvd3cc6ig= X-Received: by 2002:a05:600c:13d3:b0:3dd:daac:d99d with SMTP id e19-20020a05600c13d300b003dddaacd99dmr2331340wmg.36.1675761069372; Tue, 07 Feb 2023 01:11:09 -0800 (PST) X-Google-Smtp-Source: AK7set+xSfODXDWbiRstYC0ektIU98yjzOPhtpchJDEmR4BzHh4TmD4l8d7WwqncMfUhl2gs77N22A== X-Received: by 2002:a05:600c:13d3:b0:3dd:daac:d99d with SMTP id e19-20020a05600c13d300b003dddaacd99dmr2331320wmg.36.1675761069071; Tue, 07 Feb 2023 01:11:09 -0800 (PST) Received: from [192.168.123.67] (ip-088-152-145-137.um26.pools.vodafone-ip.de. [88.152.145.137]) by smtp.gmail.com with ESMTPSA id t6-20020a05600c198600b003dc492e4430sm13844250wmq.28.2023.02.07.01.11.08 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 07 Feb 2023 01:11:08 -0800 (PST) Message-ID: <3385c2f1-d676-6284-f1fb-7847943b4822@canonical.com> Date: Tue, 7 Feb 2023 10:11:07 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.7.1 Subject: Re: [PATCH v2 078/169] Correct SPL use of EFI_UNICODE_COLLATION_PROTOCOL2 To: Tom Rini Cc: Simon Glass , U-Boot Mailing List References: <20230205224118.233425-63-sjg@chromium.org> <20230205224118.233425-79-sjg@chromium.org> <835558ba-c78f-f64a-3df5-4fffc2afa875@canonical.com> <38c821aa-b2c6-2bf3-d507-3928c4dc195b@canonical.com> Content-Language: en-US From: Heinrich Schuchardt In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.6 at phobos.denx.de X-Virus-Status: Clean On 2/7/23 02:36, Tom Rini wrote: > On Tue, Feb 07, 2023 at 02:24:22AM +0100, Heinrich Schuchardt wrote: >> >> >> On 2/7/23 00:38, Tom Rini wrote: >>> On Tue, Feb 07, 2023 at 12:36:51AM +0100, Heinrich Schuchardt wrote: >>>> On 2/5/23 23:39, Simon Glass wrote: >>>>> This converts 1 usage of this option to the non-SPL form, since there is >>>>> no SPL_EFI_UNICODE_COLLATION_PROTOCOL2 defined in Kconfig >>>>> >>>>> Signed-off-by: Simon Glass >>>>> --- >>>>> >>>>> (no changes since v1) >>>>> >>>>> lib/efi_loader/efi_root_node.c | 2 +- >>>>> 1 file changed, 1 insertion(+), 1 deletion(-) >>>>> >>>>> diff --git a/lib/efi_loader/efi_root_node.c b/lib/efi_loader/efi_root_node.c >>>>> index 21a014d7c21..108c14b95bd 100644 >>>>> --- a/lib/efi_loader/efi_root_node.c >>>>> +++ b/lib/efi_loader/efi_root_node.c >>>>> @@ -68,7 +68,7 @@ efi_status_t efi_root_node_register(void) >>>>> &efi_guid_dt_fixup_protocol, >>>>> &efi_dt_fixup_prot, >>>>> #endif >>>>> -#if CONFIG_IS_ENABLED(EFI_UNICODE_COLLATION_PROTOCOL2) >>>>> +#if IS_ENABLED(CONFIG_EFI_UNICODE_COLLATION_PROTOCOL2) >>>> >>>> I never received this patch in my inbox. Expect series with more than 50 >>>> mails not even to be copied to the spam folder. They are outright rejected >>>> by my mail provider. >>>> >>>> I cannot see any problem solved by this patch. Why did you send it? >>> >>> You should look in to setting up lei to fetch the list then, as this is >>> well explained in the cover letter. >> >> lei = circle of flowers is what I find in a dictionary. Do I miss an >> idiomatic expression? > > Yes, https://public-inbox.org/lei.html is a tool widely used in the > kernel community, and also works for U-Boot as we're mirrored on > lore.kernel.org. In short, it's what I'm using to download the mailing > list now, without Google screwing up and putting some messages in the > spam folder and then I miss them. Also nice when U-Boot gets cc'd on > something later and it'll just pull the whole thread in from the other > lists for me, for context. > >> The cover letter describes an observation but does not point out any problem >> relating to this observation. > [snip to reorder] >> >> Is anything wrong about this use of CONFIG_IS_ENABLED(EFI_LOADER)? >> >> What is the reasoning behind wanting to use CONFIG_IS_ENABLED() only if an >> SPL config option exists? > > We have two macros, IS_ENABLED(CONFIG_FOO) and CONFIG_IS_ENABLED(FOO). > The case where we use CONFIG_IS_ENABLED(FOO) and CONFIG_SPL_FOO (or > _TPL_ or _VPL_) is not a valid symbol AND it makes sense to use > CONFIG_IS_ENABLED(FOO) because we need to have the test evaluate to > false because IS_ENABLED(CONFIG_FOO) would be true but we can rely on > CONFIG_SPL_FOO being false due to being undefined is, on the whole, very > rare. In specifics however, code supporting the EFI loader subsystem > makes use of this because as for example yes, we modify printf related > code. So that needs to be tested with CONFIG_IS_ENABLED(). However, in > the example here never will we ever build lib/efi_loader/efi_root_node.c > outside of the main U-Boot case, so we should be testing via > IS_ENABLED(). > > [paste to re-order] >> We don't have a CONFIG_SPL_EFI_LOADER. In vsnprintf_internal() we use >> CONFIG_IS_ENABLED(EFI_LOADER). The code inside the #if condition is not >> compiled in SPL. This is the desired behavior. >> >> How is moveconfig meant to accept this? > [back in order] >> Where is the documentation change describing that CONFIG_IS_ENABLED() should >> only be used if an SPL config option exists? > > Yes, in the final related series that moves to a "split config" build. No related series was mentioned in the cover-letter. Which series do you relate to? > And if what's in there isn't enough, that series should get more. That's > where CONFIG_IS_ENABLED(EFI_LOADER) in the vsprintf could would be If the target is to remove CONFIG_IS_ENABLED() I would expect this mentioned in the individual commit messages so that we get this information into the git log. Furthermore the reasoning behind eliminating CONFIG_IS_ENABLED() should be mentioned in the cover-letter. Best regards Heinrich > handled because that series is where Simon removes CONFIG_IS_ENABLED(), > adds more SPL_FOO def_bool n options, and moves to IS_ENABLED() for > everything. And that series is still under discussion. > > However, the vast majority if CONFIG_IS_ENABLED(FOO) where SPL_FOO, etc, > are never defined should be using IS_ENABLED(CONFIG_FOO). >