From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Michael Kerrisk (man-pages)" Subject: Re: [PATCH 0/5 RFC] Add an interface to discover relationships between namespaces Date: Tue, 26 Jul 2016 10:03:25 +0200 Message-ID: <3390535b-0660-757f-aeba-c03d936b3485__43129.6351984658$1469520232$gmane$org@gmail.com> References: <1468520419-28220-1-git-send-email-avagin@openvz.org> <20160721210650.GA10989@outlook.office365.com> <1515f5f2-5a49-fcab-61f4-8b627d3ba3e2@gmail.com> <87lh0pg8jx.fsf@x220.int.ebiederm.org> <44ca0e41-dc92-45b1-2a6c-c41a048a072d@gmail.com> <87r3ahepb4.fsf@x220.int.ebiederm.org> <20160726025455.GC26206@outlook.office365.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii"; Format="flowed" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <20160726025455.GC26206-1ViLX0X+lBJGNQ1M2rI3KwRV3xvJKrda@public.gmane.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: containers-bounces-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org Errors-To: containers-bounces-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org To: Andrew Vagin , "Eric W. Biederman" Cc: Serge Hallyn , Andrey Vagin , Linux API , Linux Containers , LKML , "criu-GEFAQzZX7r8dnm+yROfE0A@public.gmane.org" , mtk.manpages-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org, linux-fsdevel , James Bottomley , Alexander Viro List-Id: containers.vger.kernel.org On 07/26/2016 04:54 AM, Andrew Vagin wrote: > On Mon, Jul 25, 2016 at 09:59:43AM -0500, Eric W. Biederman wrote: >> "Michael Kerrisk (man-pages)" writes: > > [snip] > >> [snip] >>>>> So, from my point of view, the important piece that was missing from >>>>> your commit message was the note to use readlink("/proc/self/fd/%d") >>>>> on the returned FDs. I think that detail needs to be part of the >>>>> commit message (and also the man page text). I think it even be >>>>> helpful to include the above program as part of the commit message: >>>>> it helps people more quickly grasp the API. >>>> >>>> Please, please make the standard way to compare these things fstat. >>>> That is much less magic than a symlink, and a little more future proof. >>>> Possibly even kcmp. > > I like the idea to use kcmp to compare namespaces. I am going to add this > functionality to kcmp and describe all these in the man page. Hi Andrey, Can you briefly sketch out the proposed API and how it would be used? I'd find it useful to see that even before the implementation. Cheers, Michael -- Michael Kerrisk Linux man-pages maintainer; http://www.kernel.org/doc/man-pages/ Linux/UNIX System Programming Training: http://man7.org/training/