From: Thomas Monjalon <thomas@monjalon.net>
To: "Richardson, Bruce" <bruce.richardson@intel.com>
Cc: "dev@dpdk.org" <dev@dpdk.org>,
"Laatz, Kevin" <kevin.laatz@intel.com>,
"Pai G, Sunil" <sunil.pai.g@intel.com>
Subject: Re: [PATCH] dma/idxd: fix missing default for workqueue options
Date: Tue, 21 Jun 2022 17:35:28 +0200 [thread overview]
Message-ID: <3392561.3Lj2Plt8kZ@thomas> (raw)
In-Reply-To: <DM8PR11MB560589D93714124A423B4842BDB09@DM8PR11MB5605.namprd11.prod.outlook.com>
20/06/2022 06:09, Pai G, Sunil:
> > From: Richardson, Bruce <bruce.richardson@intel.com>
> > Sent: Friday, June 17, 2022 4:48 PM
> > To: dev@dpdk.org
> > Cc: Laatz, Kevin <kevin.laatz@intel.com>; Pai G, Sunil
> > <sunil.pai.g@intel.com>; Richardson, Bruce <bruce.richardson@intel.com>
> > Subject: [PATCH] dma/idxd: fix missing default for workqueue options
> >
> > When no --wq-option flag is passed to dpdk_idxd_cfg.py script, the default
> > value used by argparse is None. This leads to later errors which are
> > expecting an array value:
> >
> > TypeError: 'NoneType' object is not iterable
> >
> > This is fixed by specifying that the empty array should be the default if
> > no flags are passed.
> >
> > Fixes: 94b0f04dc0e3 ("dma/idxd: add generic option for queue config")
> >
> > Signed-off-by: Bruce Richardson <bruce.richardson@intel.com>
> > ---
>
> LGTM
> Acked-by: Sunil Pai G <sunil.pai.g@intel.com>
Applied, thanks.
next prev parent reply other threads:[~2022-06-21 15:35 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-06-17 11:17 [PATCH] dma/idxd: fix missing default for workqueue options Bruce Richardson
2022-06-20 4:09 ` Pai G, Sunil
2022-06-21 15:35 ` Thomas Monjalon [this message]
2022-06-20 9:21 ` Walsh, Conor
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3392561.3Lj2Plt8kZ@thomas \
--to=thomas@monjalon.net \
--cc=bruce.richardson@intel.com \
--cc=dev@dpdk.org \
--cc=kevin.laatz@intel.com \
--cc=sunil.pai.g@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.