From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-lj1-f177.google.com (mail-lj1-f177.google.com [209.85.208.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E38B472 for ; Wed, 25 Aug 2021 10:13:58 +0000 (UTC) Received: by mail-lj1-f177.google.com with SMTP id i28so42659493ljm.7 for ; Wed, 25 Aug 2021 03:13:58 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=JS8C6fS8XkmAAsadcB8zqjJCFkYRlN9Um96y+mbS8Cc=; b=Zoyz2GPzJxE/cLWDh9w/GrlJZh3XxMTY/o3rSVVq9xbHcltHeoAC3+1iMyYDpgXNbK U5QCwqHLyfONIKqL/5QWp8JtiZRRIKJpFKDPGc7ZHebsVwXCcJxW8r9wTQYqq2SBUPIJ 31YUgpMEUuHq44jzK3Xg6Wf5aWzLz8Zc42HUzbRF9F4BScxyKjK+K6WRA8e6dgg7Uddm ++6CGWf+7K1pDuJr0yKos6h5tJAIWuH3K3Y+fSYhUSYNenimIzAAPam5MeA2b627PqQX Ooej31HsLeL2p1FYtI2uPK5lnkBttE6vwDexNbEVRTiXqibtGd4m+voyYONF1IHA6Ghd uluQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=JS8C6fS8XkmAAsadcB8zqjJCFkYRlN9Um96y+mbS8Cc=; b=bFKUkF/Tzn4guSwlCz4mbsaUJRcbz3mc/GMxu/IvVjnTO5HmCuJmme18OsGVDrm7tA 003eAr48Hu0j29uDbWc3WOi+Hn47H2hMIKwKdSgAgsYgNLQF2vX0CE1Tr+yc2e7ZZNQV 5xV3GZVqXxU/MpaAgUW24I7biFx3d6hDsKlC/qeLlkrOAqPEuFJYYcgIE2/IpzrhvMgr atVFTFZHMh33S9yMFuVgNOMbVbqnWYcSaK2kHueoDbnjwH842t7izPqKEzcmJTOeCC2h C87c+vUL/AXFWvKh5G3a4nCaK4fPlaqUsSXY9RnXLh6+h83SM0bmsA3obNyK3pI5AWB3 HSKg== X-Gm-Message-State: AOAM5325owk9UCK8acpz18moR5aMWW3ydnvagh2NQN1+uM1laQtHpFuf ifFnWk/7FX4ViyNF81qhcgI= X-Google-Smtp-Source: ABdhPJzsRVopFPxrJm6WyComBRD3ag5rvATMX7m9T9++0GxomEUsZExl2Lfn4lE42mnJ6kKInbkP0w== X-Received: by 2002:a05:651c:1186:: with SMTP id w6mr8434327ljo.50.1629886437077; Wed, 25 Aug 2021 03:13:57 -0700 (PDT) Received: from [192.168.1.11] ([46.235.66.127]) by smtp.gmail.com with ESMTPSA id d24sm2219522lfs.80.2021.08.25.03.13.56 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 25 Aug 2021 03:13:56 -0700 (PDT) Subject: Re: [PATCH v3 4/6] staging: r8188eu: add error handling of rtw_read16 To: Dan Carpenter Cc: "Fabio M. De Francesco" , Larry.Finger@lwfinger.net, phil@philpotter.co.uk, gregkh@linuxfoundation.org, straube.linux@gmail.com, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org References: <1665728.ljvk3MsED4@localhost.localdomain> <2227654.mbYB7oqmoa@localhost.localdomain> <794dfd94-fe88-43ac-c4ec-9ff7df9db6de@gmail.com> <20210825100647.GS1931@kadam> From: Pavel Skripkin Message-ID: <3396277b-6d80-b621-0ef0-71de7d581602@gmail.com> Date: Wed, 25 Aug 2021 13:13:54 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.13.0 Precedence: bulk X-Mailing-List: linux-staging@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 In-Reply-To: <20210825100647.GS1931@kadam> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit On 8/25/21 1:06 PM, Dan Carpenter wrote: > On Wed, Aug 25, 2021 at 12:55:37PM +0300, Pavel Skripkin wrote: >> The main problem, that no one knows who is the "old". Greg can take patches >> in any order he wants > > Patches are always taken in first come first serve. > Ok, but if pending patch needs new version, then it will be taken at the end? Here is the situation we have: I have the patch series based on old function behavior, it was posted first Then Fabio posted refactoring of the function and it changes return values. Both series are pending right now and made on top of staging-next branch. Who needs to rebase? I think, applying these series as-is can broke the driver, since error handling will be broken With regards, Pavel Skripkin