From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 68196C433F5 for ; Tue, 2 Nov 2021 16:44:13 +0000 (UTC) Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 75D3060EB4 for ; Tue, 2 Nov 2021 16:44:12 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 75D3060EB4 Authentication-Results: mail.kernel.org; dmarc=fail (p=quarantine dis=none) header.from=broadcom.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=lists.denx.de Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id C621682051; Tue, 2 Nov 2021 17:44:09 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=pass (p=quarantine dis=none) header.from=broadcom.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (1024-bit key; unprotected) header.d=broadcom.com header.i=@broadcom.com header.b="LtfqNSJu"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 083918290A; Tue, 2 Nov 2021 17:44:08 +0100 (CET) Received: from mail-lf1-x12b.google.com (mail-lf1-x12b.google.com [IPv6:2a00:1450:4864:20::12b]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 51FDB80D1C for ; Tue, 2 Nov 2021 17:44:03 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=pass (p=quarantine dis=none) header.from=broadcom.com Authentication-Results: phobos.denx.de; spf=fail smtp.mailfrom=roman.bacik@broadcom.com Received: by mail-lf1-x12b.google.com with SMTP id o18so3778568lfu.13 for ; Tue, 02 Nov 2021 09:44:03 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=broadcom.com; s=google; h=from:references:in-reply-to:mime-version:thread-index:date :message-id:subject:to:cc; bh=ARxoob3/APTJ5XXpZagTXCg/HksTL4fRCYMT5/0Gnos=; b=LtfqNSJuGfL1F2hQ6EEoTJpgROKHPUxi36hzX4+cxR5n4UK9zWezWDhmtjBNEdmMRU KmGBvZzdD2jbl0oaTaHVCKbjmPZkkS9K9rxhy22V7cWvbZ3xT2akcfzuk9MQRLG9a2G4 ghTzbNVXb4eTomNFlftj7wr2Bn4P8mwzI3s2U= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:references:in-reply-to:mime-version :thread-index:date:message-id:subject:to:cc; bh=ARxoob3/APTJ5XXpZagTXCg/HksTL4fRCYMT5/0Gnos=; b=f2dQMDhvSQP66u1eWBd0wlvi4DClPxiC9jNeEliGbjvDa3HBiQRTAULu8uGi/3KeAv HjRCQrRFf38MxKx/lEKRmD1V+ZD1gwVGyrHAcQG4FXuh0obTYQZf3cpWaCv+xfEys9lo ZfXV4Z82UEdzqKDp99qbW+kFSdLiswK6iEe4UeLutxGMFbqeDtEh3XYa88+Iok3Eigjm jniRhImMOvBdh6GR8hOW7sFikT6Y66nM/brmSuNzxokKOZLbpTctrpn+q6Wlc2++wu6K Y9UyPJM22QnYD3iWopthzIgTnUAki/ZBiZMnXoUiGWasMnqDB1YQsyY+VOO83rGL8K2q KNSw== X-Gm-Message-State: AOAM530FO+qV89TQWJB9WTgx5VnyJLJHazW8DGTZbEkTGNTlhnvPpZqV vlvenFLbfRZ5r86+7dMd+iTqmbze+/PnW7u5xBrtdqwp12bwu7Ceywng9NuSdwqekEXhAYXWuqY /9VTJNrDqY5HWKtuM/vae X-Google-Smtp-Source: ABdhPJyJ4W/6W8sRtSz2diPZU5uooJ2kiiescDjRnL17K6uP9PA+nXnD0Lf8DGhEMJ/2FTOLwb77JEu+yaylxkWlP1w= X-Received: by 2002:ac2:4118:: with SMTP id b24mr25262942lfi.296.1635871442414; Tue, 02 Nov 2021 09:44:02 -0700 (PDT) From: Roman Bacik References: <20211025123639.v4.1.Ibcd6b4db038dac555a5071d1406a0c2f757c9570@changeid> In-Reply-To: MIME-Version: 1.0 X-Mailer: Microsoft Outlook 16.0 Thread-Index: AQG/pGUSYKMkRNlL9/hpGXwRGk6MVQIVQz8HAbvakuYBaQlysav28y9w Date: Tue, 2 Nov 2021 09:43:53 -0700 Message-ID: <33968fa0b65debf4cfaa80404298a25e@mail.gmail.com> Subject: RE: [PATCH v4] driver: spi: add bcm iproc qspi support. To: Jagan Teki Cc: U-Boot Mailing List , Rayagonda Kokatanur , Bharat Gooty , Vignesh R Content-Type: multipart/signed; protocol="application/pkcs7-signature"; micalg=sha-256; boundary="0000000000003effb905cfd10038" X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.34 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.2 at phobos.denx.de X-Virus-Status: Clean --0000000000003effb905cfd10038 Content-Type: text/plain; charset="UTF-8" Hi Jagan, > -----Original Message----- > From: Jagan Teki > Sent: Monday, November 1, 2021 10:07 PM > To: Roman Bacik > Cc: U-Boot Mailing List ; Rayagonda Kokatanur > ; Bharat Gooty > ; Vignesh R > Subject: Re: [PATCH v4] driver: spi: add bcm iproc qspi support. > > On Tue, Nov 2, 2021 at 4:57 AM Roman Bacik > wrote: > > > > Hi Jagan, > > > > On Mon, Nov 1, 2021 at 12:12 AM Jagan Teki > wrote: > > > > > > On Tue, Oct 26, 2021 at 1:07 AM Roman Bacik > wrote: > > > > > > > > From: Rayagonda Kokatanur > > > > > > > > IPROC qspi driver supports both BSPI and MSPI modes. > > > > > > > > Signed-off-by: Rayagonda Kokatanur > > > > > Signed-off-by: Bharat Gooty > > > > Acked-by: Rayagonda Kokatanur > > > > > > > > > Signed-off-by: Roman Bacik > > > > --- > > > > > > > > Changes in v4: > > > > - move iproc_qspi.c from spi to mtd/spi > > > > - remove iproc_qspi.h > > > > - rename IPROC_QSPI to SPI_FLASH_IPROC > > > > > > > > Changes in v3: > > > > - fix warning by including linux/delay.h > > > > - change ofdata_to_platdata to of_to_plat > > > > - change priv_auto_alloc_size to priv_auto > > > > > > > > Changes in v2: > > > > - remove include spi-nor.h > > > > - define and use named BITs for writing register values > > > > - remove bspi_set_4byte_mode() method > > > > > > > > drivers/mtd/spi/Kconfig | 6 + > > > > drivers/mtd/spi/Makefile | 1 + > > > > drivers/mtd/spi/iproc_qspi.c | 718 > +++++++++++++++++++++++++++++++++++ > > > > 3 files changed, 725 insertions(+) > > > > create mode 100644 drivers/mtd/spi/iproc_qspi.c > > > > > > Look like you confused what I've mentioned before, your driver is > > > flash specific so add a driver in UCLASS_SPI_FLASH. drivers with > > > UCLASS_SPI to be in drivers/spi/ > > > > > > Jagan. > > > > This is a controller driver and it is currently meant to be used as > > follows: > > > > qspi: spi@370000 { > > compatible = "brcm,iproc-qspi"; > > reg = <0x00370000 0x100>, > > <0x00370100 0x100>, > > <0x00370200 0x200>; > > reg-names = "bspi", "bspi_raf", "mspi"; > > flash-iomap-addr = /bits/ 64 <0x70000000>; > > #address-cells = <1>; > > #size-cells = <0>; > > spi_nor_flash: spi_flash@0 { > > compatible = "jedec,spi-nor"; > > reg = <0>; > > spi-max-frequency = <12500000>; > > spi-cpol; > > spi-cpha; > > spi-tx-bus-width = <1>; > > spi-rx-bus-width = <4>; > > }; > > }; > > Does this binding is from Linux? if yes please share Linux driver. > > Jagan. Here is Linux binding document: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/devicetree/bindings/spi/brcm,spi-bcm-qspi.yaml And here is Linux driver: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/drivers/spi/spi-bcm-qspi.c Thanks, Roman -- This electronic communication and the information and any files transmitted with it, or attached to it, are confidential and are intended solely for the use of the individual or entity to whom it is addressed and may contain information that is confidential, legally privileged, protected by privacy laws, or otherwise restricted from disclosure to anyone else. If you are not the intended recipient or the person responsible for delivering the e-mail to the intended recipient, you are hereby notified that any use, copying, distributing, dissemination, forwarding, printing, or copying of this e-mail is strictly prohibited. If you received this e-mail in error, please return the e-mail to the sender, delete it from your computer, and destroy any printed copy of it. --0000000000003effb905cfd10038 Content-Type: application/pkcs7-signature; name="smime.p7s" Content-Transfer-Encoding: base64 Content-Disposition: attachment; filename="smime.p7s" Content-Description: S/MIME Cryptographic Signature MIIQagYJKoZIhvcNAQcCoIIQWzCCEFcCAQExDzANBglghkgBZQMEAgEFADALBgkqhkiG9w0BBwGg gg3BMIIFDTCCA/WgAwIBAgIQeEqpED+lv77edQixNJMdADANBgkqhkiG9w0BAQsFADBMMSAwHgYD VQQLExdHbG9iYWxTaWduIFJvb3QgQ0EgLSBSMzETMBEGA1UEChMKR2xvYmFsU2lnbjETMBEGA1UE AxMKR2xvYmFsU2lnbjAeFw0yMDA5MTYwMDAwMDBaFw0yODA5MTYwMDAwMDBaMFsxCzAJBgNVBAYT AkJFMRkwFwYDVQQKExBHbG9iYWxTaWduIG52LXNhMTEwLwYDVQQDEyhHbG9iYWxTaWduIEdDQyBS MyBQZXJzb25hbFNpZ24gMiBDQSAyMDIwMIIBIjANBgkqhkiG9w0BAQEFAAOCAQ8AMIIBCgKCAQEA vbCmXCcsbZ/a0fRIQMBxp4gJnnyeneFYpEtNydrZZ+GeKSMdHiDgXD1UnRSIudKo+moQ6YlCOu4t rVWO/EiXfYnK7zeop26ry1RpKtogB7/O115zultAz64ydQYLe+a1e/czkALg3sgTcOOcFZTXk38e aqsXsipoX1vsNurqPtnC27TWsA7pk4uKXscFjkeUE8JZu9BDKaswZygxBOPBQBwrA5+20Wxlk6k1 e6EKaaNaNZUy30q3ArEf30ZDpXyfCtiXnupjSK8WU2cK4qsEtj09JS4+mhi0CTCrCnXAzum3tgcH cHRg0prcSzzEUDQWoFxyuqwiwhHu3sPQNmFOMwIDAQABo4IB2jCCAdYwDgYDVR0PAQH/BAQDAgGG MGAGA1UdJQRZMFcGCCsGAQUFBwMCBggrBgEFBQcDBAYKKwYBBAGCNxQCAgYKKwYBBAGCNwoDBAYJ KwYBBAGCNxUGBgorBgEEAYI3CgMMBggrBgEFBQcDBwYIKwYBBQUHAxEwEgYDVR0TAQH/BAgwBgEB /wIBADAdBgNVHQ4EFgQUljPR5lgXWzR1ioFWZNW+SN6hj88wHwYDVR0jBBgwFoAUj/BLf6guRSSu TVD6Y5qL3uLdG7wwegYIKwYBBQUHAQEEbjBsMC0GCCsGAQUFBzABhiFodHRwOi8vb2NzcC5nbG9i YWxzaWduLmNvbS9yb290cjMwOwYIKwYBBQUHMAKGL2h0dHA6Ly9zZWN1cmUuZ2xvYmFsc2lnbi5j b20vY2FjZXJ0L3Jvb3QtcjMuY3J0MDYGA1UdHwQvMC0wK6ApoCeGJWh0dHA6Ly9jcmwuZ2xvYmFs c2lnbi5jb20vcm9vdC1yMy5jcmwwWgYDVR0gBFMwUTALBgkrBgEEAaAyASgwQgYKKwYBBAGgMgEo CjA0MDIGCCsGAQUFBwIBFiZodHRwczovL3d3dy5nbG9iYWxzaWduLmNvbS9yZXBvc2l0b3J5LzAN BgkqhkiG9w0BAQsFAAOCAQEAdAXk/XCnDeAOd9nNEUvWPxblOQ/5o/q6OIeTYvoEvUUi2qHUOtbf jBGdTptFsXXe4RgjVF9b6DuizgYfy+cILmvi5hfk3Iq8MAZsgtW+A/otQsJvK2wRatLE61RbzkX8 9/OXEZ1zT7t/q2RiJqzpvV8NChxIj+P7WTtepPm9AIj0Keue+gS2qvzAZAY34ZZeRHgA7g5O4TPJ /oTd+4rgiU++wLDlcZYd/slFkaT3xg4qWDepEMjT4T1qFOQIL+ijUArYS4owpPg9NISTKa1qqKWJ jFoyms0d0GwOniIIbBvhI2MJ7BSY9MYtWVT5jJO3tsVHwj4cp92CSFuGwunFMzCCA18wggJHoAMC AQICCwQAAAAAASFYUwiiMA0GCSqGSIb3DQEBCwUAMEwxIDAeBgNVBAsTF0dsb2JhbFNpZ24gUm9v dCBDQSAtIFIzMRMwEQYDVQQKEwpHbG9iYWxTaWduMRMwEQYDVQQDEwpHbG9iYWxTaWduMB4XDTA5 MDMxODEwMDAwMFoXDTI5MDMxODEwMDAwMFowTDEgMB4GA1UECxMXR2xvYmFsU2lnbiBSb290IENB IC0gUjMxEzARBgNVBAoTCkdsb2JhbFNpZ24xEzARBgNVBAMTCkdsb2JhbFNpZ24wggEiMA0GCSqG SIb3DQEBAQUAA4IBDwAwggEKAoIBAQDMJXaQeQZ4Ihb1wIO2hMoonv0FdhHFrYhy/EYCQ8eyip0E XyTLLkvhYIJG4VKrDIFHcGzdZNHr9SyjD4I9DCuul9e2FIYQebs7E4B3jAjhSdJqYi8fXvqWaN+J J5U4nwbXPsnLJlkNc96wyOkmDoMVxu9bi9IEYMpJpij2aTv2y8gokeWdimFXN6x0FNx04Druci8u nPvQu7/1PQDhBjPogiuuU6Y6FnOM3UEOIDrAtKeh6bJPkC4yYOlXy7kEkmho5TgmYHWyn3f/kRTv riBJ/K1AFUjRAjFhGV64l++td7dkmnq/X8ET75ti+w1s4FRpFqkD2m7pg5NxdsZphYIXAgMBAAGj QjBAMA4GA1UdDwEB/wQEAwIBBjAPBgNVHRMBAf8EBTADAQH/MB0GA1UdDgQWBBSP8Et/qC5FJK5N UPpjmove4t0bvDANBgkqhkiG9w0BAQsFAAOCAQEAS0DbwFCq/sgM7/eWVEVJu5YACUGssxOGhigH M8pr5nS5ugAtrqQK0/Xx8Q+Kv3NnSoPHRHt44K9ubG8DKY4zOUXDjuS5V2yq/BKW7FPGLeQkbLmU Y/vcU2hnVj6DuM81IcPJaP7O2sJTqsyQiunwXUaMld16WCgaLx3ezQA3QY/tRG3XUyiXfvNnBB4V 14qWtNPeTCekTBtzc3b0F5nCH3oO4y0IrQocLP88q1UOD5F+NuvDV0m+4S4tfGCLw0FREyOdzvcy a5QBqJnnLDMfOjsl0oZAzjsshnjJYS8Uuu7bVW/fhO4FCU29KNhyztNiUGUe65KXgzHZs7XKR1g/ XzCCBUkwggQxoAMCAQICDCFEwxkoxpWFSXQM7zANBgkqhkiG9w0BAQsFADBbMQswCQYDVQQGEwJC RTEZMBcGA1UEChMQR2xvYmFsU2lnbiBudi1zYTExMC8GA1UEAxMoR2xvYmFsU2lnbiBHQ0MgUjMg UGVyc29uYWxTaWduIDIgQ0EgMjAyMDAeFw0yMTAyMjIxNDA4NDlaFw0yMjA5MjIxNDMwNTZaMIGM MQswCQYDVQQGEwJJTjESMBAGA1UECBMJS2FybmF0YWthMRIwEAYDVQQHEwlCYW5nYWxvcmUxFjAU BgNVBAoTDUJyb2FkY29tIEluYy4xFDASBgNVBAMTC1JvbWFuIEJhY2lrMScwJQYJKoZIhvcNAQkB Fhhyb21hbi5iYWNpa0Bicm9hZGNvbS5jb20wggEiMA0GCSqGSIb3DQEBAQUAA4IBDwAwggEKAoIB AQDjz0l/8twCYGN0z9Sq+zp3YdbAIb1oxv1D69gAlA9kgZXJL/jItncBCmZvwQU+2zbHpWisfn88 9rKAgzhnlhnJFGIxgsEs3r0jQBhT8LoqL1MZMXKV0ih5ZvH0SQJi+bZD0BZH8tVLFHFcUIYAoRdQ tSCGGcVmzhvTC99CIpuW3URgSPD/01DNG0OsdH+bZ2VpSzl7DoW0S+AQwrffRv+lkWfTbUU+o+CE 6kRRYRlzjF1rVR3PZvtVpwKTcWvwqez9YnB5W7zFh0J6WXsQJsLKZoRNvv4VXAk2vycIsWR+aeNb l0x6vipMzcE90s2JZ/wqJlxX8dutql3gueCzZ2SxAgMBAAGjggHZMIIB1TAOBgNVHQ8BAf8EBAMC BaAwgaMGCCsGAQUFBwEBBIGWMIGTME4GCCsGAQUFBzAChkJodHRwOi8vc2VjdXJlLmdsb2JhbHNp Z24uY29tL2NhY2VydC9nc2djY3IzcGVyc29uYWxzaWduMmNhMjAyMC5jcnQwQQYIKwYBBQUHMAGG NWh0dHA6Ly9vY3NwLmdsb2JhbHNpZ24uY29tL2dzZ2NjcjNwZXJzb25hbHNpZ24yY2EyMDIwME0G A1UdIARGMEQwQgYKKwYBBAGgMgEoCjA0MDIGCCsGAQUFBwIBFiZodHRwczovL3d3dy5nbG9iYWxz aWduLmNvbS9yZXBvc2l0b3J5LzAJBgNVHRMEAjAAMEkGA1UdHwRCMEAwPqA8oDqGOGh0dHA6Ly9j cmwuZ2xvYmFsc2lnbi5jb20vZ3NnY2NyM3BlcnNvbmFsc2lnbjJjYTIwMjAuY3JsMCMGA1UdEQQc MBqBGHJvbWFuLmJhY2lrQGJyb2FkY29tLmNvbTATBgNVHSUEDDAKBggrBgEFBQcDBDAfBgNVHSME GDAWgBSWM9HmWBdbNHWKgVZk1b5I3qGPzzAdBgNVHQ4EFgQUFIRMHHEZDi127CpeMcPLPgCva8Aw DQYJKoZIhvcNAQELBQADggEBAJ3AlGS8SnTzvdaHc1sGWw7/pdUpzU59NLy5p827v5YbcxopZQPL v2q6YbcQTpQnxVa++htLqp+WyOb3PTzydNsHb5B++mR/jz9/+mJsa7yvtLkcDDcQrOfrZus6usQs oGwMj7g7D2OvJHuBtBRpqnKDRO4Wi7MHuGDfW6Wm+YJ3iibIl8OPWiqXlfOlkYxAaZcAAW84IeeM umNUQbWNMoBfa5qSHxe3ZWGNFZWnpTN7vp4rmu8Z1qrZGrSVc9IO3z+3/AD9GdYdelj8miFNczvR 0iiTaHiP8f5hiC8LUlKosTub10tap8TP0SCcuXM5RgS1q9QJ/zmwbg1zPbTTGkgxggJtMIICaQIB ATBrMFsxCzAJBgNVBAYTAkJFMRkwFwYDVQQKExBHbG9iYWxTaWduIG52LXNhMTEwLwYDVQQDEyhH bG9iYWxTaWduIEdDQyBSMyBQZXJzb25hbFNpZ24gMiBDQSAyMDIwAgwhRMMZKMaVhUl0DO8wDQYJ YIZIAWUDBAIBBQCggdQwLwYJKoZIhvcNAQkEMSIEILySixdWA9m9i0xtYgYjR35Bg1qxTcqg8J5S j9j78epbMBgGCSqGSIb3DQEJAzELBgkqhkiG9w0BBwEwHAYJKoZIhvcNAQkFMQ8XDTIxMTEwMjE2 NDQwMlowaQYJKoZIhvcNAQkPMVwwWjALBglghkgBZQMEASowCwYJYIZIAWUDBAEWMAsGCWCGSAFl AwQBAjAKBggqhkiG9w0DBzALBgkqhkiG9w0BAQowCwYJKoZIhvcNAQEHMAsGCWCGSAFlAwQCATAN BgkqhkiG9w0BAQEFAASCAQBiztCqr8RcU9KWqdWvywG+AuYLKn3unS3FB2/P2mONptjoTDkvuKky lSln8nRcgY/gGWBUf9OhquI4NA978HzfHfKAh06ObCOzDVNWvq+cWnZQbR/IGn0SFnJw7H1+4Ua3 hS+4AwgMPY17QAbHMnCezzCzRJWLgIy/cisvKYublM8oPRw60EngPfPhnrQhOGPUsAREEbehsg6T q/DWPO1P62IsBgbscXorrldWFH++rbFxIh/906mH51w6V4r04x2/vRAtNtqvlxwesgbMB3AONpui LUd6+aaDz0mDFuiGdcVI4HxjSl99TM5qzH9+iBiN8r5hR5zkFcnoilqncwkZ --0000000000003effb905cfd10038--