From mboxrd@z Thu Jan 1 00:00:00 1970 From: Stephen Warren Subject: Re: [PATCH v1 8/9] ARM: tegra: Enable UDC on AC100 Date: Thu, 6 Jul 2017 12:00:02 -0600 Message-ID: <33990cfa-f2f8-48ba-240b-ad088ba50bb5@wwwdotorg.org> References: <402c57db-a01b-33eb-28d4-7f4b372351f2@wwwdotorg.org> <32f880f8-a49c-8f29-fe26-f50cae31e215@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <32f880f8-a49c-8f29-fe26-f50cae31e215-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org> Content-Language: en-GB Sender: linux-tegra-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Dmitry Osipenko Cc: Thierry Reding , Felipe Balbi , Greg Kroah-Hartman , Peter Chen , Jonathan Hunter , Marc Dietrich , Nicolas Chauvet , linux-usb-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-tegra-u79uwXL29TY76Z2rM5mHXA@public.gmane.org List-Id: linux-tegra@vger.kernel.org On 07/06/2017 10:57 AM, Dmitry Osipenko wrote: > On 06.07.2017 19:38, Stephen Warren wrote: >> On 07/05/2017 11:19 AM, Dmitry Osipenko wrote: >>> Override the compatible string of the first USB controller to enable >>> device mode. >> >>> diff --git a/arch/arm/boot/dts/tegra20-paz00.dts >>> b/arch/arm/boot/dts/tegra20-paz00.dts >> >>> usb@c5000000 { >>> + compatible = "nvidia,tegra20-udc"; >>> status = "okay"; >>> + dr_mode = "otg"; >>> }; >> >> This port is the only external USB port on the AC100. > > Seems that's not true. http://elinux.org/Tegra/Boards/Toshiba_AC100 claims that > there are host and micro USB ports. You're right; I was getting this board confused with the Springbank variety of Seaboard, and when I looked at the mini USB port on the AC100 I thought it was something else. Given the physical connector on this USB port on the AC100, it's probably fine to convert it to device-mode only since I don't expect anyone has a USB OTG cable that has a mini size connector on the host end. It looks like this port is only enabled because the very first version of tegra-paz00.dts didn't explicitly disable the port, and when tegra20.dtsi was updated to disable all USB ports by default, tegra-paz00.dtsi was updated to enable the port so that the DT change didn't affect behaviour, which then left the port enabled explicitly albeit without much reason. So, once the dr_mode is fixed in this change, it's: Acked-by: Stephen Warren