From mboxrd@z Thu Jan 1 00:00:00 1970 From: Thomas Monjalon Subject: Re: [PATCH v8 3/3] ring: introduce new header file to support C11 memory model Date: Wed, 17 Jan 2018 10:09:31 +0100 Message-ID: <3399617.YsM4r4Ydhj@xps> References: <1516161831-28719-1-git-send-email-hejianet@gmail.com> <2512442.13rg75T8JE@xps> <23810751-921d-4e3a-bac6-95d251cc122f@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7Bit Cc: dev@dpdk.org, Jerin Jacob , Jianbo Liu , Jan Viktorin , Olivier Matz , konstantin.ananyev@intel.com, hemant.agrawal@nxp.com, Jia He To: Jia He Return-path: Received: from out1-smtp.messagingengine.com (out1-smtp.messagingengine.com [66.111.4.25]) by dpdk.org (Postfix) with ESMTP id 0B4871B025 for ; Wed, 17 Jan 2018 10:10:05 +0100 (CET) In-Reply-To: <23810751-921d-4e3a-bac6-95d251cc122f@gmail.com> List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 17/01/2018 09:47, Jia He: > > Hi Thomas > > On 1/17/2018 4:24 PM, Thomas Monjalon Wrote: > > 17/01/2018 05:03, Jia He: > >> To support C11 memory model barrier, 2 options are suggested by Jerin: > >> 1. use rte_smp_rmb > >> 2. use load_acquire/store_release(refer to [1]). > >> CONFIG_RTE_RING_USE_C11_MEM_MODEL is provided, and by default it is "n" > >> on any architectures so far. > > In previous patches, it was enabled for ARM. > > You decided to not enable it at all? > Sorry, maybe I misunderstand your previous mail. > >This config option should be added in the common file (as disabled). > Do you mean CONFIG_RTE_RING_USE_C11_MEM_MODEL=n in comm_base and > "y" in armv8 config? Yes, exactly