Re: [PATCH 1/5] xen/arm: smmuv1: Handle stream IDs more dynamically

[Rahul Singh <Rahul.Singh@arm.com>]

Hello Julien

> On 16 Mar 2021, at 3:16 pm, Julien Grall <julien@xen.org> wrote:
> 
> Hi Rahul,
> 
> On 09/03/2021 18:19, Rahul Singh wrote:
>> Backport commit 21174240e4f4439bb8ed6c116cdbdc03eba2126e
>> "iommu/arm-smmu: Handle stream IDs more dynamically" from the Linux
>> ernel.
>> This patch is the preparatory work to fix the stream match conflict
>> when two devices have the same stream-id.
>> Original commit message:
>> Rather than assuming fixed worst-case values for stream IDs and SMR
>> masks, keep track of whatever implemented bits the hardware actually
>> reports. This also obviates the slightly questionable validation of SMR
>> fields in isolation - rather than aborting the whole SMMU probe for a
>> hardware configuration which is still architecturally valid, we can
>> simply refuse masters later if they try to claim an unrepresentable ID
>> or mask (which almost certainly implies a DT error anyway).
> 
> For single backported and verbatim commit, it is common to keep the origin tags (I usually indent them) to show who is the original author of the patch.
> 
> Since 7936671da9fbf645d6bb207608f7b81c27f992de from Wei Chen as an example.

Thanks for reviewing the series. I will add the origin tags in the next version.

Regards,
Rahul
> 
> Cheers,
> 
> -- 
> Julien Grall