From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ozlabs.org (lists.ozlabs.org [IPv6:2401:3900:2:1::3]) (using TLSv1.2 with cipher ADH-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 40XP8373M1zF265 for ; Fri, 27 Apr 2018 16:25:55 +1000 (AEST) Received: from ozlabs.org (ozlabs.org [IPv6:2401:3900:2:1::2]) by bilbo.ozlabs.org (Postfix) with ESMTP id 40XP8366Wxz8tCx for ; Fri, 27 Apr 2018 16:25:55 +1000 (AEST) Received: from mx0a-001b2d01.pphosted.com (mx0a-001b2d01.pphosted.com [148.163.156.1]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 40XP831lYTz9s0w for ; Fri, 27 Apr 2018 16:25:55 +1000 (AEST) Received: from pps.filterd (m0098410.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.16.0.22/8.16.0.22) with SMTP id w3R6Pkgw101952 for ; Fri, 27 Apr 2018 02:25:53 -0400 Received: from e06smtp10.uk.ibm.com (e06smtp10.uk.ibm.com [195.75.94.106]) by mx0a-001b2d01.pphosted.com with ESMTP id 2hkvkdc6ng-1 (version=TLSv1.2 cipher=AES256-GCM-SHA384 bits=256 verify=NOT) for ; Fri, 27 Apr 2018 02:25:53 -0400 Received: from localhost by e06smtp10.uk.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Fri, 27 Apr 2018 07:25:51 +0100 Subject: Re: [PATCH v5 1/4] powerpc/fadump: un-register fadump on kexec path. To: Nicholas Piggin Cc: linuxppc-dev , Srikar Dronamraju , kernelfans@gmail.com, "Aneesh Kumar K.V" , Ananth Narayan , Hari Bathini , Nathan Fontenot , Anshuman Khandual References: <152474278043.5697.2553982145593952228.stgit@jupiter.in.ibm.com> <152474292369.5697.4957552670306451723.stgit@jupiter.in.ibm.com> <20180426225757.2a8552e0@roar.ozlabs.ibm.com> <20180426234049.3f7909df@roar.ozlabs.ibm.com> From: Mahesh Jagannath Salgaonkar Date: Fri, 27 Apr 2018 11:55:44 +0530 MIME-Version: 1.0 In-Reply-To: <20180426234049.3f7909df@roar.ozlabs.ibm.com> Content-Type: text/plain; charset=utf-8 Message-Id: <33ab500a-48db-6d35-e103-3bc7b58e2185@linux.vnet.ibm.com> List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , On 04/26/2018 07:10 PM, Nicholas Piggin wrote: > On Thu, 26 Apr 2018 18:35:10 +0530 > Mahesh Jagannath Salgaonkar wrote: > >> On 04/26/2018 06:28 PM, Nicholas Piggin wrote: >>> On Thu, 26 Apr 2018 17:12:03 +0530 >>> Mahesh J Salgaonkar wrote: >>> >>>> From: Mahesh Salgaonkar >>>> >>>> otherwise the fadump registration in new kexec-ed kernel complains that >>>> fadump is already registered. This makes new kernel to continue using >>>> fadump registered by previous kernel which may lead to invalid vmcore >>>> generation. Hence this patch fixes this issue by un-registering fadump >>>> in fadump_cleanup() which is called during kexec path so that new kernel >>>> can register fadump with new valid values. >>> >>> I assume this series is for 4.17, but it might be good to get this one >>> into the 4.16 fixes branch? Should it go to stable kernels? >> >> You are right. Should I send it out as separate patch ? > > Yes I think so. Done posted it separately (http://patchwork.ozlabs.org/patch/905508/) Ignore this patch from this series. Thanks, -Mahesh.