From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jyri Sarha Subject: Re: [PATCH 1/7] drm/tilcdc: don't use volatile with iowrite64 Date: Mon, 26 Jun 2017 11:54:25 +0300 Message-ID: <33b6c00f-1982-69dd-86b2-107266d238d0@ti.com> References: <20170622164817.25515-1-logang@deltatee.com> <20170622164817.25515-2-logang@deltatee.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Cc: Greg Kroah-Hartman , Tomi Valkeinen , Arnd Bergmann , Stephen Bates To: Logan Gunthorpe , , , , , , , Return-path: In-Reply-To: <20170622164817.25515-2-logang@deltatee.com> Content-Language: en-GB List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" List-Id: linux-crypto.vger.kernel.org T24gMDYvMjIvMTcgMTk6NDgsIExvZ2FuIEd1bnRob3JwZSB3cm90ZToKPiBUaGlzIGlzIGEgcHJl cCBwYXRjaCBmb3IgYWRkaW5nIGEgdW5pdmVyc2FsIGlvd3JpdGU2NC4KPiAKPiBUaGUgcGF0Y2gg aXMgdG8gcHJldmVudCBjb21waWxlciB3YXJuaW5ncyB3aGVuIHdlIGFkZCBpb3dyaXRlNjQgdGhh dAo+IHdvdWxkIG9jY3VyIGJlY2F1c2UgdGhlcmUgaXMgYW4gdW5uZWNlc3Nhcnkgdm9sYXRpbGUg aW4gdGhpcyBkcml2ZXIuCj4gCj4gU2lnbmVkLW9mZi1ieTogTG9nYW4gR3VudGhvcnBlIDxsb2dh bmdAZGVsdGF0ZWUuY29tPgo+IENjOiBKeXJpIFNhcmhhIDxqc2FyaGFAdGkuY29tPgo+IENjOiBU b21pIFZhbGtlaW5lbiA8dG9taS52YWxrZWluZW5AdGkuY29tPgo+IENjOiBEYXZpZCBBaXJsaWUg PGFpcmxpZWRAbGludXguaWU+CgpBY2tlZC1ieTogSnlyaSBTYXJoYSA8anNhcmhhQHRpLmNvbT4K Cj4gLS0tCj4gIGRyaXZlcnMvZ3B1L2RybS90aWxjZGMvdGlsY2RjX3JlZ3MuaCB8IDQgKystLQo+ ICAxIGZpbGUgY2hhbmdlZCwgMiBpbnNlcnRpb25zKCspLCAyIGRlbGV0aW9ucygtKQo+IAo+IGRp ZmYgLS1naXQgYS9kcml2ZXJzL2dwdS9kcm0vdGlsY2RjL3RpbGNkY19yZWdzLmggYi9kcml2ZXJz L2dwdS9kcm0vdGlsY2RjL3RpbGNkY19yZWdzLmgKPiBpbmRleCA5ZDUyOGMwYTY3YTQuLmU5Y2U3 MjU2OThhOSAxMDA2NDQKPiAtLS0gYS9kcml2ZXJzL2dwdS9kcm0vdGlsY2RjL3RpbGNkY19yZWdz LmgKPiArKysgYi9kcml2ZXJzL2dwdS9kcm0vdGlsY2RjL3RpbGNkY19yZWdzLmgKPiBAQCAtMTMx LDE0ICsxMzEsMTQgQEAgc3RhdGljIGlubGluZSB2b2lkIHRpbGNkY193cml0ZShzdHJ1Y3QgZHJt X2RldmljZSAqZGV2LCB1MzIgcmVnLCB1MzIgZGF0YSkKPiAgc3RhdGljIGlubGluZSB2b2lkIHRp bGNkY193cml0ZTY0KHN0cnVjdCBkcm1fZGV2aWNlICpkZXYsIHUzMiByZWcsIHU2NCBkYXRhKQo+ ICB7Cj4gIAlzdHJ1Y3QgdGlsY2RjX2RybV9wcml2YXRlICpwcml2ID0gZGV2LT5kZXZfcHJpdmF0 ZTsKPiAtCXZvbGF0aWxlIHZvaWQgX19pb21lbSAqYWRkciA9IHByaXYtPm1taW8gKyByZWc7Cj4g Kwl2b2lkIF9faW9tZW0gKmFkZHIgPSBwcml2LT5tbWlvICsgcmVnOwo+ICAKPiAgI2lmZGVmIGlv d3JpdGU2NAo+ICAJaW93cml0ZTY0KGRhdGEsIGFkZHIpOwo+ICAjZWxzZQo+ICAJX19pb3dtYigp Owo+ICAJLyogVGhpcyBjb21waWxlcyB0byBzdHJkICg9NjQtYml0IHdyaXRlKSBvbiBBUk03ICov Cj4gLQkqKHZvbGF0aWxlIHU2NCBfX2ZvcmNlICopYWRkciA9IF9fY3B1X3RvX2xlNjQoZGF0YSk7 Cj4gKwkqKHU2NCBfX2ZvcmNlICopYWRkciA9IF9fY3B1X3RvX2xlNjQoZGF0YSk7Cj4gICNlbmRp Zgo+ICB9Cj4gIAo+IAoKX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX18KZHJpLWRldmVsIG1haWxpbmcgbGlzdApkcmktZGV2ZWxAbGlzdHMuZnJlZWRlc2t0b3Au b3JnCmh0dHBzOi8vbGlzdHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vZHJpLWRl dmVsCg== From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751456AbdFZIyz (ORCPT ); Mon, 26 Jun 2017 04:54:55 -0400 Received: from lelnx194.ext.ti.com ([198.47.27.80]:39759 "EHLO lelnx194.ext.ti.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751344AbdFZIyw (ORCPT ); Mon, 26 Jun 2017 04:54:52 -0400 Subject: Re: [PATCH 1/7] drm/tilcdc: don't use volatile with iowrite64 To: Logan Gunthorpe , , , , , , , CC: Arnd Bergmann , Greg Kroah-Hartman , Stephen Bates , Tomi Valkeinen , David Airlie References: <20170622164817.25515-1-logang@deltatee.com> <20170622164817.25515-2-logang@deltatee.com> From: Jyri Sarha Message-ID: <33b6c00f-1982-69dd-86b2-107266d238d0@ti.com> Date: Mon, 26 Jun 2017 11:54:25 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.1.1 MIME-Version: 1.0 In-Reply-To: <20170622164817.25515-2-logang@deltatee.com> Content-Type: text/plain; charset="utf-8" Content-Language: en-GB Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 06/22/17 19:48, Logan Gunthorpe wrote: > This is a prep patch for adding a universal iowrite64. > > The patch is to prevent compiler warnings when we add iowrite64 that > would occur because there is an unnecessary volatile in this driver. > > Signed-off-by: Logan Gunthorpe > Cc: Jyri Sarha > Cc: Tomi Valkeinen > Cc: David Airlie Acked-by: Jyri Sarha > --- > drivers/gpu/drm/tilcdc/tilcdc_regs.h | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/gpu/drm/tilcdc/tilcdc_regs.h b/drivers/gpu/drm/tilcdc/tilcdc_regs.h > index 9d528c0a67a4..e9ce725698a9 100644 > --- a/drivers/gpu/drm/tilcdc/tilcdc_regs.h > +++ b/drivers/gpu/drm/tilcdc/tilcdc_regs.h > @@ -131,14 +131,14 @@ static inline void tilcdc_write(struct drm_device *dev, u32 reg, u32 data) > static inline void tilcdc_write64(struct drm_device *dev, u32 reg, u64 data) > { > struct tilcdc_drm_private *priv = dev->dev_private; > - volatile void __iomem *addr = priv->mmio + reg; > + void __iomem *addr = priv->mmio + reg; > > #ifdef iowrite64 > iowrite64(data, addr); > #else > __iowmb(); > /* This compiles to strd (=64-bit write) on ARM7 */ > - *(volatile u64 __force *)addr = __cpu_to_le64(data); > + *(u64 __force *)addr = __cpu_to_le64(data); > #endif > } > > From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jyri Sarha Subject: Re: [PATCH 1/7] drm/tilcdc: don't use volatile with iowrite64 Date: Mon, 26 Jun 2017 11:54:25 +0300 Message-ID: <33b6c00f-1982-69dd-86b2-107266d238d0@ti.com> References: <20170622164817.25515-1-logang@deltatee.com> <20170622164817.25515-2-logang@deltatee.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: In-Reply-To: <20170622164817.25515-2-logang@deltatee.com> Content-Language: en-GB List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Logan Gunthorpe , linux-kernel@vger.kernel.org, linux-arch@vger.kernel.org, linux-ntb@googlegroups.com, linux-alpha@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, linux-crypto@vger.kernel.org, dri-devel@lists.freedesktop.org Cc: Greg Kroah-Hartman , Tomi Valkeinen , Arnd Bergmann , Stephen Bates List-Id: linux-arch.vger.kernel.org T24gMDYvMjIvMTcgMTk6NDgsIExvZ2FuIEd1bnRob3JwZSB3cm90ZToKPiBUaGlzIGlzIGEgcHJl cCBwYXRjaCBmb3IgYWRkaW5nIGEgdW5pdmVyc2FsIGlvd3JpdGU2NC4KPiAKPiBUaGUgcGF0Y2gg aXMgdG8gcHJldmVudCBjb21waWxlciB3YXJuaW5ncyB3aGVuIHdlIGFkZCBpb3dyaXRlNjQgdGhh dAo+IHdvdWxkIG9jY3VyIGJlY2F1c2UgdGhlcmUgaXMgYW4gdW5uZWNlc3Nhcnkgdm9sYXRpbGUg aW4gdGhpcyBkcml2ZXIuCj4gCj4gU2lnbmVkLW9mZi1ieTogTG9nYW4gR3VudGhvcnBlIDxsb2dh bmdAZGVsdGF0ZWUuY29tPgo+IENjOiBKeXJpIFNhcmhhIDxqc2FyaGFAdGkuY29tPgo+IENjOiBU b21pIFZhbGtlaW5lbiA8dG9taS52YWxrZWluZW5AdGkuY29tPgo+IENjOiBEYXZpZCBBaXJsaWUg PGFpcmxpZWRAbGludXguaWU+CgpBY2tlZC1ieTogSnlyaSBTYXJoYSA8anNhcmhhQHRpLmNvbT4K Cj4gLS0tCj4gIGRyaXZlcnMvZ3B1L2RybS90aWxjZGMvdGlsY2RjX3JlZ3MuaCB8IDQgKystLQo+ ICAxIGZpbGUgY2hhbmdlZCwgMiBpbnNlcnRpb25zKCspLCAyIGRlbGV0aW9ucygtKQo+IAo+IGRp ZmYgLS1naXQgYS9kcml2ZXJzL2dwdS9kcm0vdGlsY2RjL3RpbGNkY19yZWdzLmggYi9kcml2ZXJz L2dwdS9kcm0vdGlsY2RjL3RpbGNkY19yZWdzLmgKPiBpbmRleCA5ZDUyOGMwYTY3YTQuLmU5Y2U3 MjU2OThhOSAxMDA2NDQKPiAtLS0gYS9kcml2ZXJzL2dwdS9kcm0vdGlsY2RjL3RpbGNkY19yZWdz LmgKPiArKysgYi9kcml2ZXJzL2dwdS9kcm0vdGlsY2RjL3RpbGNkY19yZWdzLmgKPiBAQCAtMTMx LDE0ICsxMzEsMTQgQEAgc3RhdGljIGlubGluZSB2b2lkIHRpbGNkY193cml0ZShzdHJ1Y3QgZHJt X2RldmljZSAqZGV2LCB1MzIgcmVnLCB1MzIgZGF0YSkKPiAgc3RhdGljIGlubGluZSB2b2lkIHRp bGNkY193cml0ZTY0KHN0cnVjdCBkcm1fZGV2aWNlICpkZXYsIHUzMiByZWcsIHU2NCBkYXRhKQo+ ICB7Cj4gIAlzdHJ1Y3QgdGlsY2RjX2RybV9wcml2YXRlICpwcml2ID0gZGV2LT5kZXZfcHJpdmF0 ZTsKPiAtCXZvbGF0aWxlIHZvaWQgX19pb21lbSAqYWRkciA9IHByaXYtPm1taW8gKyByZWc7Cj4g Kwl2b2lkIF9faW9tZW0gKmFkZHIgPSBwcml2LT5tbWlvICsgcmVnOwo+ICAKPiAgI2lmZGVmIGlv d3JpdGU2NAo+ICAJaW93cml0ZTY0KGRhdGEsIGFkZHIpOwo+ICAjZWxzZQo+ICAJX19pb3dtYigp Owo+ICAJLyogVGhpcyBjb21waWxlcyB0byBzdHJkICg9NjQtYml0IHdyaXRlKSBvbiBBUk03ICov Cj4gLQkqKHZvbGF0aWxlIHU2NCBfX2ZvcmNlICopYWRkciA9IF9fY3B1X3RvX2xlNjQoZGF0YSk7 Cj4gKwkqKHU2NCBfX2ZvcmNlICopYWRkciA9IF9fY3B1X3RvX2xlNjQoZGF0YSk7Cj4gICNlbmRp Zgo+ICB9Cj4gIAo+IAoKX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX18KZHJpLWRldmVsIG1haWxpbmcgbGlzdApkcmktZGV2ZWxAbGlzdHMuZnJlZWRlc2t0b3Au b3JnCmh0dHBzOi8vbGlzdHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vZHJpLWRl dmVsCg== From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from lelnx194.ext.ti.com (lelnx194.ext.ti.com. [198.47.27.80]) by gmr-mx.google.com with ESMTPS id h77si312507itb.0.2017.06.26.01.54.43 for (version=TLS1 cipher=AES128-SHA bits=128/128); Mon, 26 Jun 2017 01:54:43 -0700 (PDT) Subject: Re: [PATCH 1/7] drm/tilcdc: don't use volatile with iowrite64 References: <20170622164817.25515-1-logang@deltatee.com> <20170622164817.25515-2-logang@deltatee.com> From: Jyri Sarha Message-ID: <33b6c00f-1982-69dd-86b2-107266d238d0@ti.com> Date: Mon, 26 Jun 2017 11:54:25 +0300 MIME-Version: 1.0 In-Reply-To: <20170622164817.25515-2-logang@deltatee.com> Content-Type: text/plain; charset="utf-8" Content-Language: en-GB Content-Transfer-Encoding: 7bit To: Logan Gunthorpe , linux-kernel@vger.kernel.org, linux-arch@vger.kernel.org, linux-ntb@googlegroups.com, linux-alpha@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, linux-crypto@vger.kernel.org, dri-devel@lists.freedesktop.org Cc: Arnd Bergmann , Greg Kroah-Hartman , Stephen Bates , Tomi Valkeinen , David Airlie List-ID: On 06/22/17 19:48, Logan Gunthorpe wrote: > This is a prep patch for adding a universal iowrite64. > > The patch is to prevent compiler warnings when we add iowrite64 that > would occur because there is an unnecessary volatile in this driver. > > Signed-off-by: Logan Gunthorpe > Cc: Jyri Sarha > Cc: Tomi Valkeinen > Cc: David Airlie Acked-by: Jyri Sarha > --- > drivers/gpu/drm/tilcdc/tilcdc_regs.h | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/gpu/drm/tilcdc/tilcdc_regs.h b/drivers/gpu/drm/tilcdc/tilcdc_regs.h > index 9d528c0a67a4..e9ce725698a9 100644 > --- a/drivers/gpu/drm/tilcdc/tilcdc_regs.h > +++ b/drivers/gpu/drm/tilcdc/tilcdc_regs.h > @@ -131,14 +131,14 @@ static inline void tilcdc_write(struct drm_device *dev, u32 reg, u32 data) > static inline void tilcdc_write64(struct drm_device *dev, u32 reg, u64 data) > { > struct tilcdc_drm_private *priv = dev->dev_private; > - volatile void __iomem *addr = priv->mmio + reg; > + void __iomem *addr = priv->mmio + reg; > > #ifdef iowrite64 > iowrite64(data, addr); > #else > __iowmb(); > /* This compiles to strd (=64-bit write) on ARM7 */ > - *(volatile u64 __force *)addr = __cpu_to_le64(data); > + *(u64 __force *)addr = __cpu_to_le64(data); > #endif > } > >