All of lore.kernel.org
 help / color / mirror / Atom feed
From: Qu Wenruo <quwenruo.btrfs@gmx.com>
To: Jani Partanen <jiipee@sotapeli.fi>, Song Liu <song@kernel.org>
Cc: NeilBrown <neilb@suse.de>, Doug Ledford <dledford@redhat.com>,
	Wols Lists <antlists@youngman.org.uk>,
	linux-raid <linux-raid@vger.kernel.org>,
	"linux-block@vger.kernel.org" <linux-block@vger.kernel.org>
Subject: Re: About the md-bitmap behavior
Date: Fri, 24 Jun 2022 09:35:50 +0800	[thread overview]
Message-ID: <33b6c180-2252-a444-3204-18cdbd02ff6b@gmx.com> (raw)
In-Reply-To: <8e682742-60b0-1820-7887-952b0963c783@sotapeli.fi>



On 2022/6/24 08:55, Jani Partanen wrote:
>
>
> Qu Wenruo kirjoitti 23/06/2022 klo 7.52:
>> That makes sense, but that also means the extent allocator needs extra
>> info, not just which space is available.
>>
>> And there would make ENOSPC handling even more challenging, what if we
>> have no space left but only partially written stripes?
>>
>> There are some ideas, like extra layer for RAID56 to do extra mapping
>> between logical address to physical address, but I'm not yet confident
>> if we will see new (and even more complex) challenges going that path.
>
> Isn't there already in btrfs system in place for ENOSPC situation?

It's not perfect, we still have some of reports of ENOSPC in the most
inconvenient timing from time to time.

> You
> just add some space temporaly?

That is not a valid solution, not even a valid workaround.

> Thats what I remember when I was playing
> around with different situations with btrfs.

The situation is improving a lot recently, but it's still far from
write-in-place fs level.

> For me bigger issue with btrfs raid56 is the fact that scrub is very
> very slow. That should be one of the top priority to solve.

In fact, that's caused by the way how we do scrub.
We start a scrub for each device, this is mostly fine for regular
profiles, but a big no no to RAID56.

Since scrub a full stripe will read all data/P/Q from disk, it makes no
sense to scrub a full stripe multiple times.

That would be a target during the write-intent bitmap, as we will rely
on scrub to re-sync the data at recovery time.


After that, I'll try to create a better, RAID56 friendly interface for
scrub ioctl.

Thanks,
Qu

>
> // JiiPee

      reply	other threads:[~2022-06-24  1:36 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-06-20  7:29 About the md-bitmap behavior Qu Wenruo
2022-06-20  7:48 ` Wols Lists
2022-06-20  7:56   ` Qu Wenruo
2022-06-20  9:56     ` Wols Lists
2022-06-22  2:15       ` Doug Ledford
2022-06-22  2:37         ` Qu Wenruo
2022-06-22 22:32           ` NeilBrown
2022-06-22 23:00             ` Song Liu
2022-06-23  0:53               ` Qu Wenruo
2022-06-23  0:39             ` Qu Wenruo
2022-06-23  3:32               ` Song Liu
2022-06-23  4:52                 ` Qu Wenruo
2022-06-24  0:55                   ` Jani Partanen
2022-06-24  1:35                     ` Qu Wenruo [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=33b6c180-2252-a444-3204-18cdbd02ff6b@gmx.com \
    --to=quwenruo.btrfs@gmx.com \
    --cc=antlists@youngman.org.uk \
    --cc=dledford@redhat.com \
    --cc=jiipee@sotapeli.fi \
    --cc=linux-block@vger.kernel.org \
    --cc=linux-raid@vger.kernel.org \
    --cc=neilb@suse.de \
    --cc=song@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.