From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id A017BC6FD1C for ; Fri, 24 Mar 2023 10:12:22 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231661AbjCXKMV (ORCPT ); Fri, 24 Mar 2023 06:12:21 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:44726 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231668AbjCXKMI (ORCPT ); Fri, 24 Mar 2023 06:12:08 -0400 Received: from mail-wm1-x32d.google.com (mail-wm1-x32d.google.com [IPv6:2a00:1450:4864:20::32d]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 405DB26C1D for ; Fri, 24 Mar 2023 03:12:06 -0700 (PDT) Received: by mail-wm1-x32d.google.com with SMTP id t17-20020a05600c451100b003edc906aeeaso2706284wmo.1 for ; Fri, 24 Mar 2023 03:12:06 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1679652724; h=content-transfer-encoding:in-reply-to:organization:references:cc:to :content-language:subject:reply-to:from:user-agent:mime-version:date :message-id:from:to:cc:subject:date:message-id:reply-to; bh=SPH4mUwrMOscuf6tp1URuXqKk1vAT8I56zMeO2kHP6A=; b=ScVo7VrB621s3bVxksud99veEU0e+ZB6wdSl+A6LXnVuLZeGxas+hx64ic1+FLbroR 6wKIVSg0P3gcyQSfUWCTF6zYQvnYz6aX+8W5oCmLsG2+AN5j6NkCi9oiAiBB5Zs/AqdR yAXRfHpB3aegqKdqFO0wPNq6Jxz0Lojh34ih43NcqeDEWl64NEyVl8wbMD+v01V5+Xss vKR2P1UsF+jtD4oicwCpN8PcHW88ScxZRuCbQIlzkNp16oM30Yqnq+l1rrygpK2zqnCm Eht9f8cUjFigkScfypH0XvzPxFP2t23KWxwXyDR1ZYfoUIbYpk7LKW5Hao4oEJ83ib1n uQPg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1679652724; h=content-transfer-encoding:in-reply-to:organization:references:cc:to :content-language:subject:reply-to:from:user-agent:mime-version:date :message-id:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=SPH4mUwrMOscuf6tp1URuXqKk1vAT8I56zMeO2kHP6A=; b=wsPmxRjKinS48j8989hMD6NBnNOz2OzgJE3TXCGIYvev8YDRw9mxru0NheCAM7ka4I ll92UslM2dnuoHJyqAmA2LqNykq6o6qeNhmdMVspj1omHLssdMcXKBzeFChhXkFg/jM3 m6vhrtefngceA/qbQqWbvcpcSxxkTn4LuBQ+wLu9HNTRsvNp5iK39EzlYlmplGj+V3d3 IS8DdE3bqHxRCzGG44bJ+Rh/VSxYlN5mhWrCSawojThzMBg2pK972VqJ8IR4zEGTcNnH HsaKA9YNFLQlbQhhlz2DyS+LKXnyTJudtgg9aQ5dWaSPvrQmXuJw/NpDuqUEk8zRi6nN TM/g== X-Gm-Message-State: AO0yUKVG9bc5d0d/j72I4P6g+U8fl96IsUzQhvW4HoU5S+UgMpDSMCn2 5AiZKNcobby3jdyHgirHQzN2/g== X-Google-Smtp-Source: AK7set8IR6Q6Kilnl52WGIRlbWm3xbvS1BES24oina4LDglaBRJJ/DsWqT5cs2NM3gcARp+LzcMOdQ== X-Received: by 2002:a05:600c:d5:b0:3ed:2eb5:c2dd with SMTP id u21-20020a05600c00d500b003ed2eb5c2ddmr1862205wmm.39.1679652724674; Fri, 24 Mar 2023 03:12:04 -0700 (PDT) Received: from ?IPV6:2a01:e0a:982:cbb0:213f:a579:70af:e4a0? ([2a01:e0a:982:cbb0:213f:a579:70af:e4a0]) by smtp.gmail.com with ESMTPSA id u10-20020a05600c19ca00b003ee5fa61f45sm4630286wmq.3.2023.03.24.03.12.03 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 24 Mar 2023 03:12:04 -0700 (PDT) Message-ID: <33c039ff-2702-e058-262a-829199fefa21@linaro.org> Date: Fri, 24 Mar 2023 11:12:03 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.8.0 From: neil.armstrong@linaro.org Reply-To: neil.armstrong@linaro.org Subject: Re: [PATCH] soc: amlogic: meson-pwrc: Use dev_err_probe() Content-Language: en-US To: ye.xingchen@zte.com.cn Cc: khilman@baylibre.com, jbrunet@baylibre.com, martin.blumenstingl@googlemail.com, linux-arm-kernel@lists.infradead.org, linux-amlogic@lists.infradead.org, linux-kernel@vger.kernel.org References: <202303241016261854322@zte.com.cn> Organization: Linaro Developer Services In-Reply-To: <202303241016261854322@zte.com.cn> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 24/03/2023 03:16, ye.xingchen@zte.com.cn wrote: > From: Ye Xingchen > > Replace the open-code with dev_err_probe() to simplify the code. > > Signed-off-by: Ye Xingchen > --- > drivers/soc/amlogic/meson-gx-pwrc-vpu.c | 8 +++----- > 1 file changed, 3 insertions(+), 5 deletions(-) > > diff --git a/drivers/soc/amlogic/meson-gx-pwrc-vpu.c b/drivers/soc/amlogic/meson-gx-pwrc-vpu.c > index 312fd9afccb0..5d4f12800d93 100644 > --- a/drivers/soc/amlogic/meson-gx-pwrc-vpu.c > +++ b/drivers/soc/amlogic/meson-gx-pwrc-vpu.c > @@ -308,11 +308,9 @@ static int meson_gx_pwrc_vpu_probe(struct platform_device *pdev) > } > > rstc = devm_reset_control_array_get_exclusive(&pdev->dev); > - if (IS_ERR(rstc)) { > - if (PTR_ERR(rstc) != -EPROBE_DEFER) > - dev_err(&pdev->dev, "failed to get reset lines\n"); > - return PTR_ERR(rstc); > - } > + if (IS_ERR(rstc)) > + return dev_err_probe(&pdev->dev, PTR_ERR(rstc), > + "failed to get reset lines\n"); > > vpu_clk = devm_clk_get(&pdev->dev, "vpu"); > if (IS_ERR(vpu_clk)) { Reviewed-by: Neil Armstrong From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 753F4C6FD20 for ; Fri, 24 Mar 2023 10:13:04 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Content-Type: Content-Transfer-Encoding:Reply-To:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:References:Cc:To:Subject: From:MIME-Version:Date:Message-ID:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=9PIes3MjaiyQVwdojr1jOdFVvu3GptWOVb0YtnYiwSI=; b=CGIMrfnadTBYHQk8vrorH/oKDe F4bBDhUPE0OS1rw/2ptCvYz6+qCImAFHWZDOfhJIy1WBgA4xT3teSJPdfN093b9ubjODAnWccaEEY 9EB3OM4uBdidSh8h5ndYBl2gj1paP0PoBIqC21SK1H7Jup9WpnYbEl63LM5Ng+7Fx2kC+VpoUDOZK hoRgqt/7bFTCqfV4Vf+bqttkUq+rTofbdYYOx6S9lLKZBdinTbWHF9j5GIWlWl33y6eJ+VozbKgO5 4fi53TFuWwVnZLndpmiWDHyf86XfFtjQE9PiR9f35Pn5O4n+ayRYGtL0GvTYfxppr9EJSt/UXaN2r DQ1907lQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1pfeP9-0047Wl-2n; Fri, 24 Mar 2023 10:12:15 +0000 Received: from mail-wm1-x32f.google.com ([2a00:1450:4864:20::32f]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1pfeP6-0047TM-2m for linux-arm-kernel@lists.infradead.org; Fri, 24 Mar 2023 10:12:14 +0000 Received: by mail-wm1-x32f.google.com with SMTP id v20-20020a05600c471400b003ed8826253aso2777959wmo.0 for ; Fri, 24 Mar 2023 03:12:05 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1679652724; h=content-transfer-encoding:in-reply-to:organization:references:cc:to :content-language:subject:reply-to:from:user-agent:mime-version:date :message-id:from:to:cc:subject:date:message-id:reply-to; bh=SPH4mUwrMOscuf6tp1URuXqKk1vAT8I56zMeO2kHP6A=; b=ScVo7VrB621s3bVxksud99veEU0e+ZB6wdSl+A6LXnVuLZeGxas+hx64ic1+FLbroR 6wKIVSg0P3gcyQSfUWCTF6zYQvnYz6aX+8W5oCmLsG2+AN5j6NkCi9oiAiBB5Zs/AqdR yAXRfHpB3aegqKdqFO0wPNq6Jxz0Lojh34ih43NcqeDEWl64NEyVl8wbMD+v01V5+Xss vKR2P1UsF+jtD4oicwCpN8PcHW88ScxZRuCbQIlzkNp16oM30Yqnq+l1rrygpK2zqnCm Eht9f8cUjFigkScfypH0XvzPxFP2t23KWxwXyDR1ZYfoUIbYpk7LKW5Hao4oEJ83ib1n uQPg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1679652724; h=content-transfer-encoding:in-reply-to:organization:references:cc:to :content-language:subject:reply-to:from:user-agent:mime-version:date :message-id:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=SPH4mUwrMOscuf6tp1URuXqKk1vAT8I56zMeO2kHP6A=; b=5k9dhWWzYC2bFKGXCSYBjva4oBN7323OyGkIzHXZyosXS8uRe6fhAGxhQh2IVKD6OB sf2GH5PVe0kl2pPVxx5SKrbMOMkEqDxZ1yX1JLAszZ3060acoGmS3j0u7dizg36QAz9w tRE04BSK8GoM2BKoBaYjh8OghOXWnBjNnM6PAwyoohRvYsCciRE7KVEC2iR39FxLKPd3 HFZ39ZhjLGdfTfjBkI39p1erUp74UOEEyxh9Bpaduu004+wfimvQBwIbICdiY+u3SKeV OJ6NdEkK87p13/rYsS5P+ZVpIVqm4ogFZWv6eVNOT31QNZZA3MrZ8/XeI66llDbDi2iv K3Jg== X-Gm-Message-State: AO0yUKWGSrLWMAGmBEkCgXfpdv6Byk5Qtlx6kfkLk69SGs5L13Oc7nOS K5VX/Q5Kg02YAv+S0hbwn71Ogg== X-Google-Smtp-Source: AK7set8IR6Q6Kilnl52WGIRlbWm3xbvS1BES24oina4LDglaBRJJ/DsWqT5cs2NM3gcARp+LzcMOdQ== X-Received: by 2002:a05:600c:d5:b0:3ed:2eb5:c2dd with SMTP id u21-20020a05600c00d500b003ed2eb5c2ddmr1862205wmm.39.1679652724674; Fri, 24 Mar 2023 03:12:04 -0700 (PDT) Received: from ?IPV6:2a01:e0a:982:cbb0:213f:a579:70af:e4a0? ([2a01:e0a:982:cbb0:213f:a579:70af:e4a0]) by smtp.gmail.com with ESMTPSA id u10-20020a05600c19ca00b003ee5fa61f45sm4630286wmq.3.2023.03.24.03.12.03 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 24 Mar 2023 03:12:04 -0700 (PDT) Message-ID: <33c039ff-2702-e058-262a-829199fefa21@linaro.org> Date: Fri, 24 Mar 2023 11:12:03 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.8.0 From: neil.armstrong@linaro.org Subject: Re: [PATCH] soc: amlogic: meson-pwrc: Use dev_err_probe() Content-Language: en-US To: ye.xingchen@zte.com.cn Cc: khilman@baylibre.com, jbrunet@baylibre.com, martin.blumenstingl@googlemail.com, linux-arm-kernel@lists.infradead.org, linux-amlogic@lists.infradead.org, linux-kernel@vger.kernel.org References: <202303241016261854322@zte.com.cn> Organization: Linaro Developer Services In-Reply-To: <202303241016261854322@zte.com.cn> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230324_031212_900845_BF45D26A X-CRM114-Status: GOOD ( 17.09 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: neil.armstrong@linaro.org Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 24/03/2023 03:16, ye.xingchen@zte.com.cn wrote: > From: Ye Xingchen > > Replace the open-code with dev_err_probe() to simplify the code. > > Signed-off-by: Ye Xingchen > --- > drivers/soc/amlogic/meson-gx-pwrc-vpu.c | 8 +++----- > 1 file changed, 3 insertions(+), 5 deletions(-) > > diff --git a/drivers/soc/amlogic/meson-gx-pwrc-vpu.c b/drivers/soc/amlogic/meson-gx-pwrc-vpu.c > index 312fd9afccb0..5d4f12800d93 100644 > --- a/drivers/soc/amlogic/meson-gx-pwrc-vpu.c > +++ b/drivers/soc/amlogic/meson-gx-pwrc-vpu.c > @@ -308,11 +308,9 @@ static int meson_gx_pwrc_vpu_probe(struct platform_device *pdev) > } > > rstc = devm_reset_control_array_get_exclusive(&pdev->dev); > - if (IS_ERR(rstc)) { > - if (PTR_ERR(rstc) != -EPROBE_DEFER) > - dev_err(&pdev->dev, "failed to get reset lines\n"); > - return PTR_ERR(rstc); > - } > + if (IS_ERR(rstc)) > + return dev_err_probe(&pdev->dev, PTR_ERR(rstc), > + "failed to get reset lines\n"); > > vpu_clk = devm_clk_get(&pdev->dev, "vpu"); > if (IS_ERR(vpu_clk)) { Reviewed-by: Neil Armstrong _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 81600C6FD1C for ; Fri, 24 Mar 2023 10:12:17 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Content-Type: Content-Transfer-Encoding:Reply-To:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:References:Cc:To:Subject: From:MIME-Version:Date:Message-ID:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=NahUavweR9ej3Kw2kQwreBUJCfKeyZhSTx7JBDmQlRc=; b=vnb9ZPsU95Xp6ckRRFeVDmIUlu i/1vEhmlE/CHPX9iHR7ewIMKNtHavfVv/6S1qZOS5H4FYSmORQ8SuXVrhzwKeKo1A//NAXZaDCwEL L18yGwc87Hu0+n97/C/v0r6o8JBO3ZpsmU8blZxCrVRQ/JQ2biPjZrOrfI3oqv/GcXBvG9s5PC8z0 02KXu7XPkAnRD9988ZohAok4DOwixEVX7Tt1LW9HYAkD1PHO7HgpXbKvJ9jU+hyVf2f9CsqoBdoaH qPCCSvdoXPUI9kKQ5V+rL1IJej9iLD1k3KQEl9x2RbMfFbQhWvVOvjw4uEv6JYQYraSb1rw7y7wxe xJxjrg4g==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1pfeP2-0047UE-0a; Fri, 24 Mar 2023 10:12:08 +0000 Received: from mail-wm1-x32e.google.com ([2a00:1450:4864:20::32e]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1pfeP0-0047TN-0B for linux-amlogic@lists.infradead.org; Fri, 24 Mar 2023 10:12:07 +0000 Received: by mail-wm1-x32e.google.com with SMTP id o40-20020a05600c512800b003eddedc47aeso2811747wms.3 for ; Fri, 24 Mar 2023 03:12:05 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1679652724; h=content-transfer-encoding:in-reply-to:organization:references:cc:to :content-language:subject:reply-to:from:user-agent:mime-version:date :message-id:from:to:cc:subject:date:message-id:reply-to; bh=SPH4mUwrMOscuf6tp1URuXqKk1vAT8I56zMeO2kHP6A=; b=ScVo7VrB621s3bVxksud99veEU0e+ZB6wdSl+A6LXnVuLZeGxas+hx64ic1+FLbroR 6wKIVSg0P3gcyQSfUWCTF6zYQvnYz6aX+8W5oCmLsG2+AN5j6NkCi9oiAiBB5Zs/AqdR yAXRfHpB3aegqKdqFO0wPNq6Jxz0Lojh34ih43NcqeDEWl64NEyVl8wbMD+v01V5+Xss vKR2P1UsF+jtD4oicwCpN8PcHW88ScxZRuCbQIlzkNp16oM30Yqnq+l1rrygpK2zqnCm Eht9f8cUjFigkScfypH0XvzPxFP2t23KWxwXyDR1ZYfoUIbYpk7LKW5Hao4oEJ83ib1n uQPg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1679652724; h=content-transfer-encoding:in-reply-to:organization:references:cc:to :content-language:subject:reply-to:from:user-agent:mime-version:date :message-id:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=SPH4mUwrMOscuf6tp1URuXqKk1vAT8I56zMeO2kHP6A=; b=eRkUKHdxfypwEagNL0367m7aJFGBRCnq8z6vYSUEY9Kf18B7hpvpOGYYkCrNyIlB0+ R+Yj+LlMNXm4AN+4/bl0WZ6kzW9ZMiuMDYhtZwMQ7W6Ofze/eMk7xd0dK6yCuKVxJnp3 5Vvmcu+IOktLiuhLYsAFGtHb+kklrp+uFdFLS5N9j6Sh+uNRp/psyc1P5+/0mCpwll9d ENfJjm0Yb8fRSyhV20WmqjHQ5RGCwHwuTO7YIBOjdqWPm0llQUiYNG1amncoC5MiOqEy S6uZXtpkK6UPHZt32iNKEwR2LhvdSeGtuqy3xLPGubZNpw6mQ/AU47UpD6DICabbDWVR BM2w== X-Gm-Message-State: AO0yUKVrOPGhpi5bcso1+r+ZtiJKnZJYrjs2AYtb153yiULgc427pqcu YFAtA8M6f3VHVRr39DrV7umYmvj9HJPWlJQWwsMVVg== X-Google-Smtp-Source: AK7set8IR6Q6Kilnl52WGIRlbWm3xbvS1BES24oina4LDglaBRJJ/DsWqT5cs2NM3gcARp+LzcMOdQ== X-Received: by 2002:a05:600c:d5:b0:3ed:2eb5:c2dd with SMTP id u21-20020a05600c00d500b003ed2eb5c2ddmr1862205wmm.39.1679652724674; Fri, 24 Mar 2023 03:12:04 -0700 (PDT) Received: from ?IPV6:2a01:e0a:982:cbb0:213f:a579:70af:e4a0? ([2a01:e0a:982:cbb0:213f:a579:70af:e4a0]) by smtp.gmail.com with ESMTPSA id u10-20020a05600c19ca00b003ee5fa61f45sm4630286wmq.3.2023.03.24.03.12.03 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 24 Mar 2023 03:12:04 -0700 (PDT) Message-ID: <33c039ff-2702-e058-262a-829199fefa21@linaro.org> Date: Fri, 24 Mar 2023 11:12:03 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.8.0 From: neil.armstrong@linaro.org Subject: Re: [PATCH] soc: amlogic: meson-pwrc: Use dev_err_probe() Content-Language: en-US To: ye.xingchen@zte.com.cn Cc: khilman@baylibre.com, jbrunet@baylibre.com, martin.blumenstingl@googlemail.com, linux-arm-kernel@lists.infradead.org, linux-amlogic@lists.infradead.org, linux-kernel@vger.kernel.org References: <202303241016261854322@zte.com.cn> Organization: Linaro Developer Services In-Reply-To: <202303241016261854322@zte.com.cn> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230324_031206_096551_492CB930 X-CRM114-Status: GOOD ( 15.57 ) X-BeenThere: linux-amlogic@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: neil.armstrong@linaro.org Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Sender: "linux-amlogic" Errors-To: linux-amlogic-bounces+linux-amlogic=archiver.kernel.org@lists.infradead.org On 24/03/2023 03:16, ye.xingchen@zte.com.cn wrote: > From: Ye Xingchen > > Replace the open-code with dev_err_probe() to simplify the code. > > Signed-off-by: Ye Xingchen > --- > drivers/soc/amlogic/meson-gx-pwrc-vpu.c | 8 +++----- > 1 file changed, 3 insertions(+), 5 deletions(-) > > diff --git a/drivers/soc/amlogic/meson-gx-pwrc-vpu.c b/drivers/soc/amlogic/meson-gx-pwrc-vpu.c > index 312fd9afccb0..5d4f12800d93 100644 > --- a/drivers/soc/amlogic/meson-gx-pwrc-vpu.c > +++ b/drivers/soc/amlogic/meson-gx-pwrc-vpu.c > @@ -308,11 +308,9 @@ static int meson_gx_pwrc_vpu_probe(struct platform_device *pdev) > } > > rstc = devm_reset_control_array_get_exclusive(&pdev->dev); > - if (IS_ERR(rstc)) { > - if (PTR_ERR(rstc) != -EPROBE_DEFER) > - dev_err(&pdev->dev, "failed to get reset lines\n"); > - return PTR_ERR(rstc); > - } > + if (IS_ERR(rstc)) > + return dev_err_probe(&pdev->dev, PTR_ERR(rstc), > + "failed to get reset lines\n"); > > vpu_clk = devm_clk_get(&pdev->dev, "vpu"); > if (IS_ERR(vpu_clk)) { Reviewed-by: Neil Armstrong _______________________________________________ linux-amlogic mailing list linux-amlogic@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-amlogic