From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 20A6BC433F5 for ; Thu, 30 Dec 2021 01:56:16 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234245AbhL3B4P (ORCPT ); Wed, 29 Dec 2021 20:56:15 -0500 Received: from mailgw01.mediatek.com ([60.244.123.138]:59624 "EHLO mailgw01.mediatek.com" rhost-flags-OK-FAIL-OK-FAIL) by vger.kernel.org with ESMTP id S230455AbhL3B4N (ORCPT ); Wed, 29 Dec 2021 20:56:13 -0500 X-UUID: 35eccb63286540c1a4ce3c8ba61de529-20211230 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=mediatek.com; s=dk; h=Content-Transfer-Encoding:MIME-Version:Content-Type:References:In-Reply-To:Date:CC:To:From:Subject:Message-ID; bh=HYqS7d+eiPmGytyx8HRz1poJJR6kp79sEhVu1clfAK8=; b=e/mQkyJB35YWGcso6cQkDKbtzAlDZ6IU/LwTLXiohgLdGDkpFhktMp7Y759NzlSamGle3PGj3fouwiIfm3xFtxIjxlr2Do6FIY+dxur7LQnRjJQQSP5o+ZZEzRK7mb/ixQMrPbxhTxN1noSSr0FIEe6bQO9CTvP3hU0Io+pxSAU=; X-UUID: 35eccb63286540c1a4ce3c8ba61de529-20211230 Received: from mtkcas10.mediatek.inc [(172.21.101.39)] by mailgw01.mediatek.com (envelope-from ) (Generic MTA with TLSv1.2 ECDHE-RSA-AES256-SHA384 256/256) with ESMTP id 1994099198; Thu, 30 Dec 2021 09:56:09 +0800 Received: from mtkcas11.mediatek.inc (172.21.101.40) by mtkmbs07n2.mediatek.inc (172.21.101.141) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Thu, 30 Dec 2021 09:56:07 +0800 Received: from mhfsdcap04 (10.17.3.154) by mtkcas11.mediatek.inc (172.21.101.73) with Microsoft SMTP Server id 15.0.1497.2 via Frontend Transport; Thu, 30 Dec 2021 09:56:07 +0800 Message-ID: <33cd21877853d3f602a7403f37a30d68e9fa3e4a.camel@mediatek.com> Subject: Re: [PATCH] phy: mediatek: Fix missing check in mtk_mipi_tx_probe From: Chunfeng Yun To: Miaoqian Lin CC: Chun-Kuang Hu , Philipp Zabel , Kishon Vijay Abraham I , "Vinod Koul" , Matthias Brugger , , , , , Date: Thu, 30 Dec 2021 09:56:07 +0800 In-Reply-To: <20211224082103.7658-1-linmq006@gmail.com> References: <20211224082103.7658-1-linmq006@gmail.com> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.28.5-0ubuntu0.18.04.2 MIME-Version: 1.0 X-MTK: N Content-Transfer-Encoding: base64 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org T24gRnJpLCAyMDIxLTEyLTI0IGF0IDA4OjIxICswMDAwLCBNaWFvcWlhbiBMaW4gd3JvdGU6DQo+ IFRoZSBvZl9kZXZpY2VfZ2V0X21hdGNoX2RhdGEoKSBmdW5jdGlvbiBtYXkgcmV0dXJuIE5VTEwu DQo+IEFkZCBjaGVjayB0byBwcmV2ZW50IHBvdGVudGlhbCBudWxsIGRlcmVmZXJlbmNlLg0KPiAN Cj4gU2lnbmVkLW9mZi1ieTogTWlhb3FpYW4gTGluIDxsaW5tcTAwNkBnbWFpbC5jb20+DQo+IC0t LQ0KPiAgZHJpdmVycy9waHkvbWVkaWF0ZWsvcGh5LW10ay1taXBpLWRzaS5jIHwgMiArKw0KPiAg MSBmaWxlIGNoYW5nZWQsIDIgaW5zZXJ0aW9ucygrKQ0KPiANCj4gZGlmZiAtLWdpdCBhL2RyaXZl cnMvcGh5L21lZGlhdGVrL3BoeS1tdGstbWlwaS1kc2kuYw0KPiBiL2RyaXZlcnMvcGh5L21lZGlh dGVrL3BoeS1tdGstbWlwaS1kc2kuYw0KPiBpbmRleCAyOGFkOTQwM2M0NDEuLjY3YjAwNWQ1Yjll MyAxMDA2NDQNCj4gLS0tIGEvZHJpdmVycy9waHkvbWVkaWF0ZWsvcGh5LW10ay1taXBpLWRzaS5j DQo+ICsrKyBiL2RyaXZlcnMvcGh5L21lZGlhdGVrL3BoeS1tdGstbWlwaS1kc2kuYw0KPiBAQCAt MTQ2LDYgKzE0Niw4IEBAIHN0YXRpYyBpbnQgbXRrX21pcGlfdHhfcHJvYmUoc3RydWN0DQo+IHBs YXRmb3JtX2RldmljZSAqcGRldikNCj4gIAkJcmV0dXJuIC1FTk9NRU07DQo+ICANCj4gIAltaXBp X3R4LT5kcml2ZXJfZGF0YSA9IG9mX2RldmljZV9nZXRfbWF0Y2hfZGF0YShkZXYpOw0KPiArCWlm ICghbWlwaV90eC0+ZHJpdmVyX2RhdGEpDQo+ICsJCXJldHVybiAtRU5PREVWOw0KPiAgDQo+ICAJ bWlwaV90eC0+cmVncyA9IGRldm1fcGxhdGZvcm1faW9yZW1hcF9yZXNvdXJjZShwZGV2LCAwKTsN Cj4gIAlpZiAoSVNfRVJSKG1pcGlfdHgtPnJlZ3MpKQ0KDQpBY2tlZC1ieTogQ2h1bmZlbmcgWXVu IDxjaHVuZmVuZy55dW5AbWVkaWF0ZWsuY29tPg0KDQpUaGFua3MNCg== From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id A46ABC433EF for ; Thu, 30 Dec 2021 01:56:34 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Date:CC:To:From:Subject:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=uOH+8tppTRFbf2HNGfsF9DzJYl2JBXj8eVDnsLA0b4I=; b=AgX3vGHVWDG8Lf uxU0gVVs7J3nGbix2CPGnaKg74c5BHqz/37TBUtYw3A7Vrotfqb5lAwN6Kkf6UCu3CvNh4UdIpKEO olEUJ+NpaXV6b0mGvuc/fnlYfqAZQ/x4BKBy4pVqYA1N1WOeqgFmkx5MdQT7s6iVCJGeE+lWW5CGr O4MMA6BsNzCvBiNikYH+ZvJdbUvhe6eCNNX/a2BsR2+k7fiutsIHQFbYEcFt/+E+IYBaJEtiaIVNG x1r1+rAbPArgOQZvVFlf7eVKfHw77DtNmGm4dTCe2omW4jyNRvw92cimp14iJ+Use36385/5qaceq kGNaEpKbumxdJwFiziHA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1n2kg5-003ZFL-Ao; Thu, 30 Dec 2021 01:56:25 +0000 Received: from mailgw01.mediatek.com ([216.200.240.184]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1n2kg1-003ZEp-6x; Thu, 30 Dec 2021 01:56:24 +0000 X-UUID: 27270f8a0409438aba6bddb5f5bce042-20211229 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=mediatek.com; s=dk; h=Content-Transfer-Encoding:MIME-Version:Content-Type:References:In-Reply-To:Date:CC:To:From:Subject:Message-ID; bh=HYqS7d+eiPmGytyx8HRz1poJJR6kp79sEhVu1clfAK8=; b=e/mQkyJB35YWGcso6cQkDKbtzAlDZ6IU/LwTLXiohgLdGDkpFhktMp7Y759NzlSamGle3PGj3fouwiIfm3xFtxIjxlr2Do6FIY+dxur7LQnRjJQQSP5o+ZZEzRK7mb/ixQMrPbxhTxN1noSSr0FIEe6bQO9CTvP3hU0Io+pxSAU=; X-UUID: 27270f8a0409438aba6bddb5f5bce042-20211229 Received: from mtkcas66.mediatek.inc [(172.29.193.44)] by mailgw01.mediatek.com (envelope-from ) (musrelay.mediatek.com ESMTP with TLSv1.2 ECDHE-RSA-AES256-SHA384 256/256) with ESMTP id 498774183; Wed, 29 Dec 2021 18:56:15 -0700 Received: from MTKMBS07N2.mediatek.inc (172.21.101.141) by MTKMBS62N2.mediatek.inc (172.29.193.42) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Wed, 29 Dec 2021 17:56:09 -0800 Received: from mtkcas11.mediatek.inc (172.21.101.40) by mtkmbs07n2.mediatek.inc (172.21.101.141) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Thu, 30 Dec 2021 09:56:07 +0800 Received: from mhfsdcap04 (10.17.3.154) by mtkcas11.mediatek.inc (172.21.101.73) with Microsoft SMTP Server id 15.0.1497.2 via Frontend Transport; Thu, 30 Dec 2021 09:56:07 +0800 Message-ID: <33cd21877853d3f602a7403f37a30d68e9fa3e4a.camel@mediatek.com> Subject: Re: [PATCH] phy: mediatek: Fix missing check in mtk_mipi_tx_probe From: Chunfeng Yun To: Miaoqian Lin CC: Chun-Kuang Hu , Philipp Zabel , Kishon Vijay Abraham I , "Vinod Koul" , Matthias Brugger , , , , , Date: Thu, 30 Dec 2021 09:56:07 +0800 In-Reply-To: <20211224082103.7658-1-linmq006@gmail.com> References: <20211224082103.7658-1-linmq006@gmail.com> X-Mailer: Evolution 3.28.5-0ubuntu0.18.04.2 MIME-Version: 1.0 X-MTK: N X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20211229_175621_306515_0FFF811F X-CRM114-Status: GOOD ( 13.07 ) X-BeenThere: linux-mediatek@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "Linux-mediatek" Errors-To: linux-mediatek-bounces+linux-mediatek=archiver.kernel.org@lists.infradead.org On Fri, 2021-12-24 at 08:21 +0000, Miaoqian Lin wrote: > The of_device_get_match_data() function may return NULL. > Add check to prevent potential null dereference. > > Signed-off-by: Miaoqian Lin > --- > drivers/phy/mediatek/phy-mtk-mipi-dsi.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/drivers/phy/mediatek/phy-mtk-mipi-dsi.c > b/drivers/phy/mediatek/phy-mtk-mipi-dsi.c > index 28ad9403c441..67b005d5b9e3 100644 > --- a/drivers/phy/mediatek/phy-mtk-mipi-dsi.c > +++ b/drivers/phy/mediatek/phy-mtk-mipi-dsi.c > @@ -146,6 +146,8 @@ static int mtk_mipi_tx_probe(struct > platform_device *pdev) > return -ENOMEM; > > mipi_tx->driver_data = of_device_get_match_data(dev); > + if (!mipi_tx->driver_data) > + return -ENODEV; > > mipi_tx->regs = devm_platform_ioremap_resource(pdev, 0); > if (IS_ERR(mipi_tx->regs)) Acked-by: Chunfeng Yun Thanks _______________________________________________ Linux-mediatek mailing list Linux-mediatek@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-mediatek From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id C452CC433F5 for ; Thu, 30 Dec 2021 01:56:35 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Date:CC:To:From:Subject:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=vtOWdNd2LIXf0OjUWpAnzeQtX2fLxziJamR6u5tozD4=; b=Hjp3Kas+HrH2hA 5IfTzVa+2RbtIjwBI5MJtSRoFjU2eWqtCslOU4SEsbdENQEdLCLTZNdwrAMc8J8wSbx0jYkHxPT58 xcjovJ40giuxUjwClaMeOpzOKnOC4scyDzcZbOBw8Qh8cLDBb09koJrA2d+R98OGPj4opoWt8TBHF BIveNJPWuMeLk1+m0KXvT7MUuIAm13dzLyFiu17jCU2Q3wrGNioG7Fl80Vuhj0xI8E/lsIZoHoaom E7nUU9dZsbz4gksBpUzSIDM1awF07iQWQI6riXRUJmuRvY5Mpr6nB/XJvvMOteeBMh1zziMI/aXHA G0lBiU4zBX8cZv/Un2lg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1n2kgF-003ZGt-7f; Thu, 30 Dec 2021 01:56:35 +0000 Received: from mailgw01.mediatek.com ([216.200.240.184]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1n2kg1-003ZEp-6x; Thu, 30 Dec 2021 01:56:24 +0000 X-UUID: 27270f8a0409438aba6bddb5f5bce042-20211229 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=mediatek.com; s=dk; h=Content-Transfer-Encoding:MIME-Version:Content-Type:References:In-Reply-To:Date:CC:To:From:Subject:Message-ID; bh=HYqS7d+eiPmGytyx8HRz1poJJR6kp79sEhVu1clfAK8=; b=e/mQkyJB35YWGcso6cQkDKbtzAlDZ6IU/LwTLXiohgLdGDkpFhktMp7Y759NzlSamGle3PGj3fouwiIfm3xFtxIjxlr2Do6FIY+dxur7LQnRjJQQSP5o+ZZEzRK7mb/ixQMrPbxhTxN1noSSr0FIEe6bQO9CTvP3hU0Io+pxSAU=; X-UUID: 27270f8a0409438aba6bddb5f5bce042-20211229 Received: from mtkcas66.mediatek.inc [(172.29.193.44)] by mailgw01.mediatek.com (envelope-from ) (musrelay.mediatek.com ESMTP with TLSv1.2 ECDHE-RSA-AES256-SHA384 256/256) with ESMTP id 498774183; Wed, 29 Dec 2021 18:56:15 -0700 Received: from MTKMBS07N2.mediatek.inc (172.21.101.141) by MTKMBS62N2.mediatek.inc (172.29.193.42) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Wed, 29 Dec 2021 17:56:09 -0800 Received: from mtkcas11.mediatek.inc (172.21.101.40) by mtkmbs07n2.mediatek.inc (172.21.101.141) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Thu, 30 Dec 2021 09:56:07 +0800 Received: from mhfsdcap04 (10.17.3.154) by mtkcas11.mediatek.inc (172.21.101.73) with Microsoft SMTP Server id 15.0.1497.2 via Frontend Transport; Thu, 30 Dec 2021 09:56:07 +0800 Message-ID: <33cd21877853d3f602a7403f37a30d68e9fa3e4a.camel@mediatek.com> Subject: Re: [PATCH] phy: mediatek: Fix missing check in mtk_mipi_tx_probe From: Chunfeng Yun To: Miaoqian Lin CC: Chun-Kuang Hu , Philipp Zabel , Kishon Vijay Abraham I , "Vinod Koul" , Matthias Brugger , , , , , Date: Thu, 30 Dec 2021 09:56:07 +0800 In-Reply-To: <20211224082103.7658-1-linmq006@gmail.com> References: <20211224082103.7658-1-linmq006@gmail.com> X-Mailer: Evolution 3.28.5-0ubuntu0.18.04.2 MIME-Version: 1.0 X-MTK: N X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20211229_175621_306515_0FFF811F X-CRM114-Status: GOOD ( 13.07 ) X-BeenThere: linux-phy@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Linux Phy Mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-phy" Errors-To: linux-phy-bounces+linux-phy=archiver.kernel.org@lists.infradead.org On Fri, 2021-12-24 at 08:21 +0000, Miaoqian Lin wrote: > The of_device_get_match_data() function may return NULL. > Add check to prevent potential null dereference. > > Signed-off-by: Miaoqian Lin > --- > drivers/phy/mediatek/phy-mtk-mipi-dsi.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/drivers/phy/mediatek/phy-mtk-mipi-dsi.c > b/drivers/phy/mediatek/phy-mtk-mipi-dsi.c > index 28ad9403c441..67b005d5b9e3 100644 > --- a/drivers/phy/mediatek/phy-mtk-mipi-dsi.c > +++ b/drivers/phy/mediatek/phy-mtk-mipi-dsi.c > @@ -146,6 +146,8 @@ static int mtk_mipi_tx_probe(struct > platform_device *pdev) > return -ENOMEM; > > mipi_tx->driver_data = of_device_get_match_data(dev); > + if (!mipi_tx->driver_data) > + return -ENODEV; > > mipi_tx->regs = devm_platform_ioremap_resource(pdev, 0); > if (IS_ERR(mipi_tx->regs)) Acked-by: Chunfeng Yun Thanks -- linux-phy mailing list linux-phy@lists.infradead.org https://lists.infradead.org/mailman/listinfo/linux-phy From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 01ABDC433F5 for ; Thu, 30 Dec 2021 01:58:07 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Date:CC:To:From:Subject:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=snKm4uQDpstNcYeNctvo7U20KaHdQsNlv6wNPcYeOgI=; b=J9SVSCE+cZ6Jx8 tnY8ss4DcvUAziUk4XvDqnI2c8ByNRgWf1FvNU1Ve+vyjbwR5AO3aOLm+gXnqlUxpA5BNy7eaKTbP /J3YGtIlDtPu2bA0O8M+DQIIUkkqBXZr5hFrAbBMYZtKFToOorp9ePMxup2jmRXISIeFXzfk6pUNC 5knBJe9GaYf4BC/lz3oDLQ8f5c0NATw+QG1+XkO6PnkXnJLDUNGL5qsvcFHuDZwV8Cs+KxSw2Ck08 o93Jdia2fptH8XCKGrQ9f6e0zNmteTzOBpsSFHHF7NfY/LSWxxQ5zjTgmgLUr9FYblobsrQ2/ytXx fvqjCD6O1VOcvilUIGAQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1n2kg6-003ZFR-Rv; Thu, 30 Dec 2021 01:56:26 +0000 Received: from mailgw01.mediatek.com ([216.200.240.184]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1n2kg1-003ZEp-6x; Thu, 30 Dec 2021 01:56:24 +0000 X-UUID: 27270f8a0409438aba6bddb5f5bce042-20211229 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=mediatek.com; s=dk; h=Content-Transfer-Encoding:MIME-Version:Content-Type:References:In-Reply-To:Date:CC:To:From:Subject:Message-ID; bh=HYqS7d+eiPmGytyx8HRz1poJJR6kp79sEhVu1clfAK8=; b=e/mQkyJB35YWGcso6cQkDKbtzAlDZ6IU/LwTLXiohgLdGDkpFhktMp7Y759NzlSamGle3PGj3fouwiIfm3xFtxIjxlr2Do6FIY+dxur7LQnRjJQQSP5o+ZZEzRK7mb/ixQMrPbxhTxN1noSSr0FIEe6bQO9CTvP3hU0Io+pxSAU=; X-UUID: 27270f8a0409438aba6bddb5f5bce042-20211229 Received: from mtkcas66.mediatek.inc [(172.29.193.44)] by mailgw01.mediatek.com (envelope-from ) (musrelay.mediatek.com ESMTP with TLSv1.2 ECDHE-RSA-AES256-SHA384 256/256) with ESMTP id 498774183; Wed, 29 Dec 2021 18:56:15 -0700 Received: from MTKMBS07N2.mediatek.inc (172.21.101.141) by MTKMBS62N2.mediatek.inc (172.29.193.42) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Wed, 29 Dec 2021 17:56:09 -0800 Received: from mtkcas11.mediatek.inc (172.21.101.40) by mtkmbs07n2.mediatek.inc (172.21.101.141) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Thu, 30 Dec 2021 09:56:07 +0800 Received: from mhfsdcap04 (10.17.3.154) by mtkcas11.mediatek.inc (172.21.101.73) with Microsoft SMTP Server id 15.0.1497.2 via Frontend Transport; Thu, 30 Dec 2021 09:56:07 +0800 Message-ID: <33cd21877853d3f602a7403f37a30d68e9fa3e4a.camel@mediatek.com> Subject: Re: [PATCH] phy: mediatek: Fix missing check in mtk_mipi_tx_probe From: Chunfeng Yun To: Miaoqian Lin CC: Chun-Kuang Hu , Philipp Zabel , Kishon Vijay Abraham I , "Vinod Koul" , Matthias Brugger , , , , , Date: Thu, 30 Dec 2021 09:56:07 +0800 In-Reply-To: <20211224082103.7658-1-linmq006@gmail.com> References: <20211224082103.7658-1-linmq006@gmail.com> X-Mailer: Evolution 3.28.5-0ubuntu0.18.04.2 MIME-Version: 1.0 X-MTK: N X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20211229_175621_306515_0FFF811F X-CRM114-Status: GOOD ( 13.07 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Fri, 2021-12-24 at 08:21 +0000, Miaoqian Lin wrote: > The of_device_get_match_data() function may return NULL. > Add check to prevent potential null dereference. > > Signed-off-by: Miaoqian Lin > --- > drivers/phy/mediatek/phy-mtk-mipi-dsi.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/drivers/phy/mediatek/phy-mtk-mipi-dsi.c > b/drivers/phy/mediatek/phy-mtk-mipi-dsi.c > index 28ad9403c441..67b005d5b9e3 100644 > --- a/drivers/phy/mediatek/phy-mtk-mipi-dsi.c > +++ b/drivers/phy/mediatek/phy-mtk-mipi-dsi.c > @@ -146,6 +146,8 @@ static int mtk_mipi_tx_probe(struct > platform_device *pdev) > return -ENOMEM; > > mipi_tx->driver_data = of_device_get_match_data(dev); > + if (!mipi_tx->driver_data) > + return -ENODEV; > > mipi_tx->regs = devm_platform_ioremap_resource(pdev, 0); > if (IS_ERR(mipi_tx->regs)) Acked-by: Chunfeng Yun Thanks _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id A549CC433F5 for ; Thu, 30 Dec 2021 02:01:31 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 4CD358989C; Thu, 30 Dec 2021 02:01:30 +0000 (UTC) Received: from mailgw01.mediatek.com (unknown [60.244.123.138]) by gabe.freedesktop.org (Postfix) with ESMTPS id 5B2D28989C for ; Thu, 30 Dec 2021 02:01:28 +0000 (UTC) X-UUID: 35eccb63286540c1a4ce3c8ba61de529-20211230 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=mediatek.com; s=dk; h=Content-Transfer-Encoding:MIME-Version:Content-Type:References:In-Reply-To:Date:CC:To:From:Subject:Message-ID; bh=HYqS7d+eiPmGytyx8HRz1poJJR6kp79sEhVu1clfAK8=; b=e/mQkyJB35YWGcso6cQkDKbtzAlDZ6IU/LwTLXiohgLdGDkpFhktMp7Y759NzlSamGle3PGj3fouwiIfm3xFtxIjxlr2Do6FIY+dxur7LQnRjJQQSP5o+ZZEzRK7mb/ixQMrPbxhTxN1noSSr0FIEe6bQO9CTvP3hU0Io+pxSAU=; X-UUID: 35eccb63286540c1a4ce3c8ba61de529-20211230 Received: from mtkcas10.mediatek.inc [(172.21.101.39)] by mailgw01.mediatek.com (envelope-from ) (Generic MTA with TLSv1.2 ECDHE-RSA-AES256-SHA384 256/256) with ESMTP id 1994099198; Thu, 30 Dec 2021 09:56:09 +0800 Received: from mtkcas11.mediatek.inc (172.21.101.40) by mtkmbs07n2.mediatek.inc (172.21.101.141) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Thu, 30 Dec 2021 09:56:07 +0800 Received: from mhfsdcap04 (10.17.3.154) by mtkcas11.mediatek.inc (172.21.101.73) with Microsoft SMTP Server id 15.0.1497.2 via Frontend Transport; Thu, 30 Dec 2021 09:56:07 +0800 Message-ID: <33cd21877853d3f602a7403f37a30d68e9fa3e4a.camel@mediatek.com> Subject: Re: [PATCH] phy: mediatek: Fix missing check in mtk_mipi_tx_probe From: Chunfeng Yun To: Miaoqian Lin Date: Thu, 30 Dec 2021 09:56:07 +0800 In-Reply-To: <20211224082103.7658-1-linmq006@gmail.com> References: <20211224082103.7658-1-linmq006@gmail.com> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.28.5-0ubuntu0.18.04.2 MIME-Version: 1.0 X-MTK: N Content-Transfer-Encoding: base64 X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Chun-Kuang Hu , linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, Kishon Vijay Abraham I , linux-phy@lists.infradead.org, Vinod Koul , linux-mediatek@lists.infradead.org, Matthias Brugger , linux-arm-kernel@lists.infradead.org Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" T24gRnJpLCAyMDIxLTEyLTI0IGF0IDA4OjIxICswMDAwLCBNaWFvcWlhbiBMaW4gd3JvdGU6DQo+ IFRoZSBvZl9kZXZpY2VfZ2V0X21hdGNoX2RhdGEoKSBmdW5jdGlvbiBtYXkgcmV0dXJuIE5VTEwu DQo+IEFkZCBjaGVjayB0byBwcmV2ZW50IHBvdGVudGlhbCBudWxsIGRlcmVmZXJlbmNlLg0KPiAN Cj4gU2lnbmVkLW9mZi1ieTogTWlhb3FpYW4gTGluIDxsaW5tcTAwNkBnbWFpbC5jb20+DQo+IC0t LQ0KPiAgZHJpdmVycy9waHkvbWVkaWF0ZWsvcGh5LW10ay1taXBpLWRzaS5jIHwgMiArKw0KPiAg MSBmaWxlIGNoYW5nZWQsIDIgaW5zZXJ0aW9ucygrKQ0KPiANCj4gZGlmZiAtLWdpdCBhL2RyaXZl cnMvcGh5L21lZGlhdGVrL3BoeS1tdGstbWlwaS1kc2kuYw0KPiBiL2RyaXZlcnMvcGh5L21lZGlh dGVrL3BoeS1tdGstbWlwaS1kc2kuYw0KPiBpbmRleCAyOGFkOTQwM2M0NDEuLjY3YjAwNWQ1Yjll MyAxMDA2NDQNCj4gLS0tIGEvZHJpdmVycy9waHkvbWVkaWF0ZWsvcGh5LW10ay1taXBpLWRzaS5j DQo+ICsrKyBiL2RyaXZlcnMvcGh5L21lZGlhdGVrL3BoeS1tdGstbWlwaS1kc2kuYw0KPiBAQCAt MTQ2LDYgKzE0Niw4IEBAIHN0YXRpYyBpbnQgbXRrX21pcGlfdHhfcHJvYmUoc3RydWN0DQo+IHBs YXRmb3JtX2RldmljZSAqcGRldikNCj4gIAkJcmV0dXJuIC1FTk9NRU07DQo+ICANCj4gIAltaXBp X3R4LT5kcml2ZXJfZGF0YSA9IG9mX2RldmljZV9nZXRfbWF0Y2hfZGF0YShkZXYpOw0KPiArCWlm ICghbWlwaV90eC0+ZHJpdmVyX2RhdGEpDQo+ICsJCXJldHVybiAtRU5PREVWOw0KPiAgDQo+ICAJ bWlwaV90eC0+cmVncyA9IGRldm1fcGxhdGZvcm1faW9yZW1hcF9yZXNvdXJjZShwZGV2LCAwKTsN Cj4gIAlpZiAoSVNfRVJSKG1pcGlfdHgtPnJlZ3MpKQ0KDQpBY2tlZC1ieTogQ2h1bmZlbmcgWXVu IDxjaHVuZmVuZy55dW5AbWVkaWF0ZWsuY29tPg0KDQpUaGFua3MNCg==