From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from szxga03-in.huawei.com (szxga03-in.huawei.com [45.249.212.189]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id CE3652C8E for ; Tue, 2 Nov 2021 03:04:40 +0000 (UTC) Received: from dggeme755-chm.china.huawei.com (unknown [172.30.72.53]) by szxga03-in.huawei.com (SkyGuard) with ESMTP id 4HjvS66vqGzSh0v; Tue, 2 Nov 2021 10:46:46 +0800 (CST) Received: from [10.67.110.136] (10.67.110.136) by dggeme755-chm.china.huawei.com (10.3.19.101) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.2308.15; Tue, 2 Nov 2021 10:48:14 +0800 Subject: Re: [PATCH] drm: Grab reference of connector before return connector from sun4i_tcon_get_connector To: Jani Nikula , , , , , CC: , , , References: <20211101062906.231518-1-heying24@huawei.com> <87cznkdo6p.fsf@intel.com> From: He Ying Message-ID: <33e01d45-c9f9-0e8c-6871-868ecd198368@huawei.com> Date: Tue, 2 Nov 2021 10:48:14 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.8.1 Precedence: bulk X-Mailing-List: linux-sunxi@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 In-Reply-To: <87cznkdo6p.fsf@intel.com> Content-Type: text/plain; charset="gbk"; format=flowed Content-Transfer-Encoding: 8bit X-Originating-IP: [10.67.110.136] X-ClientProxiedBy: dggems703-chm.china.huawei.com (10.3.19.180) To dggeme755-chm.china.huawei.com (10.3.19.101) X-CFilter-Loop: Reflected ÔÚ 2021/11/1 21:02, Jani Nikula дµÀ: > On Mon, 01 Nov 2021, He Ying wrote: >> From the comments of drm_for_each_connector_iter(), we know >> that "connector is only valid within the list body, if you >> want to use connector after calling drm_connector_list_iter_end() >> then you need to grab your own reference first using >> drm_connector_get()". So fix the wrong use of connector >> according to the comments and then call drm_connector_put() >> after using connector finishes. >> >> Signed-off-by: He Ying > Please use "drm/sun4i:" subject prefix for sun4i patches. OK. I'll send a V2 later. By the way, may I have your suggestions about this patch's content. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2E20FC433EF for ; Tue, 2 Nov 2021 02:48:21 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id B066C601FF for ; Tue, 2 Nov 2021 02:48:20 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org B066C601FF Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=huawei.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id E4A916EB3D; Tue, 2 Nov 2021 02:48:19 +0000 (UTC) Received: from szxga03-in.huawei.com (szxga03-in.huawei.com [45.249.212.189]) by gabe.freedesktop.org (Postfix) with ESMTPS id 796406EB3D for ; Tue, 2 Nov 2021 02:48:17 +0000 (UTC) Received: from dggeme755-chm.china.huawei.com (unknown [172.30.72.53]) by szxga03-in.huawei.com (SkyGuard) with ESMTP id 4HjvS66vqGzSh0v; Tue, 2 Nov 2021 10:46:46 +0800 (CST) Received: from [10.67.110.136] (10.67.110.136) by dggeme755-chm.china.huawei.com (10.3.19.101) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.2308.15; Tue, 2 Nov 2021 10:48:14 +0800 Subject: Re: [PATCH] drm: Grab reference of connector before return connector from sun4i_tcon_get_connector To: Jani Nikula , , , , , References: <20211101062906.231518-1-heying24@huawei.com> <87cznkdo6p.fsf@intel.com> From: He Ying Message-ID: <33e01d45-c9f9-0e8c-6871-868ecd198368@huawei.com> Date: Tue, 2 Nov 2021 10:48:14 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.8.1 MIME-Version: 1.0 In-Reply-To: <87cznkdo6p.fsf@intel.com> Content-Type: text/plain; charset="gbk"; format=flowed Content-Transfer-Encoding: 8bit X-Originating-IP: [10.67.110.136] X-ClientProxiedBy: dggems703-chm.china.huawei.com (10.3.19.180) To dggeme755-chm.china.huawei.com (10.3.19.101) X-CFilter-Loop: Reflected X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-sunxi@lists.linux.dev Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" ÔÚ 2021/11/1 21:02, Jani Nikula дµÀ: > On Mon, 01 Nov 2021, He Ying wrote: >> From the comments of drm_for_each_connector_iter(), we know >> that "connector is only valid within the list body, if you >> want to use connector after calling drm_connector_list_iter_end() >> then you need to grab your own reference first using >> drm_connector_get()". So fix the wrong use of connector >> according to the comments and then call drm_connector_put() >> after using connector finishes. >> >> Signed-off-by: He Ying > Please use "drm/sun4i:" subject prefix for sun4i patches. OK. I'll send a V2 later. By the way, may I have your suggestions about this patch's content. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4AD86C433EF for ; Tue, 2 Nov 2021 02:49:38 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 113E460ED5 for ; Tue, 2 Nov 2021 02:49:38 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 113E460ED5 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=huawei.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Content-Type: Content-Transfer-Encoding:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:Date:Message-ID:From: References:CC:To:Subject:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=D2GP4UMSBCpcEoUYX4R/dsqQKl1gjXWFjo2NJQ0MSXU=; b=g4KK2/AY35XhCso6dsZ10RPNJh /EP7e6O1qKz/b4AKqjDy/x2U7cuYHijdAc0P1ZabpvdkUT1Hz635VvgNmZFFrwVoAcY3/XemIq8K6 MriyfVasVcBHYxo3KkntSQqZNJXA9p5PmxuXAAgEN1RmoNhNCst0T9Ao1OjPHVW9k2rhTy1PPphCC UkVtL1GZK0020/63J7Rk1nFtHs9KC51MkGrt6L/gabXTfRqYniAxIi7wJuchUXMbT6AlI3fhrm8ZO bubHGXQmJZ0TWipsYRgKsEGZS1rkyuYG2Oy69WIJrWWTZVZ35gFNWDdpkjTfd9dhn+o4KnpEbz+QZ x0EHEWHA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1mhjqc-000K6d-Jk; Tue, 02 Nov 2021 02:48:26 +0000 Received: from szxga03-in.huawei.com ([45.249.212.189]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1mhjqY-000K4e-Ry for linux-arm-kernel@lists.infradead.org; Tue, 02 Nov 2021 02:48:24 +0000 Received: from dggeme755-chm.china.huawei.com (unknown [172.30.72.53]) by szxga03-in.huawei.com (SkyGuard) with ESMTP id 4HjvS66vqGzSh0v; Tue, 2 Nov 2021 10:46:46 +0800 (CST) Received: from [10.67.110.136] (10.67.110.136) by dggeme755-chm.china.huawei.com (10.3.19.101) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.2308.15; Tue, 2 Nov 2021 10:48:14 +0800 Subject: Re: [PATCH] drm: Grab reference of connector before return connector from sun4i_tcon_get_connector To: Jani Nikula , , , , , CC: , , , References: <20211101062906.231518-1-heying24@huawei.com> <87cznkdo6p.fsf@intel.com> From: He Ying Message-ID: <33e01d45-c9f9-0e8c-6871-868ecd198368@huawei.com> Date: Tue, 2 Nov 2021 10:48:14 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.8.1 MIME-Version: 1.0 In-Reply-To: <87cznkdo6p.fsf@intel.com> X-Originating-IP: [10.67.110.136] X-ClientProxiedBy: dggems703-chm.china.huawei.com (10.3.19.180) To dggeme755-chm.china.huawei.com (10.3.19.101) X-CFilter-Loop: Reflected X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20211101_194823_187328_D4C3D4B6 X-CRM114-Status: UNSURE ( 7.38 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: base64 Content-Type: text/plain; charset="gbk"; Format="flowed" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org CtTaIDIwMjEvMTEvMSAyMTowMiwgSmFuaSBOaWt1bGEg0LS1wDoKPiBPbiBNb24sIDAxIE5vdiAy MDIxLCBIZSBZaW5nIDxoZXlpbmcyNEBodWF3ZWkuY29tPiB3cm90ZToKPj4gIEZyb20gdGhlIGNv bW1lbnRzIG9mIGRybV9mb3JfZWFjaF9jb25uZWN0b3JfaXRlcigpLCB3ZSBrbm93Cj4+IHRoYXQg ImNvbm5lY3RvciBpcyBvbmx5IHZhbGlkIHdpdGhpbiB0aGUgbGlzdCBib2R5LCBpZiB5b3UKPj4g d2FudCB0byB1c2UgY29ubmVjdG9yIGFmdGVyIGNhbGxpbmcgZHJtX2Nvbm5lY3Rvcl9saXN0X2l0 ZXJfZW5kKCkKPj4gdGhlbiB5b3UgbmVlZCB0byBncmFiIHlvdXIgb3duIHJlZmVyZW5jZSBmaXJz dCB1c2luZwo+PiBkcm1fY29ubmVjdG9yX2dldCgpIi4gU28gZml4IHRoZSB3cm9uZyB1c2Ugb2Yg Y29ubmVjdG9yCj4+IGFjY29yZGluZyB0byB0aGUgY29tbWVudHMgYW5kIHRoZW4gY2FsbCBkcm1f Y29ubmVjdG9yX3B1dCgpCj4+IGFmdGVyIHVzaW5nIGNvbm5lY3RvciBmaW5pc2hlcy4KPj4KPj4g U2lnbmVkLW9mZi1ieTogSGUgWWluZyA8aGV5aW5nMjRAaHVhd2VpLmNvbT4KPiBQbGVhc2UgdXNl ICJkcm0vc3VuNGk6IiBzdWJqZWN0IHByZWZpeCBmb3Igc3VuNGkgcGF0Y2hlcy4KCk9LLiBJJ2xs IHNlbmQgYSBWMiBsYXRlci4gQnkgdGhlIHdheSwgbWF5IEkgaGF2ZSB5b3VyIHN1Z2dlc3Rpb25z IGFib3V0Cgp0aGlzIHBhdGNoJ3MgY29udGVudC4KCgpfX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fXwpsaW51eC1hcm0ta2VybmVsIG1haWxpbmcgbGlzdApsaW51 eC1hcm0ta2VybmVsQGxpc3RzLmluZnJhZGVhZC5vcmcKaHR0cDovL2xpc3RzLmluZnJhZGVhZC5v cmcvbWFpbG1hbi9saXN0aW5mby9saW51eC1hcm0ta2VybmVsCg==