From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7331CC433F5 for ; Wed, 23 Mar 2022 11:02:19 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S243687AbiCWLDr (ORCPT ); Wed, 23 Mar 2022 07:03:47 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:35196 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232483AbiCWLDp (ORCPT ); Wed, 23 Mar 2022 07:03:45 -0400 Received: from NAM11-DM6-obe.outbound.protection.outlook.com (mail-dm6nam11on2079.outbound.protection.outlook.com [40.107.223.79]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 4623340E57; Wed, 23 Mar 2022 04:02:16 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=lwu/OJuKRXi6e3piY6GT/eFbQ3FgZjsNVtAXSBWuUNyj3+oEAidGK5XvIG8s7DXYHo5k4PXmTFdo9xU7QflzFvYA4JXFDbjtpFhF2Z8rJh6APUqyLwwZTkJdUzsRgkmYKW4qfXBwDUe0UxcxHuG/hEcRNacb3KU4nV+XGSQnr4zK5vHWNfOzKHvOySK84n2krn8WRetkRd0xOk1TFEkyrKwquy6Nda/Pzr/eghVMPo58bgWcU0lmpqWUg2ti+HHaX9gk6C+++c1ZcZrdc312UQQz17zsXta7I3UluRO8f80Ql6/5EP20bzW6Zujzp9MF81yL8Hlyk2n2lafvPQhCog== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=CJCXoFEjg4nwvRNqinrWy2/0aVGKAnFjXx5ekNT0BKg=; b=ht1aT1jndKnH40HYUpkUtF4FntjE2t5Us5GgEc36ZbWtH20/8g7wIHvEyKhG2ABjcO8V31L9K7qRfhbFpUknyFjjXmz+0hvjnEEntlFV8+MbYjJH5hH+5BjuYwomycnImPPOtDzcDj9xQKhlldJDzsna/C5qqckPbBS2Wfj2F/j8Se7HF4ZF+G7yfEW5aylzS9F5dcPqBxm3l/EABf6XoC4kOP1tSyZUaiP240Q1wlKFqtkVfXYjhq4TZvyI1kq/OFa4T+rcYxNpWAT20GwRGOKdp0eYsVBmSvrq31wL21jqXxEgWjoiTVeQlHV72jm1jF1AK+V19hdF4AXhf/ZIyg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 149.199.62.198) smtp.rcpttodomain=opensource.cirrus.com smtp.mailfrom=xilinx.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=xilinx.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=xilinx.onmicrosoft.com; s=selector2-xilinx-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=CJCXoFEjg4nwvRNqinrWy2/0aVGKAnFjXx5ekNT0BKg=; b=B+OktkwYUYa7XzZhXKPfQgd7JHzNNei8inrbH/M2W+nuX68TAXWWc/0X4kTQfJyWwg7d+2P+KMOjuspF83i0bJMYCcBwTnjXXtXbiwRHZlQvfQGsQvZs26aro/C0s82CPddeBxMY4l8TMoogTZqho3pnLreJhE/rAsAnI0lI8kk= Received: from DM5PR21CA0059.namprd21.prod.outlook.com (2603:10b6:3:129::21) by DM8PR02MB8215.namprd02.prod.outlook.com (2603:10b6:8:e::5) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5081.19; Wed, 23 Mar 2022 11:02:13 +0000 Received: from DM3NAM02FT029.eop-nam02.prod.protection.outlook.com (2603:10b6:3:129:cafe::fc) by DM5PR21CA0059.outlook.office365.com (2603:10b6:3:129::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5123.7 via Frontend Transport; Wed, 23 Mar 2022 11:02:13 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 149.199.62.198) smtp.mailfrom=xilinx.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=xilinx.com; Received-SPF: Pass (protection.outlook.com: domain of xilinx.com designates 149.199.62.198 as permitted sender) receiver=protection.outlook.com; client-ip=149.199.62.198; helo=xsj-pvapexch01.xlnx.xilinx.com; Received: from xsj-pvapexch01.xlnx.xilinx.com (149.199.62.198) by DM3NAM02FT029.mail.protection.outlook.com (10.13.4.98) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.5102.17 via Frontend Transport; Wed, 23 Mar 2022 11:02:13 +0000 Received: from xsj-pvapexch02.xlnx.xilinx.com (172.19.86.41) by xsj-pvapexch01.xlnx.xilinx.com (172.19.86.40) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2176.14; Wed, 23 Mar 2022 04:02:11 -0700 Received: from smtp.xilinx.com (172.19.127.96) by xsj-pvapexch02.xlnx.xilinx.com (172.19.86.41) with Microsoft SMTP Server id 15.1.2176.14 via Frontend Transport; Wed, 23 Mar 2022 04:02:11 -0700 Envelope-to: tanureal@opensource.cirrus.com, linux-arm-kernel@lists.infradead.org, linux-i2c@vger.kernel.org, linux-kernel@vger.kernel.org, patches@opensource.cirrus.com Received: from [10.254.241.50] (port=54338) by smtp.xilinx.com with esmtp (Exim 4.90) (envelope-from ) id 1nWykl-000DYN-95; Wed, 23 Mar 2022 04:02:11 -0700 Message-ID: <33ed666e-79aa-4779-43d6-4f2e82d91744@xilinx.com> Date: Wed, 23 Mar 2022 12:02:08 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.7.0 Subject: Re: [PATCH] i2c: cadence: Increase timeout per message if necessary Content-Language: en-US To: , Michal Simek , Shubhrajyoti Datta , , , , References: <20220309093147.102385-1-tanureal@opensource.cirrus.com> <4af9c968-b837-e984-1051-2dcd240f2c08@opensource.cirrus.com> <08dc1f90-586a-a47a-7c13-bce0405c13d6@xilinx.com> <3657b9ef-2c2e-82b1-1e2c-3d50c64d84b2@opensource.cirrus.com> From: Michal Simek In-Reply-To: <3657b9ef-2c2e-82b1-1e2c-3d50c64d84b2@opensource.cirrus.com> Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 8bit X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 31e4cf64-afa2-4a23-fc59-08da0cbc9601 X-MS-TrafficTypeDiagnostic: DM8PR02MB8215:EE_ X-Microsoft-Antispam-PRVS: X-Auto-Response-Suppress: DR, RN, NRN, OOF, AutoReply X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: DBfa2+vh4sscBfHLosdTAx9exx69OgNGS1hq9713JzvRtGJAGq7XiSMe6Ob0b4YyLEdJFBux7DpiA7UbtWDk2QVtfIWHgI/v4F1omxaib0rMbPSHpo2VLGbjTYuI03dzU9MeOx6BKY+UeZ5LW40mtlC0ZZbz9kGLpmDLY4HKCSVCME/S1pgZRRMbDCJFJE6I8EFbpXZRP/D8znFyFHwC1r908G5kJes4cM8ERp1biOE2haDT21KK5wDXhWLMtHqt28jHu1FmpBENGYi5WrwkuXZcGJBCQuzp2Epuck7MXAl0kGCdKHqMz5rLAetbSintgSAmnSyqFEFRvWAh1NfsXeW6soZ6rDeect+OcuFi9xe13ygBSrkr5lSXb2xXQP0pF+WeytbCnpNy+0HDr9/s5Snf8d67pZTmOalkvKLWK7dhPzfInYVlFwT2rS11u4EBHryis1JIs9NJe4d7QpwOnC4D7MfWUWyHMMHhkm5aoy1Uj6RhSyO5Ko8RIahQQbGzmqLkqwkytCYmUiHgVPSOdlVCtMHzNaBa01Ww8KHtSUj2TdiXjiTKmANqiLC4Nmp3aoxD7NbhLJDIFRyOXR4STk2A/SFx//bw3kDE6RfU7Ca4L+v1tUvq+3WqHtdGXUkHlLFtp3jQrXF8znza6NPQDjr7wjI71z9OAT1s5+nMKxgweI+8XSSELj9TpjkFTsBq6L1n/AXxJJS5PtA7QesLdKbWPsaU43Fh/J2UT8jxwOpCtVzWAYhquCufYbEl6Ghi X-Forefront-Antispam-Report: CIP:149.199.62.198;CTRY:US;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:xsj-pvapexch01.xlnx.xilinx.com;PTR:unknown-62-198.xilinx.com;CAT:NONE;SFS:(13230001)(4636009)(36840700001)(40470700004)(46966006)(8936002)(15650500001)(83380400001)(5660300002)(9786002)(36860700001)(82310400004)(44832011)(47076005)(336012)(110136005)(6666004)(316002)(2906002)(53546011)(26005)(426003)(186003)(508600001)(8676002)(2616005)(70586007)(70206006)(31696002)(40460700003)(31686004)(36756003)(356005)(7636003)(50156003)(43740500002)(2101003);DIR:OUT;SFP:1101; X-OriginatorOrg: xilinx.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 23 Mar 2022 11:02:13.5662 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 31e4cf64-afa2-4a23-fc59-08da0cbc9601 X-MS-Exchange-CrossTenant-Id: 657af505-d5df-48d0-8300-c31994686c5c X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=657af505-d5df-48d0-8300-c31994686c5c;Ip=[149.199.62.198];Helo=[xsj-pvapexch01.xlnx.xilinx.com] X-MS-Exchange-CrossTenant-AuthSource: DM3NAM02FT029.eop-nam02.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM8PR02MB8215 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 3/23/22 11:07, tanureal@opensource.cirrus.com wrote: > On 3/22/22 5:18 PM, Michal Simek wrote: >> >> >> On 3/22/22 16:34, tanureal@opensource.cirrus.com wrote: >> > On 3/21/22 3:57 PM, Michal Simek wrote: >> >> +Shubhrajyoti >> >> >> >> On 3/9/22 10:31, Lucas Tanure wrote: >> >> > Timeout as 1 second sets a upper limit on the length of >> >> > the transfer executed, but there is no maximum length of >> >> > a write or read message set in i2c_adapter_quirks for this >> >> > controller. >> >> >> >> nit: I would expect that you have run any test and you reached an issue. >> >> Would be good to describe what exactly you have tried on which >> >> configuration to make it super clear. >> >> >> >> > >> >> > To remove that limitation calculate the minimal time >> >> > necessary, plus some wiggle room, for every message >> >> > and use it instead of the default one second, if >> >> > more than one second. >> >> > >> >> > Signed-off-by: Lucas Tanure >> >> > --- >> >> >   drivers/i2c/busses/i2c-cadence.c | 12 ++++++++++-- >> >> >   1 file changed, 10 insertions(+), 2 deletions(-) >> >> > >> >> > diff --git a/drivers/i2c/busses/i2c-cadence.c > >> >> b/drivers/i2c/busses/i2c-cadence.c >> >> > index 805c77143a0f..b4c1ad19cdae 100644 >> >> > --- a/drivers/i2c/busses/i2c-cadence.c >> >> > +++ b/drivers/i2c/busses/i2c-cadence.c >> >> > @@ -760,7 +760,7 @@ static void cdns_i2c_master_reset(struct > >> >> i2c_adapter *adap) >> >> >   static int cdns_i2c_process_msg(struct cdns_i2c *id, struct >> i2c_msg >> > *msg, >> >> >           struct i2c_adapter *adap) >> >> >   { >> >> > -    unsigned long time_left; >> >> > +    unsigned long time_left, msg_timeout; >> >> >       u32 reg; >> >> >       id->p_msg = msg; >> >> > @@ -785,8 +785,16 @@ static int cdns_i2c_process_msg(struct >> cdns_i2c > >> *id, struct i2c_msg *msg, >> >> >       else >> >> >           cdns_i2c_msend(id); >> >> > +    /* Minimal time to execute this message */ >> >> > +    msg_timeout = msecs_to_jiffies((1000 * msg->len * >> BITS_PER_BYTE) >> > / id->i2c_clk); >> >> > +    /* Plus some wiggle room */ >> >> > +    msg_timeout += msecs_to_jiffies(500); >> >> > + >> >> > +    if (msg_timeout < adap->timeout) >> >> > +        msg_timeout = adap->timeout; >> >> > + >> >> >       /* Wait for the signal of completion */ >> >> > -    time_left = wait_for_completion_timeout(&id->xfer_done, > >> >> adap->timeout); >> >> > +    time_left = wait_for_completion_timeout(&id->xfer_done, > >> >> msg_timeout); >> >> >       if (time_left == 0) { >> >> >           cdns_i2c_master_reset(adap); >> >> >           dev_err(id->adap.dev.parent, >> >> >> >> >> >> If my assumption is right and there is any actual issue you had >> please >> send v2 and feel free to add there my: >> >> Acked-by: Michal Simek >> >> >> >> Thanks, >> >> Michal >> >> >> >> >> >> >> > The issue happens for I2C devices that have firmware, which will send > a >> big I2C message, but the I2C controller will timeout on it. >> > That happened for CS35L41 DSP firmware tests, so no particular > >> configuration, just a driver sending firmware blob over I2C. >> >> How big is it? >> >> M >> > The firmware has 33868 bytes, and it is split in a few writes. The first one to > time out has 20240 bytes: > > [   53.398444] cs35l41 0-0040: DSP1: Firmware version: 3 > [   53.403522] cs35l41 0-0040: DSP1: cs35l41-dsp1-spk-prot.wmfw: Fri 04 Feb 2022 > 12:01:42 W. Europe Standard Time > [   55.331688] cdns-i2c e0004000.i2c: timeout waiting on completion > [   55.336721] cs35l41 0-0040: DSP1: cs35l41-dsp1-spk-prot.wmfw.5: Failed to > write 20240 bytes at 0 in PM_PACKED: -110 > > 20240 bytes at 100k clock should take 1.6192 seconds, which is more than the > current timeout of one second. ok. thanks, Michal From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 045D7C433EF for ; Wed, 23 Mar 2022 11:03:42 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Content-Type: Content-Transfer-Encoding:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:From:References:To:Subject:MIME-Version: Date:Message-ID:Reply-To:Cc:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=MbIpLo9kW4vx923YgSn3Ac1MZRyIRFlzB9uWAMusJbI=; b=AmO5TPbinGRa1c4EAS5RX83vFb jAYVa2f8Z7ureFwp6eabTBjGLeU6TMnKZzunjBVGGDRSERkWBnOCsM5Fg1qdHV61fMx3JilS90giO jXaYby/1GQN8jqlM+ha54sBkJn9i3Wdtjkx5XfiOWBt5K5HPa6gPIulEq28/yw76DsWz2E/6YYauo 6tzhh4i3NPql0py2qBd1LgGZ80afDkDVnYeHA4J3ay0M1l2sL4Q97tExFwRwGublQh4UvE1X3ZsCE QnAbNGlSE6Lt6OzPO5EiXuC5LyT1OuR+tJornHq5M6Za7lfNL/6s+WHWtNhyw5PSR/HLlSJ5T3tZP c5lwRseA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1nWykv-00DOyT-Oi; Wed, 23 Mar 2022 11:02:21 +0000 Received: from mail-dm6nam11on2062c.outbound.protection.outlook.com ([2a01:111:f400:7eaa::62c] helo=NAM11-DM6-obe.outbound.protection.outlook.com) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1nWykr-00DOxq-UV for linux-arm-kernel@lists.infradead.org; Wed, 23 Mar 2022 11:02:19 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=lwu/OJuKRXi6e3piY6GT/eFbQ3FgZjsNVtAXSBWuUNyj3+oEAidGK5XvIG8s7DXYHo5k4PXmTFdo9xU7QflzFvYA4JXFDbjtpFhF2Z8rJh6APUqyLwwZTkJdUzsRgkmYKW4qfXBwDUe0UxcxHuG/hEcRNacb3KU4nV+XGSQnr4zK5vHWNfOzKHvOySK84n2krn8WRetkRd0xOk1TFEkyrKwquy6Nda/Pzr/eghVMPo58bgWcU0lmpqWUg2ti+HHaX9gk6C+++c1ZcZrdc312UQQz17zsXta7I3UluRO8f80Ql6/5EP20bzW6Zujzp9MF81yL8Hlyk2n2lafvPQhCog== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=CJCXoFEjg4nwvRNqinrWy2/0aVGKAnFjXx5ekNT0BKg=; b=ht1aT1jndKnH40HYUpkUtF4FntjE2t5Us5GgEc36ZbWtH20/8g7wIHvEyKhG2ABjcO8V31L9K7qRfhbFpUknyFjjXmz+0hvjnEEntlFV8+MbYjJH5hH+5BjuYwomycnImPPOtDzcDj9xQKhlldJDzsna/C5qqckPbBS2Wfj2F/j8Se7HF4ZF+G7yfEW5aylzS9F5dcPqBxm3l/EABf6XoC4kOP1tSyZUaiP240Q1wlKFqtkVfXYjhq4TZvyI1kq/OFa4T+rcYxNpWAT20GwRGOKdp0eYsVBmSvrq31wL21jqXxEgWjoiTVeQlHV72jm1jF1AK+V19hdF4AXhf/ZIyg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 149.199.62.198) smtp.rcpttodomain=opensource.cirrus.com smtp.mailfrom=xilinx.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=xilinx.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=xilinx.onmicrosoft.com; s=selector2-xilinx-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=CJCXoFEjg4nwvRNqinrWy2/0aVGKAnFjXx5ekNT0BKg=; b=B+OktkwYUYa7XzZhXKPfQgd7JHzNNei8inrbH/M2W+nuX68TAXWWc/0X4kTQfJyWwg7d+2P+KMOjuspF83i0bJMYCcBwTnjXXtXbiwRHZlQvfQGsQvZs26aro/C0s82CPddeBxMY4l8TMoogTZqho3pnLreJhE/rAsAnI0lI8kk= Received: from DM5PR21CA0059.namprd21.prod.outlook.com (2603:10b6:3:129::21) by DM8PR02MB8215.namprd02.prod.outlook.com (2603:10b6:8:e::5) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5081.19; Wed, 23 Mar 2022 11:02:13 +0000 Received: from DM3NAM02FT029.eop-nam02.prod.protection.outlook.com (2603:10b6:3:129:cafe::fc) by DM5PR21CA0059.outlook.office365.com (2603:10b6:3:129::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5123.7 via Frontend Transport; Wed, 23 Mar 2022 11:02:13 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 149.199.62.198) smtp.mailfrom=xilinx.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=xilinx.com; Received-SPF: Pass (protection.outlook.com: domain of xilinx.com designates 149.199.62.198 as permitted sender) receiver=protection.outlook.com; client-ip=149.199.62.198; helo=xsj-pvapexch01.xlnx.xilinx.com; Received: from xsj-pvapexch01.xlnx.xilinx.com (149.199.62.198) by DM3NAM02FT029.mail.protection.outlook.com (10.13.4.98) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.5102.17 via Frontend Transport; Wed, 23 Mar 2022 11:02:13 +0000 Received: from xsj-pvapexch02.xlnx.xilinx.com (172.19.86.41) by xsj-pvapexch01.xlnx.xilinx.com (172.19.86.40) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2176.14; Wed, 23 Mar 2022 04:02:11 -0700 Received: from smtp.xilinx.com (172.19.127.96) by xsj-pvapexch02.xlnx.xilinx.com (172.19.86.41) with Microsoft SMTP Server id 15.1.2176.14 via Frontend Transport; Wed, 23 Mar 2022 04:02:11 -0700 Received: from [10.254.241.50] (port=54338) by smtp.xilinx.com with esmtp (Exim 4.90) (envelope-from ) id 1nWykl-000DYN-95; Wed, 23 Mar 2022 04:02:11 -0700 Message-ID: <33ed666e-79aa-4779-43d6-4f2e82d91744@xilinx.com> Date: Wed, 23 Mar 2022 12:02:08 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.7.0 Subject: Re: [PATCH] i2c: cadence: Increase timeout per message if necessary Content-Language: en-US To: , Michal Simek , Shubhrajyoti Datta , , , , References: <20220309093147.102385-1-tanureal@opensource.cirrus.com> <4af9c968-b837-e984-1051-2dcd240f2c08@opensource.cirrus.com> <08dc1f90-586a-a47a-7c13-bce0405c13d6@xilinx.com> <3657b9ef-2c2e-82b1-1e2c-3d50c64d84b2@opensource.cirrus.com> From: Michal Simek In-Reply-To: <3657b9ef-2c2e-82b1-1e2c-3d50c64d84b2@opensource.cirrus.com> X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 31e4cf64-afa2-4a23-fc59-08da0cbc9601 X-MS-TrafficTypeDiagnostic: DM8PR02MB8215:EE_ X-Microsoft-Antispam-PRVS: X-Auto-Response-Suppress: DR, RN, NRN, OOF, AutoReply X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: DBfa2+vh4sscBfHLosdTAx9exx69OgNGS1hq9713JzvRtGJAGq7XiSMe6Ob0b4YyLEdJFBux7DpiA7UbtWDk2QVtfIWHgI/v4F1omxaib0rMbPSHpo2VLGbjTYuI03dzU9MeOx6BKY+UeZ5LW40mtlC0ZZbz9kGLpmDLY4HKCSVCME/S1pgZRRMbDCJFJE6I8EFbpXZRP/D8znFyFHwC1r908G5kJes4cM8ERp1biOE2haDT21KK5wDXhWLMtHqt28jHu1FmpBENGYi5WrwkuXZcGJBCQuzp2Epuck7MXAl0kGCdKHqMz5rLAetbSintgSAmnSyqFEFRvWAh1NfsXeW6soZ6rDeect+OcuFi9xe13ygBSrkr5lSXb2xXQP0pF+WeytbCnpNy+0HDr9/s5Snf8d67pZTmOalkvKLWK7dhPzfInYVlFwT2rS11u4EBHryis1JIs9NJe4d7QpwOnC4D7MfWUWyHMMHhkm5aoy1Uj6RhSyO5Ko8RIahQQbGzmqLkqwkytCYmUiHgVPSOdlVCtMHzNaBa01Ww8KHtSUj2TdiXjiTKmANqiLC4Nmp3aoxD7NbhLJDIFRyOXR4STk2A/SFx//bw3kDE6RfU7Ca4L+v1tUvq+3WqHtdGXUkHlLFtp3jQrXF8znza6NPQDjr7wjI71z9OAT1s5+nMKxgweI+8XSSELj9TpjkFTsBq6L1n/AXxJJS5PtA7QesLdKbWPsaU43Fh/J2UT8jxwOpCtVzWAYhquCufYbEl6Ghi X-Forefront-Antispam-Report: CIP:149.199.62.198; CTRY:US; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:xsj-pvapexch01.xlnx.xilinx.com; PTR:unknown-62-198.xilinx.com; CAT:NONE; SFS:(13230001)(4636009)(36840700001)(40470700004)(46966006)(8936002)(15650500001)(83380400001)(5660300002)(9786002)(36860700001)(82310400004)(44832011)(47076005)(336012)(110136005)(6666004)(316002)(2906002)(53546011)(26005)(426003)(186003)(508600001)(8676002)(2616005)(70586007)(70206006)(31696002)(40460700003)(31686004)(36756003)(356005)(7636003)(50156003)(43740500002)(2101003); DIR:OUT; SFP:1101; X-OriginatorOrg: xilinx.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 23 Mar 2022 11:02:13.5662 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 31e4cf64-afa2-4a23-fc59-08da0cbc9601 X-MS-Exchange-CrossTenant-Id: 657af505-d5df-48d0-8300-c31994686c5c X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=657af505-d5df-48d0-8300-c31994686c5c; Ip=[149.199.62.198]; Helo=[xsj-pvapexch01.xlnx.xilinx.com] X-MS-Exchange-CrossTenant-AuthSource: DM3NAM02FT029.eop-nam02.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM8PR02MB8215 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220323_040218_014286_D35FB007 X-CRM114-Status: GOOD ( 27.86 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: base64 Content-Type: text/plain; charset="utf-8"; Format="flowed" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org CgpPbiAzLzIzLzIyIDExOjA3LCB0YW51cmVhbEBvcGVuc291cmNlLmNpcnJ1cy5jb20gd3JvdGU6 Cj4gT24gMy8yMi8yMiA1OjE4IFBNLCBNaWNoYWwgU2ltZWsgPG1pY2hhbC5zaW1la0B4aWxpbngu Y29tPiB3cm90ZToKPj4KPj4KPj4gT24gMy8yMi8yMiAxNjozNCwgdGFudXJlYWxAb3BlbnNvdXJj ZS5jaXJydXMuY29tIHdyb3RlOgo+PiA+IE9uIDMvMjEvMjIgMzo1NyBQTSwgTWljaGFsIFNpbWVr IDxtaWNoYWwuc2ltZWtAeGlsaW54LmNvbT4gd3JvdGU6Cj4+ID4+ICtTaHViaHJhanlvdGkKPj4g Pj4KPj4gPj4gT24gMy85LzIyIDEwOjMxLCBMdWNhcyBUYW51cmUgd3JvdGU6Cj4+ID4+ID4gVGlt ZW91dCBhcyAxIHNlY29uZCBzZXRzIGEgdXBwZXIgbGltaXQgb24gdGhlIGxlbmd0aCBvZgo+PiA+ PiA+IHRoZSB0cmFuc2ZlciBleGVjdXRlZCwgYnV0IHRoZXJlIGlzIG5vIG1heGltdW0gbGVuZ3Ro IG9mCj4+ID4+ID4gYSB3cml0ZSBvciByZWFkIG1lc3NhZ2Ugc2V0IGluIGkyY19hZGFwdGVyX3F1 aXJrcyBmb3IgdGhpcwo+PiA+PiA+IGNvbnRyb2xsZXIuCj4+ID4+Cj4+ID4+IG5pdDogSSB3b3Vs ZCBleHBlY3QgdGhhdCB5b3UgaGF2ZSBydW4gYW55IHRlc3QgYW5kIHlvdSByZWFjaGVkIGFuIGlz c3VlLgo+PiA+PiBXb3VsZCBiZSBnb29kIHRvIGRlc2NyaWJlIHdoYXQgZXhhY3RseSB5b3UgaGF2 ZSB0cmllZCBvbiB3aGljaCA+PiAKPj4gY29uZmlndXJhdGlvbiB0byBtYWtlIGl0IHN1cGVyIGNs ZWFyLgo+PiA+Pgo+PiA+PiA+Cj4+ID4+ID4gVG8gcmVtb3ZlIHRoYXQgbGltaXRhdGlvbiBjYWxj dWxhdGUgdGhlIG1pbmltYWwgdGltZQo+PiA+PiA+IG5lY2Vzc2FyeSwgcGx1cyBzb21lIHdpZ2ds ZSByb29tLCBmb3IgZXZlcnkgbWVzc2FnZQo+PiA+PiA+IGFuZCB1c2UgaXQgaW5zdGVhZCBvZiB0 aGUgZGVmYXVsdCBvbmUgc2Vjb25kLCBpZgo+PiA+PiA+IG1vcmUgdGhhbiBvbmUgc2Vjb25kLgo+ PiA+PiA+Cj4+ID4+ID4gU2lnbmVkLW9mZi1ieTogTHVjYXMgVGFudXJlIDx0YW51cmVhbEBvcGVu c291cmNlLmNpcnJ1cy5jb20+Cj4+ID4+ID4gLS0tCj4+ID4+ID4gwqAgZHJpdmVycy9pMmMvYnVz c2VzL2kyYy1jYWRlbmNlLmMgfCAxMiArKysrKysrKysrLS0KPj4gPj4gPiDCoCAxIGZpbGUgY2hh bmdlZCwgMTAgaW5zZXJ0aW9ucygrKSwgMiBkZWxldGlvbnMoLSkKPj4gPj4gPgo+PiA+PiA+IGRp ZmYgLS1naXQgYS9kcml2ZXJzL2kyYy9idXNzZXMvaTJjLWNhZGVuY2UuYyA+ID4+IAo+PiBiL2Ry aXZlcnMvaTJjL2J1c3Nlcy9pMmMtY2FkZW5jZS5jCj4+ID4+ID4gaW5kZXggODA1Yzc3MTQzYTBm Li5iNGMxYWQxOWNkYWUgMTAwNjQ0Cj4+ID4+ID4gLS0tIGEvZHJpdmVycy9pMmMvYnVzc2VzL2ky Yy1jYWRlbmNlLmMKPj4gPj4gPiArKysgYi9kcml2ZXJzL2kyYy9idXNzZXMvaTJjLWNhZGVuY2Uu Ywo+PiA+PiA+IEBAIC03NjAsNyArNzYwLDcgQEAgc3RhdGljIHZvaWQgY2Ruc19pMmNfbWFzdGVy X3Jlc2V0KHN0cnVjdCA+ID4+IAo+PiBpMmNfYWRhcHRlciAqYWRhcCkKPj4gPj4gPiDCoCBzdGF0 aWMgaW50IGNkbnNfaTJjX3Byb2Nlc3NfbXNnKHN0cnVjdCBjZG5zX2kyYyAqaWQsIHN0cnVjdCA+ PiBpMmNfbXNnIAo+PiA+ICptc2csCj4+ID4+ID4gwqDCoMKgwqDCoMKgwqDCoMKgIHN0cnVjdCBp MmNfYWRhcHRlciAqYWRhcCkKPj4gPj4gPiDCoCB7Cj4+ID4+ID4gLcKgwqDCoCB1bnNpZ25lZCBs b25nIHRpbWVfbGVmdDsKPj4gPj4gPiArwqDCoMKgIHVuc2lnbmVkIGxvbmcgdGltZV9sZWZ0LCBt c2dfdGltZW91dDsKPj4gPj4gPiDCoMKgwqDCoMKgIHUzMiByZWc7Cj4+ID4+ID4gwqDCoMKgwqDC oCBpZC0+cF9tc2cgPSBtc2c7Cj4+ID4+ID4gQEAgLTc4NSw4ICs3ODUsMTYgQEAgc3RhdGljIGlu dCBjZG5zX2kyY19wcm9jZXNzX21zZyhzdHJ1Y3QgPj4gY2Ruc19pMmMgPiAKPj4gKmlkLCBzdHJ1 Y3QgaTJjX21zZyAqbXNnLAo+PiA+PiA+IMKgwqDCoMKgwqAgZWxzZQo+PiA+PiA+IMKgwqDCoMKg wqDCoMKgwqDCoCBjZG5zX2kyY19tc2VuZChpZCk7Cj4+ID4+ID4gK8KgwqDCoCAvKiBNaW5pbWFs IHRpbWUgdG8gZXhlY3V0ZSB0aGlzIG1lc3NhZ2UgKi8KPj4gPj4gPiArwqDCoMKgIG1zZ190aW1l b3V0ID0gbXNlY3NfdG9famlmZmllcygoMTAwMCAqIG1zZy0+bGVuICogPj4gQklUU19QRVJfQllU RSkgCj4+ID4gLyBpZC0+aTJjX2Nsayk7Cj4+ID4+ID4gK8KgwqDCoCAvKiBQbHVzIHNvbWUgd2ln Z2xlIHJvb20gKi8KPj4gPj4gPiArwqDCoMKgIG1zZ190aW1lb3V0ICs9IG1zZWNzX3RvX2ppZmZp ZXMoNTAwKTsKPj4gPj4gPiArCj4+ID4+ID4gK8KgwqDCoCBpZiAobXNnX3RpbWVvdXQgPCBhZGFw LT50aW1lb3V0KQo+PiA+PiA+ICvCoMKgwqDCoMKgwqDCoCBtc2dfdGltZW91dCA9IGFkYXAtPnRp bWVvdXQ7Cj4+ID4+ID4gKwo+PiA+PiA+IMKgwqDCoMKgwqAgLyogV2FpdCBmb3IgdGhlIHNpZ25h bCBvZiBjb21wbGV0aW9uICovCj4+ID4+ID4gLcKgwqDCoCB0aW1lX2xlZnQgPSB3YWl0X2Zvcl9j b21wbGV0aW9uX3RpbWVvdXQoJmlkLT54ZmVyX2RvbmUsID4gPj4gCj4+IGFkYXAtPnRpbWVvdXQp Owo+PiA+PiA+ICvCoMKgwqAgdGltZV9sZWZ0ID0gd2FpdF9mb3JfY29tcGxldGlvbl90aW1lb3V0 KCZpZC0+eGZlcl9kb25lLCA+ID4+IAo+PiBtc2dfdGltZW91dCk7Cj4+ID4+ID4gwqDCoMKgwqDC oCBpZiAodGltZV9sZWZ0ID09IDApIHsKPj4gPj4gPiDCoMKgwqDCoMKgwqDCoMKgwqAgY2Ruc19p MmNfbWFzdGVyX3Jlc2V0KGFkYXApOwo+PiA+PiA+IMKgwqDCoMKgwqDCoMKgwqDCoCBkZXZfZXJy KGlkLT5hZGFwLmRldi5wYXJlbnQsCj4+ID4+Cj4+ID4+Cj4+ID4+IElmIG15IGFzc3VtcHRpb24g aXMgcmlnaHQgYW5kIHRoZXJlIGlzIGFueSBhY3R1YWwgaXNzdWUgeW91IGhhZCA+PiBwbGVhc2Ug Cj4+IHNlbmQgdjIgYW5kIGZlZWwgZnJlZSB0byBhZGQgdGhlcmUgbXk6Cj4+ID4+IEFja2VkLWJ5 OiBNaWNoYWwgU2ltZWsgPG1pY2hhbC5zaW1la0B4aWxpbnguY29tPgo+PiA+Pgo+PiA+PiBUaGFu a3MsCj4+ID4+IE1pY2hhbAo+PiA+Pgo+PiA+Pgo+PiA+Pgo+PiA+IFRoZSBpc3N1ZSBoYXBwZW5z IGZvciBJMkMgZGV2aWNlcyB0aGF0IGhhdmUgZmlybXdhcmUsIHdoaWNoIHdpbGwgc2VuZCA+IGEg Cj4+IGJpZyBJMkMgbWVzc2FnZSwgYnV0IHRoZSBJMkMgY29udHJvbGxlciB3aWxsIHRpbWVvdXQg b24gaXQuCj4+ID4gVGhhdCBoYXBwZW5lZCBmb3IgQ1MzNUw0MSBEU1AgZmlybXdhcmUgdGVzdHMs IHNvIG5vIHBhcnRpY3VsYXIgPiAKPj4gY29uZmlndXJhdGlvbiwganVzdCBhIGRyaXZlciBzZW5k aW5nIGZpcm13YXJlIGJsb2Igb3ZlciBJMkMuCj4+Cj4+IEhvdyBiaWcgaXMgaXQ/Cj4+Cj4+IE0K Pj4KPiBUaGUgZmlybXdhcmUgaGFzIDMzODY4IGJ5dGVzLCBhbmQgaXQgaXMgc3BsaXQgaW4gYSBm ZXcgd3JpdGVzLiBUaGUgZmlyc3Qgb25lIHRvIAo+IHRpbWUgb3V0IGhhcyAyMDI0MCBieXRlczoK PiAKPiBbwqDCoCA1My4zOTg0NDRdIGNzMzVsNDEgMC0wMDQwOiBEU1AxOiBGaXJtd2FyZSB2ZXJz aW9uOiAzCj4gW8KgwqAgNTMuNDAzNTIyXSBjczM1bDQxIDAtMDA0MDogRFNQMTogY3MzNWw0MS1k c3AxLXNway1wcm90LndtZnc6IEZyaSAwNCBGZWIgMjAyMiAKPiAxMjowMTo0MiBXLiBFdXJvcGUg U3RhbmRhcmQgVGltZQo+IFvCoMKgIDU1LjMzMTY4OF0gY2Rucy1pMmMgZTAwMDQwMDAuaTJjOiB0 aW1lb3V0IHdhaXRpbmcgb24gY29tcGxldGlvbgo+IFvCoMKgIDU1LjMzNjcyMV0gY3MzNWw0MSAw LTAwNDA6IERTUDE6IGNzMzVsNDEtZHNwMS1zcGstcHJvdC53bWZ3LjU6IEZhaWxlZCB0byAKPiB3 cml0ZSAyMDI0MCBieXRlcyBhdCAwIGluIFBNX1BBQ0tFRDogLTExMAo+IAo+IDIwMjQwIGJ5dGVz IGF0IDEwMGsgY2xvY2sgc2hvdWxkIHRha2UgMS42MTkyIHNlY29uZHMsIHdoaWNoIGlzIG1vcmUg dGhhbiB0aGUgCj4gY3VycmVudCB0aW1lb3V0IG9mIG9uZSBzZWNvbmQuCgpvay4KCnRoYW5rcywK TWljaGFsCgpfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwps aW51eC1hcm0ta2VybmVsIG1haWxpbmcgbGlzdApsaW51eC1hcm0ta2VybmVsQGxpc3RzLmluZnJh ZGVhZC5vcmcKaHR0cDovL2xpc3RzLmluZnJhZGVhZC5vcmcvbWFpbG1hbi9saXN0aW5mby9saW51 eC1hcm0ta2VybmVsCg==