From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8BE12C47096 for ; Fri, 4 Jun 2021 01:03:19 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 60CC36140C for ; Fri, 4 Jun 2021 01:03:19 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229656AbhFDBFD (ORCPT ); Thu, 3 Jun 2021 21:05:03 -0400 Received: from mx0b-001b2d01.pphosted.com ([148.163.158.5]:48308 "EHLO mx0b-001b2d01.pphosted.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229576AbhFDBFD (ORCPT ); Thu, 3 Jun 2021 21:05:03 -0400 Received: from pps.filterd (m0127361.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.16.0.43/8.16.0.43) with SMTP id 1540XfXx155451; Thu, 3 Jun 2021 21:03:03 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ibm.com; h=message-id : subject : from : to : cc : date : in-reply-to : references : content-type : mime-version : content-transfer-encoding; s=pp1; bh=Bg64x1LwGm2bJ0pNp/NXlF0U0+7BtRh5DIhLzV45chs=; b=EnekVh4xSE9yKmoWSVBw4ZX/xK87i/9OOxKX/19SdwI+XiWDz9LxOwrGftnFfteqDx0C U63gHm4dqHh+WGfMq9hrahguRtofKpJz88q4TUehw7Q1wHWB+ERgQXTVc3okJsDJIBX6 NaBTyp3HKnHSfRL+BIgSb9gKk4Hd8mJBZjvm3V0NIPjhNzL4zmkqRZS7CsV8ZwXkONBX ic+qGF0qlUjYd/7g/aA7y3JdT3RnxX+mITg3DJFc2s7zR9zmzHzkwLVa1cKT+cHIJoVm uHIsONyi+mqYNsuGuXLSDOjxv/TsBD6ry5W7mLc5RO7z9d3k1BUdPE49X6FLoYqTx05A 4w== Received: from pps.reinject (localhost [127.0.0.1]) by mx0a-001b2d01.pphosted.com with ESMTP id 38y6v03ycd-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Thu, 03 Jun 2021 21:03:03 -0400 Received: from m0127361.ppops.net (m0127361.ppops.net [127.0.0.1]) by pps.reinject (8.16.0.43/8.16.0.43) with SMTP id 154118uL039708; Thu, 3 Jun 2021 21:03:03 -0400 Received: from ppma04dal.us.ibm.com (7a.29.35a9.ip4.static.sl-reverse.com [169.53.41.122]) by mx0a-001b2d01.pphosted.com with ESMTP id 38y6v03yc0-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Thu, 03 Jun 2021 21:03:03 -0400 Received: from pps.filterd (ppma04dal.us.ibm.com [127.0.0.1]) by ppma04dal.us.ibm.com (8.16.1.2/8.16.1.2) with SMTP id 1540vG2f002000; Fri, 4 Jun 2021 01:03:02 GMT Received: from b01cxnp22033.gho.pok.ibm.com (b01cxnp22033.gho.pok.ibm.com [9.57.198.23]) by ppma04dal.us.ibm.com with ESMTP id 38ud8af5qv-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Fri, 04 Jun 2021 01:03:02 +0000 Received: from b01ledav005.gho.pok.ibm.com (b01ledav005.gho.pok.ibm.com [9.57.199.110]) by b01cxnp22033.gho.pok.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id 154131mj19333446 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Fri, 4 Jun 2021 01:03:01 GMT Received: from b01ledav005.gho.pok.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id DCC79AE062; Fri, 4 Jun 2021 01:03:01 +0000 (GMT) Received: from b01ledav005.gho.pok.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id AC1DDAE060; Fri, 4 Jun 2021 01:03:00 +0000 (GMT) Received: from sig-9-77-136-17.ibm.com (unknown [9.77.136.17]) by b01ledav005.gho.pok.ibm.com (Postfix) with ESMTP; Fri, 4 Jun 2021 01:03:00 +0000 (GMT) Message-ID: <340144138c53ae83588edcf0b4a5ae1880a01cd0.camel@linux.ibm.com> Subject: Re: [PATCH v4 16/16] crypto/nx: Add sysfs interface to export NX capabilities From: Haren Myneni To: Nicholas Piggin , herbert@gondor.apana.org.au, linux-crypto@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, mpe@ellerman.id.au Cc: haren@us.ibm.com, hbabu@us.ibm.com Date: Thu, 03 Jun 2021 18:02:58 -0700 In-Reply-To: <1622696109.949hlg4tnq.astroid@bobo.none> References: <8d219c0816133a8643d650709066cf04c9c77322.camel@linux.ibm.com> <35bca44c5a8af7bdffbe03b22fd82713bced8d0e.camel@linux.ibm.com> <1622696109.949hlg4tnq.astroid@bobo.none> Content-Type: text/plain; charset="UTF-8" User-Agent: Evolution 3.36.2 (3.36.2-1.fc32) MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-TM-AS-GCONF: 00 X-Proofpoint-GUID: pXglEwrFhaFXkl-jxPOAGyg-iYP2wJZe X-Proofpoint-ORIG-GUID: AYYWK_395X9oToEf5P4r6QV8I2GhlSXI X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:6.0.391,18.0.761 definitions=2021-06-03_15:2021-06-03,2021-06-03 signatures=0 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 bulkscore=0 priorityscore=1501 lowpriorityscore=0 mlxlogscore=999 malwarescore=0 phishscore=0 spamscore=0 suspectscore=0 clxscore=1015 mlxscore=0 adultscore=0 impostorscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2104190000 definitions=main-2106040000 Precedence: bulk List-ID: X-Mailing-List: linux-crypto@vger.kernel.org On Thu, 2021-06-03 at 14:57 +1000, Nicholas Piggin wrote: > Excerpts from Haren Myneni's message of May 21, 2021 7:42 pm: > > Changes to export the following NXGZIP capabilities through sysfs: > > > > /sys/devices/vio/ibm,compression-v1/NxGzCaps: > > Where's the horrible camel case name coming from? PowerVM? Yes, pHyp provides the capabalities string. Capability Description Descriptor Value Descriptor ascii Value Overall NX Capabilities 0x4E78204361707320 “Nx Caps ” NX GZIP Capabilities 0x4E78477A43617073 “NxGzCaps” > > Thanks, > Nick > > > min_compress_len /*Recommended minimum compress length in bytes*/ > > min_decompress_len /*Recommended minimum decompress length in > > bytes*/ > > req_max_processed_len /* Maximum number of bytes processed in one > > request */ > > > > NX will return RMA_Reject if the request buffer size is greater > > than req_max_processed_len. > > > > Signed-off-by: Haren Myneni > > Acked-by: Herbert Xu > > --- > > drivers/crypto/nx/nx-common-pseries.c | 43 > > +++++++++++++++++++++++++++ > > 1 file changed, 43 insertions(+) > > > > diff --git a/drivers/crypto/nx/nx-common-pseries.c > > b/drivers/crypto/nx/nx-common-pseries.c > > index 4a7278464156..121718a337fd 100644 > > --- a/drivers/crypto/nx/nx-common-pseries.c > > +++ b/drivers/crypto/nx/nx-common-pseries.c > > @@ -968,6 +968,36 @@ static struct attribute_group > > nx842_attribute_group = { > > .attrs = nx842_sysfs_entries, > > }; > > > > +#define nxct_caps_read(_name) > > \ > > +static ssize_t nxct_##_name##_show(struct device *dev, > > \ > > + struct device_attribute *attr, char *buf) \ > > +{ > > \ > > + return sprintf(buf, "%lld\n", nx_ct_caps._name); \ > > +} > > + > > +#define NXCT_ATTR_RO(_name) > > \ > > + nxct_caps_read(_name); > > \ > > + static struct device_attribute dev_attr_##_name = __ATTR(_name, > > \ > > + 0444, > > \ > > + nxct_##_name##_show, > > \ > > + NULL); > > + > > +NXCT_ATTR_RO(req_max_processed_len); > > +NXCT_ATTR_RO(min_compress_len); > > +NXCT_ATTR_RO(min_decompress_len); > > + > > +static struct attribute *nxct_caps_sysfs_entries[] = { > > + &dev_attr_req_max_processed_len.attr, > > + &dev_attr_min_compress_len.attr, > > + &dev_attr_min_decompress_len.attr, > > + NULL, > > +}; > > + > > +static struct attribute_group nxct_caps_attr_group = { > > + .name = nx_ct_caps.name, > > + .attrs = nxct_caps_sysfs_entries, > > +}; > > + > > static struct nx842_driver nx842_pseries_driver = { > > .name = KBUILD_MODNAME, > > .owner = THIS_MODULE, > > @@ -1057,6 +1087,16 @@ static int nx842_probe(struct vio_dev > > *viodev, > > goto error; > > } > > > > + if (caps_feat) { > > + if (sysfs_create_group(&viodev->dev.kobj, > > + &nxct_caps_attr_group)) { > > + dev_err(&viodev->dev, > > + "Could not create sysfs NX capability > > entries\n"); > > + ret = -1; > > + goto error; > > + } > > + } > > + > > return 0; > > > > error_unlock: > > @@ -1076,6 +1116,9 @@ static void nx842_remove(struct vio_dev > > *viodev) > > pr_info("Removing IBM Power 842 compression device\n"); > > sysfs_remove_group(&viodev->dev.kobj, &nx842_attribute_group); > > > > + if (caps_feat) > > + sysfs_remove_group(&viodev->dev.kobj, > > &nxct_caps_attr_group); > > + > > crypto_unregister_alg(&nx842_pseries_alg); > > > > spin_lock_irqsave(&devdata_mutex, flags); > > -- > > 2.18.2 > > > > > > From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.6 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5B95DC47082 for ; Fri, 4 Jun 2021 01:03:48 +0000 (UTC) Received: from lists.ozlabs.org (lists.ozlabs.org [112.213.38.117]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 85A996120F for ; Fri, 4 Jun 2021 01:03:47 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 85A996120F Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linux.ibm.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=linuxppc-dev-bounces+linuxppc-dev=archiver.kernel.org@lists.ozlabs.org Received: from boromir.ozlabs.org (localhost [IPv6:::1]) by lists.ozlabs.org (Postfix) with ESMTP id 4Fx4Jy3Nh7z308H for ; Fri, 4 Jun 2021 11:03:46 +1000 (AEST) Authentication-Results: lists.ozlabs.org; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=ibm.com header.i=@ibm.com header.a=rsa-sha256 header.s=pp1 header.b=EnekVh4x; dkim-atps=neutral Authentication-Results: lists.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=linux.ibm.com (client-ip=148.163.158.5; helo=mx0b-001b2d01.pphosted.com; envelope-from=haren@linux.ibm.com; receiver=) Authentication-Results: lists.ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=ibm.com header.i=@ibm.com header.a=rsa-sha256 header.s=pp1 header.b=EnekVh4x; dkim-atps=neutral Received: from mx0b-001b2d01.pphosted.com (mx0b-001b2d01.pphosted.com [148.163.158.5]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 4Fx4JN6ltQz2yhf for ; Fri, 4 Jun 2021 11:03:16 +1000 (AEST) Received: from pps.filterd (m0127361.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.16.0.43/8.16.0.43) with SMTP id 1540XfXx155451; Thu, 3 Jun 2021 21:03:03 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ibm.com; h=message-id : subject : from : to : cc : date : in-reply-to : references : content-type : mime-version : content-transfer-encoding; s=pp1; bh=Bg64x1LwGm2bJ0pNp/NXlF0U0+7BtRh5DIhLzV45chs=; b=EnekVh4xSE9yKmoWSVBw4ZX/xK87i/9OOxKX/19SdwI+XiWDz9LxOwrGftnFfteqDx0C U63gHm4dqHh+WGfMq9hrahguRtofKpJz88q4TUehw7Q1wHWB+ERgQXTVc3okJsDJIBX6 NaBTyp3HKnHSfRL+BIgSb9gKk4Hd8mJBZjvm3V0NIPjhNzL4zmkqRZS7CsV8ZwXkONBX ic+qGF0qlUjYd/7g/aA7y3JdT3RnxX+mITg3DJFc2s7zR9zmzHzkwLVa1cKT+cHIJoVm uHIsONyi+mqYNsuGuXLSDOjxv/TsBD6ry5W7mLc5RO7z9d3k1BUdPE49X6FLoYqTx05A 4w== Received: from pps.reinject (localhost [127.0.0.1]) by mx0a-001b2d01.pphosted.com with ESMTP id 38y6v03ycd-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Thu, 03 Jun 2021 21:03:03 -0400 Received: from m0127361.ppops.net (m0127361.ppops.net [127.0.0.1]) by pps.reinject (8.16.0.43/8.16.0.43) with SMTP id 154118uL039708; Thu, 3 Jun 2021 21:03:03 -0400 Received: from ppma04dal.us.ibm.com (7a.29.35a9.ip4.static.sl-reverse.com [169.53.41.122]) by mx0a-001b2d01.pphosted.com with ESMTP id 38y6v03yc0-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Thu, 03 Jun 2021 21:03:03 -0400 Received: from pps.filterd (ppma04dal.us.ibm.com [127.0.0.1]) by ppma04dal.us.ibm.com (8.16.1.2/8.16.1.2) with SMTP id 1540vG2f002000; Fri, 4 Jun 2021 01:03:02 GMT Received: from b01cxnp22033.gho.pok.ibm.com (b01cxnp22033.gho.pok.ibm.com [9.57.198.23]) by ppma04dal.us.ibm.com with ESMTP id 38ud8af5qv-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Fri, 04 Jun 2021 01:03:02 +0000 Received: from b01ledav005.gho.pok.ibm.com (b01ledav005.gho.pok.ibm.com [9.57.199.110]) by b01cxnp22033.gho.pok.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id 154131mj19333446 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Fri, 4 Jun 2021 01:03:01 GMT Received: from b01ledav005.gho.pok.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id DCC79AE062; Fri, 4 Jun 2021 01:03:01 +0000 (GMT) Received: from b01ledav005.gho.pok.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id AC1DDAE060; Fri, 4 Jun 2021 01:03:00 +0000 (GMT) Received: from sig-9-77-136-17.ibm.com (unknown [9.77.136.17]) by b01ledav005.gho.pok.ibm.com (Postfix) with ESMTP; Fri, 4 Jun 2021 01:03:00 +0000 (GMT) Message-ID: <340144138c53ae83588edcf0b4a5ae1880a01cd0.camel@linux.ibm.com> Subject: Re: [PATCH v4 16/16] crypto/nx: Add sysfs interface to export NX capabilities From: Haren Myneni To: Nicholas Piggin , herbert@gondor.apana.org.au, linux-crypto@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, mpe@ellerman.id.au Date: Thu, 03 Jun 2021 18:02:58 -0700 In-Reply-To: <1622696109.949hlg4tnq.astroid@bobo.none> References: <8d219c0816133a8643d650709066cf04c9c77322.camel@linux.ibm.com> <35bca44c5a8af7bdffbe03b22fd82713bced8d0e.camel@linux.ibm.com> <1622696109.949hlg4tnq.astroid@bobo.none> Content-Type: text/plain; charset="UTF-8" User-Agent: Evolution 3.36.2 (3.36.2-1.fc32) MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-TM-AS-GCONF: 00 X-Proofpoint-GUID: pXglEwrFhaFXkl-jxPOAGyg-iYP2wJZe X-Proofpoint-ORIG-GUID: AYYWK_395X9oToEf5P4r6QV8I2GhlSXI X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:6.0.391, 18.0.761 definitions=2021-06-03_15:2021-06-03, 2021-06-03 signatures=0 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 bulkscore=0 priorityscore=1501 lowpriorityscore=0 mlxlogscore=999 malwarescore=0 phishscore=0 spamscore=0 suspectscore=0 clxscore=1015 mlxscore=0 adultscore=0 impostorscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2104190000 definitions=main-2106040000 X-BeenThere: linuxppc-dev@lists.ozlabs.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: linuxppc-dev-bounces+linuxppc-dev=archiver.kernel.org@lists.ozlabs.org Sender: "Linuxppc-dev" On Thu, 2021-06-03 at 14:57 +1000, Nicholas Piggin wrote: > Excerpts from Haren Myneni's message of May 21, 2021 7:42 pm: > > Changes to export the following NXGZIP capabilities through sysfs: > > > > /sys/devices/vio/ibm,compression-v1/NxGzCaps: > > Where's the horrible camel case name coming from? PowerVM? Yes, pHyp provides the capabalities string. Capability Description Descriptor Value Descriptor ascii Value Overall NX Capabilities 0x4E78204361707320 “Nx Caps ” NX GZIP Capabilities 0x4E78477A43617073 “NxGzCaps” > > Thanks, > Nick > > > min_compress_len /*Recommended minimum compress length in bytes*/ > > min_decompress_len /*Recommended minimum decompress length in > > bytes*/ > > req_max_processed_len /* Maximum number of bytes processed in one > > request */ > > > > NX will return RMA_Reject if the request buffer size is greater > > than req_max_processed_len. > > > > Signed-off-by: Haren Myneni > > Acked-by: Herbert Xu > > --- > > drivers/crypto/nx/nx-common-pseries.c | 43 > > +++++++++++++++++++++++++++ > > 1 file changed, 43 insertions(+) > > > > diff --git a/drivers/crypto/nx/nx-common-pseries.c > > b/drivers/crypto/nx/nx-common-pseries.c > > index 4a7278464156..121718a337fd 100644 > > --- a/drivers/crypto/nx/nx-common-pseries.c > > +++ b/drivers/crypto/nx/nx-common-pseries.c > > @@ -968,6 +968,36 @@ static struct attribute_group > > nx842_attribute_group = { > > .attrs = nx842_sysfs_entries, > > }; > > > > +#define nxct_caps_read(_name) > > \ > > +static ssize_t nxct_##_name##_show(struct device *dev, > > \ > > + struct device_attribute *attr, char *buf) \ > > +{ > > \ > > + return sprintf(buf, "%lld\n", nx_ct_caps._name); \ > > +} > > + > > +#define NXCT_ATTR_RO(_name) > > \ > > + nxct_caps_read(_name); > > \ > > + static struct device_attribute dev_attr_##_name = __ATTR(_name, > > \ > > + 0444, > > \ > > + nxct_##_name##_show, > > \ > > + NULL); > > + > > +NXCT_ATTR_RO(req_max_processed_len); > > +NXCT_ATTR_RO(min_compress_len); > > +NXCT_ATTR_RO(min_decompress_len); > > + > > +static struct attribute *nxct_caps_sysfs_entries[] = { > > + &dev_attr_req_max_processed_len.attr, > > + &dev_attr_min_compress_len.attr, > > + &dev_attr_min_decompress_len.attr, > > + NULL, > > +}; > > + > > +static struct attribute_group nxct_caps_attr_group = { > > + .name = nx_ct_caps.name, > > + .attrs = nxct_caps_sysfs_entries, > > +}; > > + > > static struct nx842_driver nx842_pseries_driver = { > > .name = KBUILD_MODNAME, > > .owner = THIS_MODULE, > > @@ -1057,6 +1087,16 @@ static int nx842_probe(struct vio_dev > > *viodev, > > goto error; > > } > > > > + if (caps_feat) { > > + if (sysfs_create_group(&viodev->dev.kobj, > > + &nxct_caps_attr_group)) { > > + dev_err(&viodev->dev, > > + "Could not create sysfs NX capability > > entries\n"); > > + ret = -1; > > + goto error; > > + } > > + } > > + > > return 0; > > > > error_unlock: > > @@ -1076,6 +1116,9 @@ static void nx842_remove(struct vio_dev > > *viodev) > > pr_info("Removing IBM Power 842 compression device\n"); > > sysfs_remove_group(&viodev->dev.kobj, &nx842_attribute_group); > > > > + if (caps_feat) > > + sysfs_remove_group(&viodev->dev.kobj, > > &nxct_caps_attr_group); > > + > > crypto_unregister_alg(&nx842_pseries_alg); > > > > spin_lock_irqsave(&devdata_mutex, flags); > > -- > > 2.18.2 > > > > > >