From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 24CFEC05027 for ; Mon, 6 Feb 2023 23:41:58 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 463AF859CD; Tue, 7 Feb 2023 00:41:56 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=canonical.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (2048-bit key; unprotected) header.d=canonical.com header.i=@canonical.com header.b="BUTEKhMp"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id AAD3F85CD0; Tue, 7 Feb 2023 00:41:54 +0100 (CET) Received: from smtp-relay-internal-1.canonical.com (smtp-relay-internal-1.canonical.com [185.125.188.123]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 1704085631 for ; Tue, 7 Feb 2023 00:41:52 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=canonical.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=heinrich.schuchardt@canonical.com Received: from mail-wm1-f69.google.com (mail-wm1-f69.google.com [209.85.128.69]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by smtp-relay-internal-1.canonical.com (Postfix) with ESMTPS id A57E43F2D2 for ; Mon, 6 Feb 2023 23:41:51 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=canonical.com; s=20210705; t=1675726911; bh=co/C0I8LDIVoGALuA15iMeu65/lfB6nHxLpFBVdGEOQ=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=BUTEKhMpSo++udSuT9rfumVy8ZB0nMRNiewMarf7xzBii51T6u0clghOpZrTkCMC7 CCESWywjTyRjc8LgRo437r3P6EpeDaUS9Yscm7PXsBXCR/ho2wgnX2aI36/+BBX+d+ 1ZATva62eEsbt8gAB5k6X5VXQWvkpj8fl4qDT9RD5gIpAzTe+vQuSMqsA3esoLZHRY t5R9h35LmQwlJ7lUQs75kxcvVL3fLdpC8ylAsG8lc59BnfRGELjWa59tXarUf1nxn0 kXRXcCW0vFG4VaS5Kzy1c7KcuKbzmsrBGNeUHHW4v2Wu5shew/xx51nmWaOj+bt5mz L9FbA4pog6wqQ== Received: by mail-wm1-f69.google.com with SMTP id k9-20020a05600c1c8900b003dc5dec2ac6so9700225wms.4 for ; Mon, 06 Feb 2023 15:41:51 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=co/C0I8LDIVoGALuA15iMeu65/lfB6nHxLpFBVdGEOQ=; b=0h/SfFVZ+s35WVzC9FM5mY+ZmeV1TDD8XS4zpoO5pt91DCrIIIIDOe1UDxjdE5pMvC 4qj3sKm3zESRbNdK7ATjw2WPSYlRWIPQG3xE63p5RiFIZpjXVmOVxM0a8BFqel1pqdM5 yGxWi4cn0PKUaAQJCSBh1lbGO8W+oN5FAoylWTj+99Q1hg5BCO6SFTsLRRa5dvpXvNom x4c8Sj/KX5fP71hnpJ3z0jggJsFeBn2B9ehZt/XjdzX65NR5HuAP6G3nRHQyyyMMKpFP 64p2BC8MX/vtZhS4MUCKsr9RHZaejDPMo85tOYfza+wUdlNZ/9Cb6WtlgkIsQ2PPCK9I Zvsg== X-Gm-Message-State: AO0yUKVRpxTyKVJvA/aN6LzL2PwirJYz4D4VC4NNqUrWqNi4KkuQ8jOD zhW57EpZif7G7RJpHeeQbfy1M9cMASVhcgLV9mQFPl7sn0N8zBM+sr7/GsF4X0LWLGrSUYKEGRf LazBTV69h95YPro+VygPy7nC3n+fl4J8= X-Received: by 2002:a05:600c:3093:b0:3df:fbd5:690 with SMTP id g19-20020a05600c309300b003dffbd50690mr1242709wmn.17.1675726911326; Mon, 06 Feb 2023 15:41:51 -0800 (PST) X-Google-Smtp-Source: AK7set/fgzm7IQoFRoyXN+2vSYw2kWXRcrRFT+nDJ7YGtq2sXT634wy/NmYkZsG8eesTsmLkYB2YUA== X-Received: by 2002:a05:600c:3093:b0:3df:fbd5:690 with SMTP id g19-20020a05600c309300b003dffbd50690mr1242703wmn.17.1675726911099; Mon, 06 Feb 2023 15:41:51 -0800 (PST) Received: from [192.168.123.94] (ip-088-152-145-137.um26.pools.vodafone-ip.de. [88.152.145.137]) by smtp.gmail.com with ESMTPSA id p16-20020a5d4e10000000b002c3e4bec4dbsm4963761wrt.89.2023.02.06.15.41.50 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 06 Feb 2023 15:41:50 -0800 (PST) Message-ID: <3406645c-21ee-1faa-b97e-369d83c4ef42@canonical.com> Date: Tue, 7 Feb 2023 00:41:50 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.7.1 Subject: Re: [PATCH v2 077/169] Correct SPL use of EFI_TCG2_PROTOCOL Content-Language: en-US To: Simon Glass Cc: Tom Rini , U-Boot Mailing List References: <20230205224118.233425-63-sjg@chromium.org> <20230205224118.233425-78-sjg@chromium.org> From: Heinrich Schuchardt In-Reply-To: <20230205224118.233425-78-sjg@chromium.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.6 at phobos.denx.de X-Virus-Status: Clean On 2/5/23 23:39, Simon Glass wrote: > This converts 1 usage of this option to the non-SPL form, since there is > no SPL_EFI_TCG2_PROTOCOL defined in Kconfig Why do you touch the code? I can't see any problem being solved. Best regards Heinrich > > Signed-off-by: Simon Glass > --- > > (no changes since v1) > > lib/efi_loader/efi_image_loader.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/lib/efi_loader/efi_image_loader.c b/lib/efi_loader/efi_image_loader.c > index eaf75a5803d..26df0da16c9 100644 > --- a/lib/efi_loader/efi_image_loader.c > +++ b/lib/efi_loader/efi_image_loader.c > @@ -938,7 +938,7 @@ efi_status_t efi_load_pe(struct efi_loaded_image_obj *handle, > goto err; > } > > -#if CONFIG_IS_ENABLED(EFI_TCG2_PROTOCOL) > +#if IS_ENABLED(CONFIG_EFI_TCG2_PROTOCOL) > /* Measure an PE/COFF image */ > ret = tcg2_measure_pe_image(efi, efi_size, handle, loaded_image_info); > if (ret == EFI_SECURITY_VIOLATION) {