All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Rafael J. Wysocki" <rjw@rjwysocki.net>
To: Dan Williams <dan.j.williams@intel.com>
Cc: Vishal Verma <vishal.l.verma@intel.com>,
	"linux-nvdimm@lists.01.org" <linux-nvdimm@lists.01.org>,
	"Rafael J. Wysocki" <rafael.j.wysocki@intel.com>,
	Linux ACPI <linux-acpi@vger.kernel.org>,
	Jeff Moyer <jmoyer@redhat.com>, Elliott Robert <elliott@hpe.com>,
	Toshi Kani <toshi.kani@hpe.com>
Subject: Re: [PATCH v3 2/2] acpi: nfit: Add support for hot-add
Date: Mon, 09 Nov 2015 22:25:17 +0100	[thread overview]
Message-ID: <3407281.JKJqFNJUkI@vostro.rjw.lan> (raw)
In-Reply-To: <CAPcyv4h-OqKcY50Nfb5XQyfxCPQqWs+j4hgkG20bJiUr1ue26g@mail.gmail.com>

On Monday, November 09, 2015 10:25:10 AM Dan Williams wrote:
> On Sun, Nov 8, 2015 at 5:26 PM, Dan Williams <dan.j.williams@intel.com> wrote:
> > On Sun, Nov 8, 2015 at 4:49 PM, Rafael J. Wysocki <rjw@rjwysocki.net> wrote:
> >> On Saturday, November 07, 2015 10:57:17 AM Dan Williams wrote:
> >>> Rafael, awaiting your ack...
> >>
> >> Well, this seems to be entirely NFIT-related.
> >>
> >> Is there anything in particular you want me to look at?
> >>
> >
> > This might be more relevant for a follow-on patch, but I wonder if the
> > core should be guaranteeing that the ->notify() callback occurs under
> > device_lock().  In the case of NFIT it seems possible for the notify
> > event to race ->add() or ->remove(), but maybe I missed some other
> > guarantee?
> 
> ...and no worries if you don't see anything worth commenting on, the
> bulk of this is indeed NFIT specific.

I actually don't see anything objectionable in it, although admittedly I've
just had a cursorly look at it.

Thanks,
Rafael


  reply	other threads:[~2015-11-09 20:55 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-10-27 22:58 [PATCH v3 0/2] Hotplug support for libnvdimm Vishal Verma
2015-10-27 22:58 ` [PATCH v3 1/2] nfit: in acpi_nfit_init, break on a 0-length table Vishal Verma
2015-10-27 22:58 ` [PATCH v3 2/2] acpi: nfit: Add support for hot-add Vishal Verma
2015-11-07 18:57   ` Dan Williams
2015-11-07 21:20     ` Dan Williams
2015-11-09 18:12       ` Verma, Vishal L
2015-11-09 18:23         ` Dan Williams
2015-11-09  0:49     ` Rafael J. Wysocki
2015-11-09  1:26       ` Dan Williams
2015-11-09 18:25         ` Dan Williams
2015-11-09 21:25           ` Rafael J. Wysocki [this message]
2015-11-09 21:24         ` Rafael J. Wysocki
2015-11-09 21:28           ` Rafael J. Wysocki

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=3407281.JKJqFNJUkI@vostro.rjw.lan \
    --to=rjw@rjwysocki.net \
    --cc=dan.j.williams@intel.com \
    --cc=elliott@hpe.com \
    --cc=jmoyer@redhat.com \
    --cc=linux-acpi@vger.kernel.org \
    --cc=linux-nvdimm@lists.01.org \
    --cc=rafael.j.wysocki@intel.com \
    --cc=toshi.kani@hpe.com \
    --cc=vishal.l.verma@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.