From: "Rafael J. Wysocki" <rjw@rjwysocki.net>
To: Jeffy Chen <jeffy.chen@rock-chips.com>, gregkh@linuxfoundation.org
Cc: linux-kernel@vger.kernel.org, briannorris@chromium.org,
heiko@sntech.de, dmitry.torokhov@gmail.com,
dianders@chromium.org, tfiga@chromium.org, broonie@kernel.org,
seanpaul@chromium.org, thierry.reding@gmail.com
Subject: Re: [PATCH v3] driver core: Move device_links_purge() after bus_remove_device()
Date: Fri, 20 Oct 2017 03:22:07 +0200 [thread overview]
Message-ID: <3413769.dlVTNxayVy@aspire.rjw.lan> (raw)
In-Reply-To: <20171020012316.30154-1-jeffy.chen@rock-chips.com>
On Friday, October 20, 2017 3:23:16 AM CEST Jeffy Chen wrote:
> The current ordering of code in device_del() triggers a WARN_ON()
> in device_links_purge(), because of an unexpected link status.
>
> The device_links_unbind_consumers() call in device_release_driver()
> has to take place before device_links_purge() for the status of all
> links to be correct, so move the device_links_purge() call in
> device_del() after the invocation of bus_remove_device() which calls
> device_release_driver().
>
> Signed-off-by: Jeffy Chen <jeffy.chen@rock-chips.com>
> Reviewed-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
OK, thanks.
Greg, will you take this?
> ---
>
> Changes in v3:
> Remove wrong signed-off-by.
>
> Changes in v2:
> Update commit message provided by Rafael.
>
> drivers/base/core.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/base/core.c b/drivers/base/core.c
> index 12ebd055724c..2e683cdf4a08 100644
> --- a/drivers/base/core.c
> +++ b/drivers/base/core.c
> @@ -1958,7 +1958,6 @@ void device_del(struct device *dev)
> blocking_notifier_call_chain(&dev->bus->p->bus_notifier,
> BUS_NOTIFY_DEL_DEVICE, dev);
>
> - device_links_purge(dev);
> dpm_sysfs_remove(dev);
> if (parent)
> klist_del(&dev->p->knode_parent);
> @@ -1986,6 +1985,7 @@ void device_del(struct device *dev)
> device_pm_remove(dev);
> driver_deferred_probe_del(dev);
> device_remove_properties(dev);
> + device_links_purge(dev);
>
> /* Notify the platform of the removal, in case they
> * need to do anything...
>
next prev parent reply other threads:[~2017-10-20 1:31 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-10-20 1:23 [PATCH v3] driver core: Move device_links_purge() after bus_remove_device() Jeffy Chen
2017-10-20 1:22 ` Rafael J. Wysocki [this message]
2017-10-20 6:22 ` Greg KH
2017-10-20 11:17 ` Rafael J. Wysocki
2017-10-20 12:01 ` jeffy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3413769.dlVTNxayVy@aspire.rjw.lan \
--to=rjw@rjwysocki.net \
--cc=briannorris@chromium.org \
--cc=broonie@kernel.org \
--cc=dianders@chromium.org \
--cc=dmitry.torokhov@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=heiko@sntech.de \
--cc=jeffy.chen@rock-chips.com \
--cc=linux-kernel@vger.kernel.org \
--cc=seanpaul@chromium.org \
--cc=tfiga@chromium.org \
--cc=thierry.reding@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.