All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Rafael J. Wysocki" <rjw@rjwysocki.net>
To: Linux ACPI <linux-acpi@vger.kernel.org>
Cc: LKML <linux-kernel@vger.kernel.org>,
	Hans de Goede <hdegoede@redhat.com>,
	Mark Gross <mgross@linux.intel.com>,
	Maximilian Luz <luzmaximilian@gmail.com>,
	platform-driver-x86@vger.kernel.org
Subject: [PATCH v1 4/7] surface: surface3-wmi: Use ACPI_COMPANION() directly
Date: Tue, 12 Oct 2021 19:44:42 +0200	[thread overview]
Message-ID: <3414042.iIbC2pHGDl@kreacher> (raw)
In-Reply-To: <4369779.LvFx2qVVIh@kreacher>

From: Rafael J. Wysocki <rafael@kernel.org>

The ACPI_HANDLE() macro is a wrapper arond the ACPI_COMPANION()
macro and the ACPI handle produced by the former comes from the
ACPI device object produced by the latter, so it is way more
straightforward to evaluate the latter directly instead of passing
the handle produced by the former to acpi_bus_get_device().

Modify s3_wmi_check_platform_device() accordingly (no intentional
functional impact).

Signed-off-by: Rafael J. Wysocki <rafael@kernel.org>
---
 drivers/platform/surface/surface3-wmi.c |    9 ++++-----
 1 file changed, 4 insertions(+), 5 deletions(-)

Index: linux-pm/drivers/platform/surface/surface3-wmi.c
===================================================================
--- linux-pm.orig/drivers/platform/surface/surface3-wmi.c
+++ linux-pm/drivers/platform/surface/surface3-wmi.c
@@ -139,13 +139,12 @@ static acpi_status s3_wmi_attach_spi_dev
 
 static int s3_wmi_check_platform_device(struct device *dev, void *data)
 {
-	struct acpi_device *adev, *ts_adev = NULL;
-	acpi_handle handle;
+	struct acpi_device *adev = ACPI_COMPANION(dev);
+	struct acpi_device *ts_adev = NULL;
 	acpi_status status;
 
 	/* ignore non ACPI devices */
-	handle = ACPI_HANDLE(dev);
-	if (!handle || acpi_bus_get_device(handle, &adev))
+	if (!adev)
 		return 0;
 
 	/* check for LID ACPI switch */
@@ -159,7 +158,7 @@ static int s3_wmi_check_platform_device(
 	    strlen(SPI_CTL_OBJ_NAME)))
 		return 0;
 
-	status = acpi_walk_namespace(ACPI_TYPE_DEVICE, handle, 1,
+	status = acpi_walk_namespace(ACPI_TYPE_DEVICE, adev->handle, 1,
 				     s3_wmi_attach_spi_device, NULL,
 				     &ts_adev, NULL);
 	if (ACPI_FAILURE(status))




  parent reply	other threads:[~2021-10-12 17:51 UTC|newest]

Thread overview: 31+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-10-12 17:35 [PATCH v1 0/7] ACPI: Use ACPI_COMPANION() directly to simplify code Rafael J. Wysocki
2021-10-12 17:44 ` [PATCH v1 1/7] gpio-amdpt: ACPI: Use the ACPI_COMPANION() macro directly Rafael J. Wysocki
2021-10-13 14:44   ` Bartosz Golaszewski
2021-10-13 16:06   ` [PATCH v2 " Rafael J. Wysocki
2021-10-12 17:44 ` [PATCH v1 2/7] nouveau: " Rafael J. Wysocki
2021-10-12 17:44   ` [Nouveau] " Rafael J. Wysocki
2021-10-12 22:04   ` Ben Skeggs
2021-10-12 22:04     ` [Nouveau] " Ben Skeggs
2021-10-13 16:08   ` [PATCH v2 " Rafael J. Wysocki
2021-10-13 16:08     ` [Nouveau] " Rafael J. Wysocki
2021-10-12 17:44 ` [PATCH v1 3/7] i2c: i2c-amd-mp2-plat: ACPI: Use ACPI_COMPANION() directly Rafael J. Wysocki
2021-10-12 18:12   ` Shyam Sundar S K
2021-10-13 16:09   ` [PATCH v2 " Rafael J. Wysocki
2021-10-17 14:22     ` Wolfram Sang
2021-10-12 17:44 ` Rafael J. Wysocki [this message]
2021-10-12 18:13   ` [PATCH v1 4/7] surface: surface3-wmi: " Maximilian Luz
2021-10-13 16:10   ` [PATCH v2 " Rafael J. Wysocki
2021-10-19 14:56     ` Hans de Goede
2021-10-12 17:46 ` [PATCH v1 5/7] surface: surface3_power: " Rafael J. Wysocki
2021-10-12 18:21   ` Maximilian Luz
2021-10-12 19:11     ` Rafael J. Wysocki
2021-10-12 19:32   ` [PATCH v2 5/7] surface: surface3_power: Drop redundant acpi_bus_get_device() call Rafael J. Wysocki
2021-10-12 19:40     ` Maximilian Luz
2021-10-13 16:12     ` [PATCH v3 " Rafael J. Wysocki
2021-10-19 14:56       ` Hans de Goede
2021-10-12 17:48 ` [PATCH v1 6/7] platform: x86: ideapad-laptop: Use ACPI_COMPANION() directly Rafael J. Wysocki
2021-10-13 16:13   ` [PATCH v2 " Rafael J. Wysocki
2021-10-19 14:57     ` Hans de Goede
2021-10-12 17:50 ` [PATCH v1 7/7] perf: qcom_l2_pmu: ACPI: " Rafael J. Wysocki
2021-10-13 16:15   ` [PATCH v2 " Rafael J. Wysocki
2021-10-26 13:41     ` Rafael J. Wysocki

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=3414042.iIbC2pHGDl@kreacher \
    --to=rjw@rjwysocki.net \
    --cc=hdegoede@redhat.com \
    --cc=linux-acpi@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=luzmaximilian@gmail.com \
    --cc=mgross@linux.intel.com \
    --cc=platform-driver-x86@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.