From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754087AbcAFLA2 (ORCPT ); Wed, 6 Jan 2016 06:00:28 -0500 Received: from galahad.ideasonboard.com ([185.26.127.97]:38092 "EHLO galahad.ideasonboard.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752677AbcAFLAY (ORCPT ); Wed, 6 Jan 2016 06:00:24 -0500 From: Laurent Pinchart To: Javier Martinez Canillas Cc: linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, Mauro Carvalho Chehab , Enrico Butera , Sakari Ailus , Enric Balletbo i Serra , Rob Herring , Eduard Gavin , Hans Verkuil , linux-media@vger.kernel.org Subject: Re: [PATCH 07/10] [media] tvp5150: Add device tree binding document Date: Wed, 06 Jan 2016 13:00:31 +0200 Message-ID: <3433197.yOemOv0bmo@avalon> User-Agent: KMail/4.14.8 (Linux/4.1.12-gentoo; KDE/4.14.8; x86_64; ; ) In-Reply-To: <568CF08B.6080107@osg.samsung.com> References: <1451910332-23385-1-git-send-email-javier@osg.samsung.com> <2787681.imkQ5NT8Qm@avalon> <568CF08B.6080107@osg.samsung.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wednesday 06 January 2016 07:46:35 Javier Martinez Canillas wrote: > On 01/06/2016 07:39 AM, Laurent Pinchart wrote: > > Hi Javier, > > > > Thank you for the patch. > > Thanks a lot for your feedback. > > [snip] > > >> + > >> +Optional Properties: > >> +- powerdown-gpios: phandle for the GPIO connected to the PDN pin, if > >> any. > > > > The signal is called PDN in the datasheet, so it might make sense to call > > this pdn-gpios. I have no strong opinion on this, I'll let you decide > > what you think is best. > > Yes, I wondered if the convention was to use a descriptive name or the one > used in the datasheet but Documentation/devicetree/bindings/gpio/gpio.txt > says nothing about it. The device tree maintainers might want to comment on that :-) > I'll change it to pdn-gpios since it could be easier to match with the doc. -- Regards, Laurent Pinchart