From mboxrd@z Thu Jan 1 00:00:00 1970 From: Thomas Monjalon Subject: Re: [PATCH v9 03/12] telemetry: initial telemetry infrastructure Date: Sat, 27 Oct 2018 03:56:08 +0200 Message-ID: <3436860.VK1RJtmnne@xps> References: <20181024160311.85457-1-kevin.laatz@intel.com> <20181026235933.79779-1-harry.van.haaren@intel.com> <20181026235933.79779-4-harry.van.haaren@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7Bit Cc: dev@dpdk.org, bruce.richardson@intel.com, stephen@networkplumber.org, gaetan.rivet@6wind.com, shreyansh.jain@nxp.com, mattias.ronnblom@ericsson.com, Ciara Power , Brian Archbold To: Harry van Haaren , Kevin Laatz , Radu Nicolau , david.hunt@intel.com Return-path: Received: from out3-smtp.messagingengine.com (out3-smtp.messagingengine.com [66.111.4.27]) by dpdk.org (Postfix) with ESMTP id 745C52B8C for ; Sat, 27 Oct 2018 03:56:05 +0200 (CEST) In-Reply-To: <20181026235933.79779-4-harry.van.haaren@intel.com> List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 27/10/2018 01:59, Harry van Haaren: > --- a/mk/rte.vars.mk > +++ b/mk/rte.vars.mk > +JANSSON := $(shell pkg-config --exists jansson; echo $$?) > +ifneq ($(JANSSON),0) > +$(warning Jansson not found, disabling RTE_LIBRTE_TELEMETRY) > +CONFIG_RTE_LIBRTE_TELEMETRY = n > +endif It fails for cross-compilation. Example: When compiling i686 on x86_64 host, no error with pkg-config --exists jansson but fails when linking: /usr/bin/ld: skipping incompatible /usr/lib/gcc/x86_64-pc-linux-gnu/8.2.1/../../../libjansson.so when searching for -ljansson /usr/bin/ld: skipping incompatible /usr/lib/gcc/x86_64-pc-linux-gnu/8.2.1/../../../libjansson.a when searching for -ljansson /usr/bin/ld: skipping incompatible /usr/lib/libjansson.so when searching for -ljansson /usr/bin/ld: skipping incompatible /usr/lib/libjansson.a when searching for -ljansson /usr/bin/ld: cannot find -ljansson Note: there is the same issue with examples/vm_power_manager/Makefile I start thinking it is not reasonnable to enable an optional dependency in our Makefiles. Perhaps the only solution is to use meson...