From: Roopa Prabhu <roopa@nvidia.com>
To: David Miller <davem@davemloft.net>, <roopa@cumulusnetworks.com>
Cc: <kuba@kernel.org>, <netdev@vger.kernel.org>,
<nikolay@cumulusnetworks.com>
Subject: Re: [PATCH net-next] rtnetlink: add support for protodown reason
Date: Thu, 30 Jul 2020 19:59:06 -0700 [thread overview]
Message-ID: <344b71b6-82f8-bc7a-235b-6b372415084a@nvidia.com> (raw)
In-Reply-To: <20200730.163820.505646845935151146.davem@davemloft.net>
On 7/30/20 4:38 PM, David Miller wrote:
> From: Roopa Prabhu <roopa@cumulusnetworks.com>
> Date: Mon, 27 Jul 2020 12:21:17 -0700
>
>> +/**
>> + * dev_get_proto_down_reason - returns protodown reason
>> + *
>> + * @dev: device
>> + */
>> +u32 dev_get_proto_down_reason(const struct net_device *dev)
>> +{
>> + return dev->proto_down_reason;
>> +}
>> +EXPORT_SYMBOL(dev_get_proto_down_reason);
> This helper is excessive, please remove it and just dereference the
> netdev member directly.
>
> Thank you.
agree, will send v2. (it was meant to do more than just that initially)
prev parent reply other threads:[~2020-07-31 2:59 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-27 19:21 [PATCH net-next] rtnetlink: add support for protodown reason Roopa Prabhu
2020-07-27 20:47 ` Stephen Hemminger
2020-07-27 22:43 ` Roopa Prabhu
2020-07-30 23:38 ` David Miller
2020-07-31 2:59 ` Roopa Prabhu [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=344b71b6-82f8-bc7a-235b-6b372415084a@nvidia.com \
--to=roopa@nvidia.com \
--cc=davem@davemloft.net \
--cc=kuba@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=nikolay@cumulusnetworks.com \
--cc=roopa@cumulusnetworks.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.