From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:54833) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1btdh2-0007zg-3o for qemu-devel@nongnu.org; Mon, 10 Oct 2016 12:44:49 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1btdh0-0001cd-Ah for qemu-devel@nongnu.org; Mon, 10 Oct 2016 12:44:47 -0400 References: <1475232808-4852-1-git-send-email-vsementsov@virtuozzo.com> <1475232808-4852-19-git-send-email-vsementsov@virtuozzo.com> From: Max Reitz Message-ID: <344ea26a-b476-965a-920e-19a4ff94be7c@redhat.com> Date: Mon, 10 Oct 2016 18:44:36 +0200 MIME-Version: 1.0 In-Reply-To: <1475232808-4852-19-git-send-email-vsementsov@virtuozzo.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="qaDFW53uPJRae6FcISllOMV1gPV9f9FoX" Subject: Re: [Qemu-devel] [PATCH 18/22] qapi: add md5 checksum of last dirty bitmap level to query-block List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Vladimir Sementsov-Ogievskiy , qemu-block@nongnu.org, qemu-devel@nongnu.org Cc: kwolf@redhat.com, armbru@redhat.com, eblake@redhat.com, jsnow@redhat.com, famz@redhat.com, den@openvz.org, stefanha@redhat.com, pbonzini@redhat.com This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --qaDFW53uPJRae6FcISllOMV1gPV9f9FoX From: Max Reitz To: Vladimir Sementsov-Ogievskiy , qemu-block@nongnu.org, qemu-devel@nongnu.org Cc: kwolf@redhat.com, armbru@redhat.com, eblake@redhat.com, jsnow@redhat.com, famz@redhat.com, den@openvz.org, stefanha@redhat.com, pbonzini@redhat.com Message-ID: <344ea26a-b476-965a-920e-19a4ff94be7c@redhat.com> Subject: Re: [PATCH 18/22] qapi: add md5 checksum of last dirty bitmap level to query-block References: <1475232808-4852-1-git-send-email-vsementsov@virtuozzo.com> <1475232808-4852-19-git-send-email-vsementsov@virtuozzo.com> In-Reply-To: <1475232808-4852-19-git-send-email-vsementsov@virtuozzo.com> Content-Type: text/plain; charset=iso-8859-15 Content-Transfer-Encoding: quoted-printable On 30.09.2016 12:53, Vladimir Sementsov-Ogievskiy wrote: > Reviewed-by: John Snow > Reviewed-by: Eric Blake > Signed-off-by: Vladimir Sementsov-Ogievskiy > --- > block/dirty-bitmap.c | 1 + > include/qemu/hbitmap.h | 8 ++++++++ > qapi/block-core.json | 5 ++++- > util/hbitmap.c | 8 ++++++++ > 4 files changed, 21 insertions(+), 1 deletion(-) Having read John's and Eric's comments, I won't block this patch, but I won't give an R-b either. It's probably true that this will not significantly slow down the query-block call, but doing this only for debugging does not seem right to me. I'm not sure what the right way would be to get this information out (...maybe make it optional and set it only if qtest_enabled() is true?), but in my opinion this is not the right way. Since I'm not the maintainer of the bitmap code (Fam and John are, even though their MAINTAINERS patch is not in master still...), I can't and won't block this, though. Max --qaDFW53uPJRae6FcISllOMV1gPV9f9FoX Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- iQEvBAEBCAAZBQJX+8V0EhxtcmVpdHpAcmVkaGF0LmNvbQAKCRD0B9sAYdXPQHFf B/9jv8X70qCo5peofXJ1pyR+hqVB9NuWcY+xhuZko1a/WWQ86V+wrym3BIKRkS0I sPTyRLGFTIHFAPd1CPKDh7HbowmQjyGg9hcLaGalcLjaZK6uz4lTSMUt8l1OU8W4 U2w62DhnL2yaBl10C9tO1jBp/C5eyj/ljSm9b47zRFptvN065O+vw7TsSDiEcKrD R15G6lhFounhv3PmsiPSnRolJA3Whttpgpv1KPaVvQ1CB6cJdNkon+EQutUyZ3gj UfZ2JxCNyv4EVfvBgM1iZ/XnAivFpzeLJaBEOi45TwXOYAxXNeaafLTaW6A7OzbA W26mWiJR2GeXKQU3mbAV2FjT =pNjg -----END PGP SIGNATURE----- --qaDFW53uPJRae6FcISllOMV1gPV9f9FoX--