From mboxrd@z Thu Jan 1 00:00:00 1970 From: Thomas Monjalon Subject: Re: [PATCH] drivers/net: document missing speed capabilities feature Date: Tue, 16 May 2017 12:02:57 +0200 Message-ID: <3454007.3ZDP6eXIq0@xps> References: <20170510131053.75843-1-ferruh.yigit@intel.com> <17406199.hqjMraK9H2@xps> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7Bit Cc: Ferruh Yigit , dev@dpdk.org, Shepard Siegel , Ed Czeck , John Miller , John McNamara , Harish Patil , Rasesh Mody , Rahul Lakkireddy , Hemant Agrawal , Shreyansh Jain , Wenzhuo Lu , Marcin Wojtas , Michal Krawczyk , Guy Tzalik , Evgeny Schemeilin , Jing Chen , Helin Zhang , Jingjing Wu , Konstantin Ananyev , Adrien Mazarguil , Nelio Laranjeiro , Matej Vido Return-path: Received: from out4-smtp.messagingengine.com (out4-smtp.messagingengine.com [66.111.4.28]) by dpdk.org (Postfix) with ESMTP id 4FC991F5 for ; Tue, 16 May 2017 12:03:00 +0200 (CEST) In-Reply-To: List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 16/05/2017 11:39, Alejandro Lucero: > Maybe we need another feature for detected link speed report capability. > > There is already support for ETH_SPEED_NUM_NONE if the speed is not defined > or it can not be specified by the device. Netronome has some firmwares > without that link speed report capability, although maybe we are not the > only ones with that problem. > > > What do you think about this? Yes, you mean you can advertise a speed capability, but cannot report the real negotiated speed, right? So we could add this feature. There are also virtual drivers which cannot report some real speed.