From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752024AbeENCg2 (ORCPT ); Sun, 13 May 2018 22:36:28 -0400 Received: from perceval.ideasonboard.com ([213.167.242.64]:59558 "EHLO perceval.ideasonboard.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751219AbeENCg0 (ORCPT ); Sun, 13 May 2018 22:36:26 -0400 From: Laurent Pinchart To: Simon Horman Cc: Niklas =?ISO-8859-1?Q?S=F6derlund?= , Jacopo Mondi , geert@glider.be, magnus.damm@gmail.com, robh+dt@kernel.org, linux-renesas-soc@vger.kernel.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 2/3] arm64: dts: renesas: r8a77995: Add VIN4 Date: Mon, 14 May 2018 05:36:41 +0300 Message-ID: <3456643.qNU80MrgjU@avalon> Organization: Ideas on Board Oy In-Reply-To: <20180511134516.omsv25i2wi4cxypc@verge.net.au> References: <1526032802-14376-1-git-send-email-jacopo+renesas@jmondi.org> <20180511112523.GK18974@bigcity.dyn.berto.se> <20180511134516.omsv25i2wi4cxypc@verge.net.au> MIME-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Transfer-Encoding: 8bit X-MIME-Autoconverted: from quoted-printable to 8bit by mail.home.local id w4E2aa6H006610 Hello, On Friday, 11 May 2018 16:45:16 EEST Simon Horman wrote: > On Fri, May 11, 2018 at 01:25:23PM +0200, Niklas Söderlund wrote: > > Hi Jacopo, > > > > Thanks for your work. > > > > On 2018-05-11 12:00:01 +0200, Jacopo Mondi wrote: > > > Describe VIN4 interface for R-Car D3 R8A77995 SoC. > > > > > > Signed-off-by: Jacopo Mondi > > > > Acked-by: Niklas Söderlund > > > >> --- > >> > >> arch/arm64/boot/dts/renesas/r8a77995.dtsi | 11 +++++++++++ > >> 1 file changed, 11 insertions(+) > >> > >> diff --git a/arch/arm64/boot/dts/renesas/r8a77995.dtsi > >> b/arch/arm64/boot/dts/renesas/r8a77995.dtsi index 82aed7e..bdf7017 > >> 100644 > >> --- a/arch/arm64/boot/dts/renesas/r8a77995.dtsi > >> +++ b/arch/arm64/boot/dts/renesas/r8a77995.dtsi > >> @@ -783,6 +783,17 @@ > >> }; > >> }; > >> }; > >> + > >> + vin4: video@e6ef4000 { > >> + compatible = "renesas,vin-r8a77995"; > >> + reg = <0 0xe6ef4000 0 0x1000>; > >> + interrupts = ; > >> + clocks = <&cpg CPG_MOD 807>; > >> + power-domains = <&sysc R8A77995_PD_ALWAYS_ON>; > >> + resets = <&cpg 807>; > >> + renesas,id = <4>; > >> + status = "disabled"; > >> + }; > >> }; > > Thanks, I have moved the new node to preserve sorting of nodes by bus > address and applied the result. It is as follows: > > From: Jacopo Mondi > Subject: [PATCH] arm64: dts: renesas: r8a77995: Add VIN4 > > Describe VIN4 interface for R-Car D3 R8A77995 SoC. > > Signed-off-by: Jacopo Mondi > Acked-by: Niklas Söderlund > [simon: sorted node by bus address] > Signed-off-by: Simon Horman Reviewed-by: Laurent Pinchart > --- > arch/arm64/boot/dts/renesas/r8a77995.dtsi | 11 +++++++++++ > 1 file changed, 11 insertions(+) > > diff --git a/arch/arm64/boot/dts/renesas/r8a77995.dtsi > b/arch/arm64/boot/dts/renesas/r8a77995.dtsi index > ba98865b0c9b..2506f46293e8 100644 > --- a/arch/arm64/boot/dts/renesas/r8a77995.dtsi > +++ b/arch/arm64/boot/dts/renesas/r8a77995.dtsi > @@ -610,6 +610,17 @@ > status = "disabled"; > }; > > + vin4: video@e6ef4000 { > + compatible = "renesas,vin-r8a77995"; > + reg = <0 0xe6ef4000 0 0x1000>; > + interrupts = ; > + clocks = <&cpg CPG_MOD 807>; > + power-domains = <&sysc R8A77995_PD_ALWAYS_ON>; > + resets = <&cpg 807>; > + renesas,id = <4>; > + status = "disabled"; > + }; > + > ohci0: usb@ee080000 { > compatible = "generic-ohci"; > reg = <0 0xee080000 0 0x100>; -- Regards, Laurent Pinchart From mboxrd@z Thu Jan 1 00:00:00 1970 From: laurent.pinchart@ideasonboard.com (Laurent Pinchart) Date: Mon, 14 May 2018 05:36:41 +0300 Subject: [PATCH 2/3] arm64: dts: renesas: r8a77995: Add VIN4 In-Reply-To: <20180511134516.omsv25i2wi4cxypc@verge.net.au> References: <1526032802-14376-1-git-send-email-jacopo+renesas@jmondi.org> <20180511112523.GK18974@bigcity.dyn.berto.se> <20180511134516.omsv25i2wi4cxypc@verge.net.au> Message-ID: <3456643.qNU80MrgjU@avalon> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org Hello, On Friday, 11 May 2018 16:45:16 EEST Simon Horman wrote: > On Fri, May 11, 2018 at 01:25:23PM +0200, Niklas S?derlund wrote: > > Hi Jacopo, > > > > Thanks for your work. > > > > On 2018-05-11 12:00:01 +0200, Jacopo Mondi wrote: > > > Describe VIN4 interface for R-Car D3 R8A77995 SoC. > > > > > > Signed-off-by: Jacopo Mondi > > > > Acked-by: Niklas S?derlund > > > >> --- > >> > >> arch/arm64/boot/dts/renesas/r8a77995.dtsi | 11 +++++++++++ > >> 1 file changed, 11 insertions(+) > >> > >> diff --git a/arch/arm64/boot/dts/renesas/r8a77995.dtsi > >> b/arch/arm64/boot/dts/renesas/r8a77995.dtsi index 82aed7e..bdf7017 > >> 100644 > >> --- a/arch/arm64/boot/dts/renesas/r8a77995.dtsi > >> +++ b/arch/arm64/boot/dts/renesas/r8a77995.dtsi > >> @@ -783,6 +783,17 @@ > >> }; > >> }; > >> }; > >> + > >> + vin4: video at e6ef4000 { > >> + compatible = "renesas,vin-r8a77995"; > >> + reg = <0 0xe6ef4000 0 0x1000>; > >> + interrupts = ; > >> + clocks = <&cpg CPG_MOD 807>; > >> + power-domains = <&sysc R8A77995_PD_ALWAYS_ON>; > >> + resets = <&cpg 807>; > >> + renesas,id = <4>; > >> + status = "disabled"; > >> + }; > >> }; > > Thanks, I have moved the new node to preserve sorting of nodes by bus > address and applied the result. It is as follows: > > From: Jacopo Mondi > Subject: [PATCH] arm64: dts: renesas: r8a77995: Add VIN4 > > Describe VIN4 interface for R-Car D3 R8A77995 SoC. > > Signed-off-by: Jacopo Mondi > Acked-by: Niklas S?derlund > [simon: sorted node by bus address] > Signed-off-by: Simon Horman Reviewed-by: Laurent Pinchart > --- > arch/arm64/boot/dts/renesas/r8a77995.dtsi | 11 +++++++++++ > 1 file changed, 11 insertions(+) > > diff --git a/arch/arm64/boot/dts/renesas/r8a77995.dtsi > b/arch/arm64/boot/dts/renesas/r8a77995.dtsi index > ba98865b0c9b..2506f46293e8 100644 > --- a/arch/arm64/boot/dts/renesas/r8a77995.dtsi > +++ b/arch/arm64/boot/dts/renesas/r8a77995.dtsi > @@ -610,6 +610,17 @@ > status = "disabled"; > }; > > + vin4: video at e6ef4000 { > + compatible = "renesas,vin-r8a77995"; > + reg = <0 0xe6ef4000 0 0x1000>; > + interrupts = ; > + clocks = <&cpg CPG_MOD 807>; > + power-domains = <&sysc R8A77995_PD_ALWAYS_ON>; > + resets = <&cpg 807>; > + renesas,id = <4>; > + status = "disabled"; > + }; > + > ohci0: usb at ee080000 { > compatible = "generic-ohci"; > reg = <0 0xee080000 0 0x100>; -- Regards, Laurent Pinchart