From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1752749AbbCKVJz (ORCPT <rfc822;w@1wt.eu>);
	Wed, 11 Mar 2015 17:09:55 -0400
Received: from mout.kundenserver.de ([212.227.17.13]:49421 "EHLO
	mout.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1751511AbbCKVJt (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Wed, 11 Mar 2015 17:09:49 -0400
From: Arnd Bergmann <arnd@arndb.de>
To: linux-arm-kernel@lists.infradead.org
Cc: Julia Lawall <Julia.Lawall@lip6.fr>, Krzysztof Halasa <khalasa@piap.pl>,
        Russell King <linux@arm.linux.org.uk>, kernel-janitors@vger.kernel.org,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH 14/15] ARM: cns3xxx: don't export static symbol
Date: Wed, 11 Mar 2015 22:09:20 +0100
Message-ID: <34582069.IEgAMbDRxk@wuerfel>
User-Agent: KMail/4.11.5 (Linux/3.16.0-10-generic; KDE/4.11.5; x86_64; ; )
In-Reply-To: <1426092997-30605-15-git-send-email-Julia.Lawall@lip6.fr>
References: <1426092997-30605-1-git-send-email-Julia.Lawall@lip6.fr> <1426092997-30605-15-git-send-email-Julia.Lawall@lip6.fr>
MIME-Version: 1.0
Content-Transfer-Encoding: 7Bit
Content-Type: text/plain; charset="us-ascii"
X-Provags-ID: V03:K0:O5BiNYnIrzHo9dspdJoL54zGlK5QZ4NT/Fb3S62bhaEOe+ztCfZ
 NPl/Y9q1bwZKOFSv78zVCJyj845E1uvYS5JyrosHKAtVo7+Afiv60LZixeZGcpqLGIks/1e
 S1gSCY5P1DH248Go3gL7Aw6/YVRrfgxxq8D9ehYSJIakeHIDaZ/YG6hOSQzbj+fGCTMMtBr
 hfgw+QLhDVGJEFL1xlU6w==
X-UI-Out-Filterresults: notjunk:1;
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Wednesday 11 March 2015 17:56:36 Julia Lawall wrote:
> From: Julia Lawall <Julia.Lawall@lip6.fr>
> 
> The semantic patch that fixes this problem is as follows:
> (http://coccinelle.lip6.fr/)
> 
> // <smpl>
> @r@
> type T;
> identifier f;
> @@
> 
> static T f (...) { ... }
> 
> @@
> identifier r.f;
> declarer name EXPORT_SYMBOL;
> @@
> 
> -EXPORT_SYMBOL(f);
> // </smpl>
> 
> Signed-off-by: Julia Lawall <Julia.Lawall@lip6.fr>
> 

Looks good. Krzysztof, do you want to pick this up and send me a
pull request together with other patches, or should I apply this
to the arm-soc fixes directly?

	Arnd

From mboxrd@z Thu Jan  1 00:00:00 1970
From: Arnd Bergmann <arnd@arndb.de>
Date: Wed, 11 Mar 2015 21:09:20 +0000
Subject: Re: [PATCH 14/15] ARM: cns3xxx: don't export static symbol
Message-Id: <34582069.IEgAMbDRxk@wuerfel>
List-Id: <kernel-janitors.vger.kernel.org>
References: <1426092997-30605-1-git-send-email-Julia.Lawall@lip6.fr>
 <1426092997-30605-15-git-send-email-Julia.Lawall@lip6.fr>
In-Reply-To: <1426092997-30605-15-git-send-email-Julia.Lawall@lip6.fr>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
To: linux-arm-kernel@lists.infradead.org

On Wednesday 11 March 2015 17:56:36 Julia Lawall wrote:
> From: Julia Lawall <Julia.Lawall@lip6.fr>
> 
> The semantic patch that fixes this problem is as follows:
> (http://coccinelle.lip6.fr/)
> 
> // <smpl>
> @r@
> type T;
> identifier f;
> @@
> 
> static T f (...) { ... }
> 
> @@
> identifier r.f;
> declarer name EXPORT_SYMBOL;
> @@
> 
> -EXPORT_SYMBOL(f);
> // </smpl>
> 
> Signed-off-by: Julia Lawall <Julia.Lawall@lip6.fr>
> 

Looks good. Krzysztof, do you want to pick this up and send me a
pull request together with other patches, or should I apply this
to the arm-soc fixes directly?

	Arnd

From mboxrd@z Thu Jan  1 00:00:00 1970
From: arnd@arndb.de (Arnd Bergmann)
Date: Wed, 11 Mar 2015 22:09:20 +0100
Subject: [PATCH 14/15] ARM: cns3xxx: don't export static symbol
In-Reply-To: <1426092997-30605-15-git-send-email-Julia.Lawall@lip6.fr>
References: <1426092997-30605-1-git-send-email-Julia.Lawall@lip6.fr>
 <1426092997-30605-15-git-send-email-Julia.Lawall@lip6.fr>
Message-ID: <34582069.IEgAMbDRxk@wuerfel>
To: linux-arm-kernel@lists.infradead.org
List-Id: linux-arm-kernel.lists.infradead.org

On Wednesday 11 March 2015 17:56:36 Julia Lawall wrote:
> From: Julia Lawall <Julia.Lawall@lip6.fr>
> 
> The semantic patch that fixes this problem is as follows:
> (http://coccinelle.lip6.fr/)
> 
> // <smpl>
> @r@
> type T;
> identifier f;
> @@
> 
> static T f (...) { ... }
> 
> @@
> identifier r.f;
> declarer name EXPORT_SYMBOL;
> @@
> 
> -EXPORT_SYMBOL(f);
> // </smpl>
> 
> Signed-off-by: Julia Lawall <Julia.Lawall@lip6.fr>
> 

Looks good. Krzysztof, do you want to pick this up and send me a
pull request together with other patches, or should I apply this
to the arm-soc fixes directly?

	Arnd