Re: [PATCH v6 0/8] link bonding

["Doherty, Declan" <declan.doherty-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>]

Hey Thomas, have you had a chance to have a look at this patchset, if you have any comments or issues can you let me know asap, as the patch sets for link bonding modes 4 & 5 are dependent on this set and I don't want to be blocking them from the next release candidate.

Thanks 
Declan

> -----Original Message-----
> From: De Lara Guarch, Pablo
> Sent: Friday, November 7, 2014 4:41 PM
> To: Doherty, Declan; dev-VfR2kkLFssw@public.gmane.org
> Cc: thomas.monjalon-pdR9zngts4EAvxtiuMwx3w@public.gmane.org
> Subject: RE: [PATCH v6 0/8] link bonding
> 
> 
> 
> > -----Original Message-----
> > From: Doherty, Declan
> > Sent: Friday, November 07, 2014 12:23 PM
> > To: dev-VfR2kkLFssw@public.gmane.org
> > Cc: De Lara Guarch, Pablo; thomas.monjalon-pdR9zngts4EAvxtiuMwx3w@public.gmane.org; Doherty, Declan
> > Subject: [PATCH v6 0/8] link bonding
> >
> > v6:
> > - Re-based to dpdk.org addressing associated issues for MBUF_REFCNT
> > - Added details to testpmd user guide for new command to set link status
> > polling interval.
> >
> > v5:
> > - Fix uninitialized variable in broadcast_tx_burst function which caused a
> >   build error in 32-bit build
> > - Address unit test issue which is exposed by new test in mode 4/5 patch sets
> >
> > v4:
> > - Rebased to account for changes in master.
> > - Fix for rte_eth_bond_slaves_get() introduced in v3 patch set
> > - Addressed issue around disabling/enabling link status polling around
> > adding/
> >   removing slaves devices.
> >
> > v3 :
> > - Typo fix for the bond free mbufs patch.
> > - Rebased to account for changes in the mbuf patches.
> > - Add support for slave devices which don't support link status interrupts
> > - Tidy up the link bonding unit test so that all tests use the new test macros.
> >
> > v2 :
> > Addresses issues with the logic around the handling of fail transmissions.
> > In this version all modes behave in a manner similar to a standard PMD,
> > returning the number of successfully transmitted mbufs and with the failing
> > mbufs at the end of bufs array for freeing / retransmission by the
> > application software
> >
> > v1:
> >
> > This patch set adds support for link status interrupt in the link bonding
> > pmd. It also contains some patches to tidy up the code structure and to
> > of the link bonding code and to fix bugs relating to transmission
> > failures in the under lying slave pmd which could lead to leaked mbufs.
> >
> >
> > Declan Doherty (8):
> >   bond: link status interrupt support
> >   bond: removing switch statement from rx burst method
> >   bond: fix naming inconsistency in tx_burst_round_robin
> >   bond: free mbufs if transmission fails in bonding tx_burst functions
> >   test app: adding support for generating variable sized packet
> >   testpmd: adding parameter to reconfig method to set socket_id when
> >     adding new port to portlist
> >   bond: lsc polling support
> >   bond: unit test test macro refactor
> >
> >  app/test-pmd/cmdline.c                      |   65 +-
> >  app/test-pmd/testpmd.c                      |    3 +-
> >  app/test-pmd/testpmd.h                      |    2 +-
> >  app/test/packet_burst_generator.c           |   25 +-
> >  app/test/packet_burst_generator.h           |    6 +-
> >  app/test/test.h                             |    7 +-
> >  app/test/test_link_bonding.c                | 3347 ++++++++++++++-------------
> >  app/test/virtual_pmd.c                      |   96 +-
> >  app/test/virtual_pmd.h                      |   53 +-
> >  doc/guides/testpmd_app_ug/testpmd_funcs.rst |   19 +
> >  lib/librte_pmd_bond/rte_eth_bond.h          |   80 +
> >  lib/librte_pmd_bond/rte_eth_bond_api.c      |  319 ++-
> >  lib/librte_pmd_bond/rte_eth_bond_args.c     |   28 +-
> >  lib/librte_pmd_bond/rte_eth_bond_pmd.c      |  553 +++--
> >  lib/librte_pmd_bond/rte_eth_bond_private.h  |   71 +-
> >  15 files changed, 2715 insertions(+), 1959 deletions(-)
> >
> > --
> > 1.7.12.2
> 
> Acked-by: Pablo de Lara <pablo.de.lara.guarch-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>