Re: [PATCH v2 0/2] tests/acceptance: Test Aspeed ARM machines

From: "Cédric Le Goater" <clg@kaod.org>
To: Peter Maydell <peter.maydell@linaro.org>, Joel Stanley <joel@jms.id.au>
Cc: "Andrew Jeffery" <andrew@aj.id.au>,
	"QEMU Developers" <qemu-devel@nongnu.org>,
	"Wainer dos Santos Moschetta" <wainersm@redhat.com>,
	qemu-arm <qemu-arm@nongnu.org>, "Cleber Rosa" <crosa@redhat.com>,
	"Philippe Mathieu-Daudé" <philmd@redhat.com>
Subject: Re: [PATCH v2 0/2] tests/acceptance: Test Aspeed ARM machines
Date: Fri, 5 Mar 2021 16:38:56 +0100	[thread overview]
Message-ID: <345ad50c-ac43-2337-29e4-b7f060896434@kaod.org> (raw)
In-Reply-To: <CAFEAcA9jux7H2cAwgrndvUv5=fivgQwbWDUEbU7rv7xUb=rz4A@mail.gmail.com>

On 3/5/21 4:12 PM, Peter Maydell wrote:
> On Thu, 4 Mar 2021 at 12:40, Joel Stanley <joel@jms.id.au> wrote:
>>
>> v2: Fix ast2600 test, thanks Cédric for the review.
>>
>> This adds tests for the Aspeed ARM SoCs. The AST2400 and AST2500 tests
>> use OpenBMC images from that project, fetched from github releases. The
>> AST2600 test uses a Debian arm32 kernel.
> 
> Just a note that I'm assuming that Cédric will gather up the
> various aspeed related patches that have been on the list recently
> and send a pullreq for them. (Having been on holiday my to-review
> queue is pretty full so I've just ignored anything aspeed-related;
> let me know if there is anything you specifically want me to look
> at, queue, whatever.)
>
> PS: softfreeze is 16 March so a pullreq on list sometime next week
> would probably be the ideal.

Yes. I am preparing the PR. 

  aspeed: Integrate HACE
  hw: Model ASPEED's Hash and Crypto Engine
  hw/misc: Model KCS devices in the Aspeed LPC controller
  hw/misc: Add a basic Aspeed LPC controller model
  hw/arm: ast2600: Correct the iBT interrupt ID
  hw/arm: ast2600: Set AST2600_MAX_IRQ to value from datasheet
  hw/arm: ast2600: Force a multiple of 32 of IRQs for the GIC
  hw/arm/aspeed: Fix location of firmware images in documentation
  aspeed: Emulate the AST2600A3
  tests/acceptance: Test ast2600 machine
  tests/acceptance: Test ast2400 and ast2500 machines
  arm/ast2600: Fix SMP booting with -kernel

The HACE patchset needs a second look from an Aspeed-aware person and 
I have some questions on AST2600A3.

Merging these acceptance tests would be really nice. Have we addressed
all you concerns Philippe regarding the image downloads ?

Thanks,

C.