From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751642AbdEASeA (ORCPT ); Mon, 1 May 2017 14:34:00 -0400 Received: from mail-wm0-f68.google.com ([74.125.82.68]:33865 "EHLO mail-wm0-f68.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751593AbdEASdy (ORCPT ); Mon, 1 May 2017 14:33:54 -0400 Subject: Re: [PATCH man-pages 3/5] ioctl_userfaultfd.2: add BUGS section To: Mike Rapoport References: <1493617399-20897-1-git-send-email-rppt@linux.vnet.ibm.com> <1493617399-20897-4-git-send-email-rppt@linux.vnet.ibm.com> Cc: mtk.manpages@gmail.com, Andrea Arcangeli , linux-kernel@vger.kernel.org, linux-mm@kvack.org, linux-man@vger.kernel.org From: "Michael Kerrisk (man-pages)" Message-ID: <345c064d-83fe-3e40-c5cb-5d4b6e5cdff4@gmail.com> Date: Mon, 1 May 2017 20:33:50 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.4.0 MIME-Version: 1.0 In-Reply-To: <1493617399-20897-4-git-send-email-rppt@linux.vnet.ibm.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Mike, I've applied this, but have a question. On 05/01/2017 07:43 AM, Mike Rapoport wrote: > The features handshake is not quite convenient. > Elaborate about it in the BUGS section. > > Signed-off-by: Mike Rapoport > --- > man2/ioctl_userfaultfd.2 | 9 +++++++++ > 1 file changed, 9 insertions(+) > > diff --git a/man2/ioctl_userfaultfd.2 b/man2/ioctl_userfaultfd.2 > index e12b9de..50316de 100644 > --- a/man2/ioctl_userfaultfd.2 > +++ b/man2/ioctl_userfaultfd.2 > @@ -650,6 +650,15 @@ operations are Linux-specific. > .SH EXAMPLE > See > .BR userfaultfd (2). > +.SH BUGS > +In order to detect available userfault features and > +enable certain subset of those features I changed "certain" to "some". ("certain subset" here also would sound like "some particular subset" of those features.) Okay? > +the usefault file descriptor must be closed after the first > +.BR UFFDIO_API > +operation that queries features availability and re-opened before > +the second > +.BR UFFDIO_API > +call that actually enables the desired features. > .SH SEE ALSO > .BR ioctl (2), > .BR mmap (2), Cheers, Michael -- Michael Kerrisk Linux man-pages maintainer; http://www.kernel.org/doc/man-pages/ Linux/UNIX System Programming Training: http://man7.org/training/ From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Michael Kerrisk (man-pages)" Subject: Re: [PATCH man-pages 3/5] ioctl_userfaultfd.2: add BUGS section Date: Mon, 1 May 2017 20:33:50 +0200 Message-ID: <345c064d-83fe-3e40-c5cb-5d4b6e5cdff4@gmail.com> References: <1493617399-20897-1-git-send-email-rppt@linux.vnet.ibm.com> <1493617399-20897-4-git-send-email-rppt@linux.vnet.ibm.com> Mime-Version: 1.0 Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <1493617399-20897-4-git-send-email-rppt@linux.vnet.ibm.com> Sender: owner-linux-mm@kvack.org To: Mike Rapoport Cc: mtk.manpages@gmail.com, Andrea Arcangeli , linux-kernel@vger.kernel.org, linux-mm@kvack.org, linux-man@vger.kernel.org List-Id: linux-man@vger.kernel.org Hi Mike, I've applied this, but have a question. On 05/01/2017 07:43 AM, Mike Rapoport wrote: > The features handshake is not quite convenient. > Elaborate about it in the BUGS section. > > Signed-off-by: Mike Rapoport > --- > man2/ioctl_userfaultfd.2 | 9 +++++++++ > 1 file changed, 9 insertions(+) > > diff --git a/man2/ioctl_userfaultfd.2 b/man2/ioctl_userfaultfd.2 > index e12b9de..50316de 100644 > --- a/man2/ioctl_userfaultfd.2 > +++ b/man2/ioctl_userfaultfd.2 > @@ -650,6 +650,15 @@ operations are Linux-specific. > .SH EXAMPLE > See > .BR userfaultfd (2). > +.SH BUGS > +In order to detect available userfault features and > +enable certain subset of those features I changed "certain" to "some". ("certain subset" here also would sound like "some particular subset" of those features.) Okay? > +the usefault file descriptor must be closed after the first > +.BR UFFDIO_API > +operation that queries features availability and re-opened before > +the second > +.BR UFFDIO_API > +call that actually enables the desired features. > .SH SEE ALSO > .BR ioctl (2), > .BR mmap (2), Cheers, Michael -- Michael Kerrisk Linux man-pages maintainer; http://www.kernel.org/doc/man-pages/ Linux/UNIX System Programming Training: http://man7.org/training/ -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org